Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-11 Thread Bjorn Helgaas 
[+cc Tyrel]

On Wed, Aug 09, 2017 at 05:04:43PM -0500, Rob Herring wrote:
> On Wed, Aug 2, 2017 at 5:39 PM, Bjorn Helgaas  wrote:
> > On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
> >> Now that we have a custom printf format specifier, convert users of
> >> full_name to use %pOF instead. This is preparation to remove storing
> >> of the full path string for each node.
> >>
> >> Signed-off-by: Rob Herring 
> >> Cc: Thomas Petazzoni 
> >> Cc: Jason Cooper 
> >> Cc: Bjorn Helgaas 
> >> Cc: Thierry Reding 
> >> Cc: Jonathan Hunter 
> >> Cc: Benjamin Herrenschmidt 
> >> Cc: Paul Mackerras 
> >> Cc: Michael Ellerman 
> >> Cc: linux-...@vger.kernel.org
> >> Cc: linux-arm-ker...@lists.infradead.org
> >> Cc: linux-te...@vger.kernel.org
> >> Cc: linuxppc-...@lists.ozlabs.org
> >
> > Applied to pci/misc for v4.14, thanks!
> 
> This hasn't shown up in -next.

Thanks, it should be in next-20170811.

I updated it to add Tyrel's reviewed-by, but that's not in -next yet.

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-11 Thread Bjorn Helgaas 
[+cc Tyrel]

On Wed, Aug 09, 2017 at 05:04:43PM -0500, Rob Herring wrote:
> On Wed, Aug 2, 2017 at 5:39 PM, Bjorn Helgaas  wrote:
> > On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
> >> Now that we have a custom printf format specifier, convert users of
> >> full_name to use %pOF instead. This is preparation to remove storing
> >> of the full path string for each node.
> >>
> >> Signed-off-by: Rob Herring 
> >> Cc: Thomas Petazzoni 
> >> Cc: Jason Cooper 
> >> Cc: Bjorn Helgaas 
> >> Cc: Thierry Reding 
> >> Cc: Jonathan Hunter 
> >> Cc: Benjamin Herrenschmidt 
> >> Cc: Paul Mackerras 
> >> Cc: Michael Ellerman 
> >> Cc: linux-...@vger.kernel.org
> >> Cc: linux-arm-ker...@lists.infradead.org
> >> Cc: linux-te...@vger.kernel.org
> >> Cc: linuxppc-...@lists.ozlabs.org
> >
> > Applied to pci/misc for v4.14, thanks!
> 
> This hasn't shown up in -next.

Thanks, it should be in next-20170811.

I updated it to add Tyrel's reviewed-by, but that's not in -next yet.

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-09 Thread Rob Herring 
On Wed, Aug 2, 2017 at 5:39 PM, Bjorn Helgaas  wrote:
> On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring 
>> Cc: Thomas Petazzoni 
>> Cc: Jason Cooper 
>> Cc: Bjorn Helgaas 
>> Cc: Thierry Reding 
>> Cc: Jonathan Hunter 
>> Cc: Benjamin Herrenschmidt 
>> Cc: Paul Mackerras 
>> Cc: Michael Ellerman 
>> Cc: linux-...@vger.kernel.org
>> Cc: linux-arm-ker...@lists.infradead.org
>> Cc: linux-te...@vger.kernel.org
>> Cc: linuxppc-...@lists.ozlabs.org
>
> Applied to pci/misc for v4.14, thanks!

This hasn't shown up in -next.

Rob

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-09 Thread Rob Herring 
On Wed, Aug 2, 2017 at 5:39 PM, Bjorn Helgaas  wrote:
> On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring 
>> Cc: Thomas Petazzoni 
>> Cc: Jason Cooper 
>> Cc: Bjorn Helgaas 
>> Cc: Thierry Reding 
>> Cc: Jonathan Hunter 
>> Cc: Benjamin Herrenschmidt 
>> Cc: Paul Mackerras 
>> Cc: Michael Ellerman 
>> Cc: linux-...@vger.kernel.org
>> Cc: linux-arm-ker...@lists.infradead.org
>> Cc: linux-te...@vger.kernel.org
>> Cc: linuxppc-...@lists.ozlabs.org
>
> Applied to pci/misc for v4.14, thanks!

This hasn't shown up in -next.

Rob

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-04 Thread Tyrel Datwyler 
On 07/18/2017 02:43 PM, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 
> Cc: Thomas Petazzoni 
> Cc: Jason Cooper 
> Cc: Bjorn Helgaas 
> Cc: Thierry Reding 
> Cc: Jonathan Hunter 
> Cc: Benjamin Herrenschmidt 
> Cc: Paul Mackerras 
> Cc: Michael Ellerman 
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-te...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org
> ---
>  drivers/pci/host/pci-mvebu.c| 8 
>  drivers/pci/host/pci-tegra.c| 3 +--
>  drivers/pci/hotplug/pnv_php.c   | 4 ++--
>  drivers/pci/hotplug/rpadlpar_core.c | 4 ++--
>  drivers/pci/hotplug/rpaphp_core.c   | 2 +-
>  drivers/pci/hotplug/rpaphp_pci.c| 4 ++--
>  drivers/pci/hotplug/rpaphp_slot.c   | 4 ++--
>  drivers/pci/pci-sysfs.c | 4 ++--
>  drivers/pci/pci.c   | 4 ++--
>  9 files changed, 18 insertions(+), 19 deletions(-)
> 

Reviewed-by: Tyrel Datwyler

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-04 Thread Tyrel Datwyler 
On 07/18/2017 02:43 PM, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 
> Cc: Thomas Petazzoni 
> Cc: Jason Cooper 
> Cc: Bjorn Helgaas 
> Cc: Thierry Reding 
> Cc: Jonathan Hunter 
> Cc: Benjamin Herrenschmidt 
> Cc: Paul Mackerras 
> Cc: Michael Ellerman 
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-te...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org
> ---
>  drivers/pci/host/pci-mvebu.c| 8 
>  drivers/pci/host/pci-tegra.c| 3 +--
>  drivers/pci/hotplug/pnv_php.c   | 4 ++--
>  drivers/pci/hotplug/rpadlpar_core.c | 4 ++--
>  drivers/pci/hotplug/rpaphp_core.c   | 2 +-
>  drivers/pci/hotplug/rpaphp_pci.c| 4 ++--
>  drivers/pci/hotplug/rpaphp_slot.c   | 4 ++--
>  drivers/pci/pci-sysfs.c | 4 ++--
>  drivers/pci/pci.c   | 4 ++--
>  9 files changed, 18 insertions(+), 19 deletions(-)
> 

Reviewed-by: Tyrel Datwyler

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-02 Thread Bjorn Helgaas 
On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 
> Cc: Thomas Petazzoni 
> Cc: Jason Cooper 
> Cc: Bjorn Helgaas 
> Cc: Thierry Reding 
> Cc: Jonathan Hunter 
> Cc: Benjamin Herrenschmidt 
> Cc: Paul Mackerras 
> Cc: Michael Ellerman 
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-te...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org

Applied to pci/misc for v4.14, thanks!

> ---
>  drivers/pci/host/pci-mvebu.c| 8 
>  drivers/pci/host/pci-tegra.c| 3 +--
>  drivers/pci/hotplug/pnv_php.c   | 4 ++--
>  drivers/pci/hotplug/rpadlpar_core.c | 4 ++--
>  drivers/pci/hotplug/rpaphp_core.c   | 2 +-
>  drivers/pci/hotplug/rpaphp_pci.c| 4 ++--
>  drivers/pci/hotplug/rpaphp_slot.c   | 4 ++--
>  drivers/pci/pci-sysfs.c | 4 ++--
>  drivers/pci/pci.c   | 4 ++--
>  9 files changed, 18 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index f353a6eb2f01..424982997eb9 100644
> --- a/drivers/pci/host/pci-mvebu.c
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -1054,8 +1054,8 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie 
> *pcie,
>   port->pcie = pcie;
> 
>   if (of_property_read_u32(child, "marvell,pcie-port", >port)) {
> - dev_warn(dev, "ignoring %s, missing pcie-port property\n",
> -  of_node_full_name(child));
> + dev_warn(dev, "ignoring %pOF, missing pcie-port property\n",
> +  child);
>   goto skip;
>   }
> 
> @@ -1106,8 +1106,8 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie 
> *pcie,
>   }
> 
>   if (flags & OF_GPIO_ACTIVE_LOW) {
> - dev_info(dev, "%s: reset gpio is active low\n",
> -  of_node_full_name(child));
> + dev_info(dev, "%pOF: reset gpio is active low\n",
> +  child);
>   gpio_flags = GPIOF_ACTIVE_LOW |
>GPIOF_OUT_INIT_LOW;
>   } else {
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index b3722b7709df..7eb9be5ae357 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -1703,8 +1703,7 @@ static int tegra_pcie_get_legacy_regulators(struct 
> tegra_pcie *pcie)
>   pcie->num_supplies = 2;
> 
>   if (pcie->num_supplies == 0) {
> - dev_err(dev, "device %s not supported in legacy mode\n",
> - np->full_name);
> + dev_err(dev, "device %pOF not supported in legacy mode\n", np);
>   return -ENODEV;
>   }
> 
> diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c
> index 7c203198b582..74f6a17e4614 100644
> --- a/drivers/pci/hotplug/pnv_php.c
> +++ b/drivers/pci/hotplug/pnv_php.c
> @@ -163,8 +163,8 @@ static void pnv_php_detach_device_nodes(struct 
> device_node *parent)
>   of_node_put(dn);
>   refcount = kref_read(>kobj.kref);
>   if (refcount != 1)
> - pr_warn("Invalid refcount %d on <%s>\n",
> - refcount, of_node_full_name(dn));
> + pr_warn("Invalid refcount %d on <%pOF>\n",
> + refcount, dn);
> 
>   of_detach_node(dn);
>   }
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c 
> b/drivers/pci/hotplug/rpadlpar_core.c
> index 3f93a4e79595..a3449d717a99 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -150,8 +150,8 @@ static void dlpar_pci_add_bus(struct device_node *dn)
>   /* Add EADS device to PHB bus, adding new entry to bus->devices */
>   dev = of_create_pci_dev(dn, phb->bus, pdn->devfn);
>   if (!dev) {
> - printk(KERN_ERR "%s: failed to create pci dev for %s\n",
> - __func__, dn->full_name);
> + printk(KERN_ERR "%s: failed to create pci dev for %pOF\n",
> + __func__, dn);
>   return;
>   }
> 
> diff --git a/drivers/pci/hotplug/rpaphp_core.c 
> b/drivers/pci/hotplug/rpaphp_core.c
> index 8d132024f06e..1e29abaaea08 100644
> --- a/drivers/pci/hotplug/rpaphp_core.c
> +++ b/drivers/pci/hotplug/rpaphp_core.c
> @@ -318,7 +318,7 @@ int rpaphp_add_slot(struct device_node *dn)
>   if (!is_php_dn(dn, , , , _domains))
>   return 0;
> 
> - dbg("Entry %s: dn->full_name=%s\n",

Re: [PATCH] PCI: Convert to using %pOF instead of full_name

2017-08-02 Thread Bjorn Helgaas 
On Tue, Jul 18, 2017 at 04:43:21PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 
> Cc: Thomas Petazzoni 
> Cc: Jason Cooper 
> Cc: Bjorn Helgaas 
> Cc: Thierry Reding 
> Cc: Jonathan Hunter 
> Cc: Benjamin Herrenschmidt 
> Cc: Paul Mackerras 
> Cc: Michael Ellerman 
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-te...@vger.kernel.org
> Cc: linuxppc-...@lists.ozlabs.org

Applied to pci/misc for v4.14, thanks!

> ---
>  drivers/pci/host/pci-mvebu.c| 8 
>  drivers/pci/host/pci-tegra.c| 3 +--
>  drivers/pci/hotplug/pnv_php.c   | 4 ++--
>  drivers/pci/hotplug/rpadlpar_core.c | 4 ++--
>  drivers/pci/hotplug/rpaphp_core.c   | 2 +-
>  drivers/pci/hotplug/rpaphp_pci.c| 4 ++--
>  drivers/pci/hotplug/rpaphp_slot.c   | 4 ++--
>  drivers/pci/pci-sysfs.c | 4 ++--
>  drivers/pci/pci.c   | 4 ++--
>  9 files changed, 18 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
> index f353a6eb2f01..424982997eb9 100644
> --- a/drivers/pci/host/pci-mvebu.c
> +++ b/drivers/pci/host/pci-mvebu.c
> @@ -1054,8 +1054,8 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie 
> *pcie,
>   port->pcie = pcie;
> 
>   if (of_property_read_u32(child, "marvell,pcie-port", >port)) {
> - dev_warn(dev, "ignoring %s, missing pcie-port property\n",
> -  of_node_full_name(child));
> + dev_warn(dev, "ignoring %pOF, missing pcie-port property\n",
> +  child);
>   goto skip;
>   }
> 
> @@ -1106,8 +1106,8 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie 
> *pcie,
>   }
> 
>   if (flags & OF_GPIO_ACTIVE_LOW) {
> - dev_info(dev, "%s: reset gpio is active low\n",
> -  of_node_full_name(child));
> + dev_info(dev, "%pOF: reset gpio is active low\n",
> +  child);
>   gpio_flags = GPIOF_ACTIVE_LOW |
>GPIOF_OUT_INIT_LOW;
>   } else {
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index b3722b7709df..7eb9be5ae357 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -1703,8 +1703,7 @@ static int tegra_pcie_get_legacy_regulators(struct 
> tegra_pcie *pcie)
>   pcie->num_supplies = 2;
> 
>   if (pcie->num_supplies == 0) {
> - dev_err(dev, "device %s not supported in legacy mode\n",
> - np->full_name);
> + dev_err(dev, "device %pOF not supported in legacy mode\n", np);
>   return -ENODEV;
>   }
> 
> diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c
> index 7c203198b582..74f6a17e4614 100644
> --- a/drivers/pci/hotplug/pnv_php.c
> +++ b/drivers/pci/hotplug/pnv_php.c
> @@ -163,8 +163,8 @@ static void pnv_php_detach_device_nodes(struct 
> device_node *parent)
>   of_node_put(dn);
>   refcount = kref_read(>kobj.kref);
>   if (refcount != 1)
> - pr_warn("Invalid refcount %d on <%s>\n",
> - refcount, of_node_full_name(dn));
> + pr_warn("Invalid refcount %d on <%pOF>\n",
> + refcount, dn);
> 
>   of_detach_node(dn);
>   }
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c 
> b/drivers/pci/hotplug/rpadlpar_core.c
> index 3f93a4e79595..a3449d717a99 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -150,8 +150,8 @@ static void dlpar_pci_add_bus(struct device_node *dn)
>   /* Add EADS device to PHB bus, adding new entry to bus->devices */
>   dev = of_create_pci_dev(dn, phb->bus, pdn->devfn);
>   if (!dev) {
> - printk(KERN_ERR "%s: failed to create pci dev for %s\n",
> - __func__, dn->full_name);
> + printk(KERN_ERR "%s: failed to create pci dev for %pOF\n",
> + __func__, dn);
>   return;
>   }
> 
> diff --git a/drivers/pci/hotplug/rpaphp_core.c 
> b/drivers/pci/hotplug/rpaphp_core.c
> index 8d132024f06e..1e29abaaea08 100644
> --- a/drivers/pci/hotplug/rpaphp_core.c
> +++ b/drivers/pci/hotplug/rpaphp_core.c
> @@ -318,7 +318,7 @@ int rpaphp_add_slot(struct device_node *dn)
>   if (!is_php_dn(dn, , , , _domains))
>   return 0;
> 
> - dbg("Entry %s: dn->full_name=%s\n", __func__, dn->full_name);
> + dbg("Entry %s: dn=%pOF\n", __func__, dn);
> 
>   /* register PCI devices */
>   name = (char *) [1];
> diff --git a/drivers/pci/hotplug/rpaphp_pci.c 
>