Re: [PATCH] PM: runtime: clk: Fix clk_pm_runtime_get() error path

2020-05-26 Thread Rafael J. Wysocki
On Mon, May 25, 2020 at 11:31 AM Ulf Hansson wrote: > > On Fri, 22 May 2020 at 20:39, Rafael J. Wysocki wrote: > > > > On Fri, May 22, 2020 at 7:19 AM Marek Szyprowski > > wrote: > > > > > > Hi Rafael, > > > > > > On 21.05.2020 19:08, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > >

Re: [PATCH] PM: runtime: clk: Fix clk_pm_runtime_get() error path

2020-05-25 Thread Ulf Hansson
On Fri, 22 May 2020 at 20:39, Rafael J. Wysocki wrote: > > On Fri, May 22, 2020 at 7:19 AM Marek Szyprowski > wrote: > > > > Hi Rafael, > > > > On 21.05.2020 19:08, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > clk_pm_runtime_get() assumes that the PM-runtime usage counter w

Re: [PATCH] PM: runtime: clk: Fix clk_pm_runtime_get() error path

2020-05-22 Thread Rafael J. Wysocki
On Fri, May 22, 2020 at 7:19 AM Marek Szyprowski wrote: > > Hi Rafael, > > On 21.05.2020 19:08, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > clk_pm_runtime_get() assumes that the PM-runtime usage counter will > > be dropped by pm_runtime_get_sync() on errors, which is not the case

Re: [PATCH] PM: runtime: clk: Fix clk_pm_runtime_get() error path

2020-05-21 Thread Marek Szyprowski
Hi Rafael, On 21.05.2020 19:08, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > clk_pm_runtime_get() assumes that the PM-runtime usage counter will > be dropped by pm_runtime_get_sync() on errors, which is not the case, > so PM-runtime references to devices acquired by the former are leake