Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 11:37:15AM -0700, Linus Torvalds wrote: > On Tue, Jul 4, 2017 at 10:22 AM, Michal Hocko wrote: > > > > Well, I've been thinking about this some more and the more I think about > > it the less I am convinced we should try to be clever here. Why? Because >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 11:37:15AM -0700, Linus Torvalds wrote: > On Tue, Jul 4, 2017 at 10:22 AM, Michal Hocko wrote: > > > > Well, I've been thinking about this some more and the more I think about > > it the less I am convinced we should try to be clever here. Why? Because > > as soon as

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 4, 2017 at 10:22 AM, Michal Hocko wrote: > > Well, I've been thinking about this some more and the more I think about > it the less I am convinced we should try to be clever here. Why? Because > as soon as somebody tries to manage stacks explicitly you cannot simply

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 4, 2017 at 10:22 AM, Michal Hocko wrote: > > Well, I've been thinking about this some more and the more I think about > it the less I am convinced we should try to be clever here. Why? Because > as soon as somebody tries to manage stacks explicitly you cannot simply > assume anything

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 17:51:40, Willy Tarreau wrote: > On Tue, Jul 04, 2017 at 12:36:11PM +0100, Ben Hutchings wrote: > > > If anywhing this would require to have a loop over all PROT_NONE > > > mappings to not hit into other weird usecases. > > > > That's what I was thinking of. Tried the following

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 17:51:40, Willy Tarreau wrote: > On Tue, Jul 04, 2017 at 12:36:11PM +0100, Ben Hutchings wrote: > > > If anywhing this would require to have a loop over all PROT_NONE > > > mappings to not hit into other weird usecases. > > > > That's what I was thinking of. Tried the following

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 12:36:11PM +0100, Ben Hutchings wrote: > @@ -2323,11 +2330,17 @@ int expand_downwards(struct vm_area_struct *vma, > if (error) > return error; > > - /* Enforce stack_guard_gap */ > + /* > + * Enforce stack_guard_gap, but allow VM_NONE

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 12:36:11PM +0100, Ben Hutchings wrote: > @@ -2323,11 +2330,17 @@ int expand_downwards(struct vm_area_struct *vma, > if (error) > return error; > > - /* Enforce stack_guard_gap */ > + /* > + * Enforce stack_guard_gap, but allow VM_NONE

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 05:27:55PM +0100, John Haxby wrote: > Alas, the people who could confirm this for me are getting ready to > watch fireworks and generally have a good time. Let's hope the fireworks is controlled by Java with on up-to-date kernel so that they can quickly get back to work

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 05:27:55PM +0100, John Haxby wrote: > Alas, the people who could confirm this for me are getting ready to > watch fireworks and generally have a good time. Let's hope the fireworks is controlled by Java with on up-to-date kernel so that they can quickly get back to work

Re: [PATCH] mm: larger stack guard gap, between vmas

On 04/07/17 17:18, Linus Torvalds wrote: > Also, separately, John Haxby kind of implied that the LibreOffice > regression on i386 is already fixed by commit f4cb767d76cf ("mm: fix > new crash in unmapped_area_topdown()"). I'm not certain. We had two distinct problems that were avoided by Hugh's

Re: [PATCH] mm: larger stack guard gap, between vmas

On 04/07/17 17:18, Linus Torvalds wrote: > Also, separately, John Haxby kind of implied that the LibreOffice > regression on i386 is already fixed by commit f4cb767d76cf ("mm: fix > new crash in unmapped_area_topdown()"). I'm not certain. We had two distinct problems that were avoided by Hugh's

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 4, 2017 at 4:36 AM, Ben Hutchings wrote: > > That's what I was thinking of. Tried the following patch: > > Subject: mmap: Ignore VM_NONE mappings when checking for space to > expand the stack This looks sane to me. I'm going to ignore it in this thread, and

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 4, 2017 at 4:36 AM, Ben Hutchings wrote: > > That's what I was thinking of. Tried the following patch: > > Subject: mmap: Ignore VM_NONE mappings when checking for space to > expand the stack This looks sane to me. I'm going to ignore it in this thread, and assume that it gets

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 12:36:11PM +0100, Ben Hutchings wrote: > > If anywhing this would require to have a loop over all PROT_NONE > > mappings to not hit into other weird usecases. > > That's what I was thinking of. Tried the following patch: (...) > - next = vma->vm_next; > + /* > +

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 12:36:11PM +0100, Ben Hutchings wrote: > > If anywhing this would require to have a loop over all PROT_NONE > > mappings to not hit into other weird usecases. > > That's what I was thinking of. Tried the following patch: (...) > - next = vma->vm_next; > + /* > +

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 14:19:00, Ximin Luo wrote: [...] > I've written up an explanation of what happens in the Rust case here: > > https://github.com/rust-lang/rust/issues/43052 The most important part is https://github.com/rust-lang/rust/blob/master/src/libstd/sys/unix/thread.rs#L248 //

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 14:19:00, Ximin Luo wrote: [...] > I've written up an explanation of what happens in the Rust case here: > > https://github.com/rust-lang/rust/issues/43052 The most important part is https://github.com/rust-lang/rust/blob/master/src/libstd/sys/unix/thread.rs#L248 //

Re: [PATCH] mm: larger stack guard gap, between vmas

Michal Hocko: > On Tue 04-07-17 13:21:02, Ben Hutchings wrote: >> On Tue, 2017-07-04 at 14:00 +0200, Michal Hocko wrote: >>> On Tue 04-07-17 12:36:11, Ben Hutchings wrote: On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: >> On

Re: [PATCH] mm: larger stack guard gap, between vmas

Michal Hocko: > On Tue 04-07-17 13:21:02, Ben Hutchings wrote: >> On Tue, 2017-07-04 at 14:00 +0200, Michal Hocko wrote: >>> On Tue 04-07-17 12:36:11, Ben Hutchings wrote: On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: >> On

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 13:21:02, Ben Hutchings wrote: > On Tue, 2017-07-04 at 14:00 +0200, Michal Hocko wrote: > > On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > > > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > > > On Tue, Jul 04,

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 13:21:02, Ben Hutchings wrote: > On Tue, 2017-07-04 at 14:00 +0200, Michal Hocko wrote: > > On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > > > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > > > On Tue, Jul 04,

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On 04/07/17 00:55, Ben Hutchings wrote: > Unfortunately these regressions have not been completely fixed by > switching to Hugh's fix. > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > Apparently Rust maps its own guard page at the lower limit of the stack >

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On 04/07/17 00:55, Ben Hutchings wrote: > Unfortunately these regressions have not been completely fixed by > switching to Hugh's fix. > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > Apparently Rust maps its own guard page at the lower limit of the stack >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, 2017-07-04 at 14:00 +0200, Michal Hocko wrote: > On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > > > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, 2017-07-04 at 14:00 +0200, Michal Hocko wrote: > On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > > > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 13:59:59, Michal Hocko wrote: > On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > > [...] > > > > But

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 13:59:59, Michal Hocko wrote: > On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > > [...] > > > > But

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > [...] > > > But wouldn't this completely disable the check in case such a

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 12:36:11, Ben Hutchings wrote: > On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > [...] > > > But wouldn't this completely disable the check in case such a

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: [...] > > But wouldn't this completely disable the check in case such a guard page > > is installed, and possibly continue to

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, 2017-07-04 at 12:42 +0200, Michal Hocko wrote: > On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: [...] > > But wouldn't this completely disable the check in case such a guard page > > is installed, and possibly continue to

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 12:46:52, Michal Hocko wrote: [...] > Tested with the attached program. Err, attached now for real. -- Michal Hocko SUSE Labs #include #include #include #include #include #include #include #include #include #include #define PAGE_SIZE sysconf(_SC_PAGESIZE) #define

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 12:46:52, Michal Hocko wrote: [...] > Tested with the attached program. Err, attached now for real. -- Michal Hocko SUSE Labs #include #include #include #include #include #include #include #include #include #include #define PAGE_SIZE sysconf(_SC_PAGESIZE) #define

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 11:35:38, Michal Hocko wrote: > On Tue 04-07-17 10:41:22, Michal Hocko wrote: > > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings > > > wrote: > > > > > > > > Firstly, some Rust programs are crashing on

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 11:35:38, Michal Hocko wrote: > On Tue 04-07-17 10:41:22, Michal Hocko wrote: > > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings > > > wrote: > > > > > > > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > > On Tue 04-07-17 10:41:22, Michal Hocko wrote: > > > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings > > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 11:47:28, Willy Tarreau wrote: > On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > > On Tue 04-07-17 10:41:22, Michal Hocko wrote: > > > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings > > > > wrote: > > > > > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > On Tue 04-07-17 10:41:22, Michal Hocko wrote: > > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings > > > wrote: > > > > > > > > Firstly, some Rust programs are

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue, Jul 04, 2017 at 11:35:38AM +0200, Michal Hocko wrote: > On Tue 04-07-17 10:41:22, Michal Hocko wrote: > > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings > > > wrote: > > > > > > > > Firstly, some Rust programs are crashing on ppc64el

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 10:41:22, Michal Hocko wrote: > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > > > > > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > > > Apparently Rust maps its own

Re: [PATCH] mm: larger stack guard gap, between vmas

On Tue 04-07-17 10:41:22, Michal Hocko wrote: > On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > > > > > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > > > Apparently Rust maps its own guard page at the lower

Re: [PATCH] mm: larger stack guard gap, between vmas

On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > > > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > > Apparently Rust maps its own guard page at the lower limit of the stack > > (determined

Re: [PATCH] mm: larger stack guard gap, between vmas

On Mon 03-07-17 17:05:27, Linus Torvalds wrote: > On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > > > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > > Apparently Rust maps its own guard page at the lower limit of the stack > > (determined using

Re: [PATCH] mm: larger stack guard gap, between vmas

On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > On Wed, 2017-06-21 at 11:47 +0100, Ben Hutchings wrote: >> On Wed, 2017-06-21 at 11:24 +0200, Michal Hocko wrote: >> > On Wed 21-06-17 02:38:21, Ben Hutchings wrote: >> > > On Mon, 2017-06-19 at 16:23 +0200, Willy

Re: [PATCH] mm: larger stack guard gap, between vmas

On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > On Wed, 2017-06-21 at 11:47 +0100, Ben Hutchings wrote: >> On Wed, 2017-06-21 at 11:24 +0200, Michal Hocko wrote: >> > On Wed 21-06-17 02:38:21, Ben Hutchings wrote: >> > > On Mon, 2017-06-19 at 16:23 +0200, Willy Tarreau wrote: >> > > > On

Re: [PATCH] mm: larger stack guard gap, between vmas

On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > Apparently Rust maps its own guard page at the lower limit of the stack > (determined using pthread_getattr_np() and pthread_attr_getstack()). I

Re: [PATCH] mm: larger stack guard gap, between vmas

On Mon, Jul 3, 2017 at 4:55 PM, Ben Hutchings wrote: > > Firstly, some Rust programs are crashing on ppc64el with 64 KiB pages. > Apparently Rust maps its own guard page at the lower limit of the stack > (determined using pthread_getattr_np() and pthread_attr_getstack()). I > don't think this

Re: [PATCH] mm: larger stack guard gap, between vmas

On Wed, 2017-06-21 at 11:47 +0100, Ben Hutchings wrote: > On Wed, 2017-06-21 at 11:24 +0200, Michal Hocko wrote: > > On Wed 21-06-17 02:38:21, Ben Hutchings wrote: > > > On Mon, 2017-06-19 at 16:23 +0200, Willy Tarreau wrote: > > > > On Mon, Jun 19, 2017 at 08:44:24PM +0800, Linus Torvalds wrote:

Re: [PATCH] mm: larger stack guard gap, between vmas

On Wed, 2017-06-21 at 11:47 +0100, Ben Hutchings wrote: > On Wed, 2017-06-21 at 11:24 +0200, Michal Hocko wrote: > > On Wed 21-06-17 02:38:21, Ben Hutchings wrote: > > > On Mon, 2017-06-19 at 16:23 +0200, Willy Tarreau wrote: > > > > On Mon, Jun 19, 2017 at 08:44:24PM +0800, Linus Torvalds wrote:

Re: [PATCH] mm: larger stack guard gap, between vmas

On Sat, 2017-06-24 at 02:11 -0700, Hugh Dickins wrote: > On Thu, 22 Jun 2017, Hugh Dickins wrote: > > On Thu, 22 Jun 2017, Ben Hutchings wrote: > >  > > > Here's my attempt at a backport to 3.2.  This is only tested on > > > x86_64 and I think I should introduce local variables for > > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Sat, 2017-06-24 at 02:11 -0700, Hugh Dickins wrote: > On Thu, 22 Jun 2017, Hugh Dickins wrote: > > On Thu, 22 Jun 2017, Ben Hutchings wrote: > >  > > > Here's my attempt at a backport to 3.2.  This is only tested on > > > x86_64 and I think I should introduce local variables for > > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 22 Jun 2017, Hugh Dickins wrote: > On Thu, 22 Jun 2017, Ben Hutchings wrote: > > > Here's my attempt at a backport to 3.2. This is only tested on > > x86_64 and I think I should introduce local variables for > > vma_start_gap() in a few places. I had to cherry-pick commit > >

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 22 Jun 2017, Hugh Dickins wrote: > On Thu, 22 Jun 2017, Ben Hutchings wrote: > > > Here's my attempt at a backport to 3.2. This is only tested on > > x86_64 and I think I should introduce local variables for > > vma_start_gap() in a few places. I had to cherry-pick commit > >

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 8:10 PM, Andy Lutomirski wrote: > > Has anyone checked how grsecurity deals with this? I think they have > a large stack guard gap. Don't bother with grsecurity. Their approach has always been "we don't care if we break anything, we'll just claim it's

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 8:10 PM, Andy Lutomirski wrote: > > Has anyone checked how grsecurity deals with this? I think they have > a large stack guard gap. Don't bother with grsecurity. Their approach has always been "we don't care if we break anything, we'll just claim it's because we're

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 22 Jun 2017, Ben Hutchings wrote: > Here's my attempt at a backport to 3.2. This is only tested on > x86_64 and I think I should introduce local variables for > vma_start_gap() in a few places. I had to cherry-pick commit > 09884964335e "mm: do not grow the stack vma just because of an

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 22 Jun 2017, Ben Hutchings wrote: > Here's my attempt at a backport to 3.2. This is only tested on > x86_64 and I think I should introduce local variables for > vma_start_gap() in a few places. I had to cherry-pick commit > 09884964335e "mm: do not grow the stack vma just because of an

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 7:34 AM, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 03:14:00PM +0100, Ben Hutchings wrote: >> On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: >> > but I think Ben is currently looking >> > for feedback on the validity of his backport which was a

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 7:34 AM, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 03:14:00PM +0100, Ben Hutchings wrote: >> On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: >> > but I think Ben is currently looking >> > for feedback on the validity of his backport which was a difficult >> >

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On 22.06.2017 16:14, Ben Hutchings wrote: > On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: >>> -- Allow stack to grow up to address space limit >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ >>> commit/?id=bd726c90b6b8ce87602208701b208a208e6d5600 >> >> This one

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On 22.06.2017 16:14, Ben Hutchings wrote: > On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: >>> -- Allow stack to grow up to address space limit >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ >>> commit/?id=bd726c90b6b8ce87602208701b208a208e6d5600 >> >> This one

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 03:14:00PM +0100, Ben Hutchings wrote: > On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: > > but I think Ben is currently looking > > for feedback on the validity of his backport which was a difficult > > task. > > Right. Ben, barring more feedback, I think your

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 03:14:00PM +0100, Ben Hutchings wrote: > On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: > > but I think Ben is currently looking > > for feedback on the validity of his backport which was a difficult > > task. > > Right. Ben, barring more feedback, I think your

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: > Hi, > > On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote: > > Just a side note, but i think its worth mentioning to also have > > look at > > these fixup patches: > > > > > > -- mm: fix new crash in unmapped_area_topdown()

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote: > Hi, > > On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote: > > Just a side note, but i think its worth mentioning to also have > > look at > > these fixup patches: > > > > > > -- mm: fix new crash in unmapped_area_topdown()

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

Hi, On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote: > Just a side note, but i think its worth mentioning to also have look at > these fixup patches: > > > -- mm: fix new crash in unmapped_area_topdown() >

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

Hi, On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote: > Just a side note, but i think its worth mentioning to also have look at > these fixup patches: > > > -- mm: fix new crash in unmapped_area_topdown() >

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

binnqgCLRXfKN.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

binnqgCLRXfKN.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 03:10:34PM +0200, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 01:58:11PM +0100, Ben Hutchings wrote: > > On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > > > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > > > Here's my attempt at a backport

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 03:10:34PM +0200, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 01:58:11PM +0100, Ben Hutchings wrote: > > On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > > > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > > > Here's my attempt at a backport

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 01:58:11PM +0100, Ben Hutchings wrote: > On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > > Here's my attempt at a backport to 3.2.  This is only tested on > > > x86_64 and I think I should

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 01:58:11PM +0100, Ben Hutchings wrote: > On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > > Here's my attempt at a backport to 3.2.  This is only tested on > > > x86_64 and I think I should

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > Here's my attempt at a backport to 3.2.  This is only tested on > > x86_64 and I think I should introduce local variables for > > vma_start_gap() in a few places.  I had to

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote: > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > > Here's my attempt at a backport to 3.2.  This is only tested on > > x86_64 and I think I should introduce local variables for > > vma_start_gap() in a few places.  I had to

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > Here's my attempt at a backport to 3.2. This is only tested on > x86_64 and I think I should introduce local variables for > vma_start_gap() in a few places. I had to cherry-pick commit > 09884964335e "mm: do not grow the stack vma

Re: [PATCH] mm: larger stack guard gap, between vmas

On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote: > Here's my attempt at a backport to 3.2. This is only tested on > x86_64 and I think I should introduce local variables for > vma_start_gap() in a few places. I had to cherry-pick commit > 09884964335e "mm: do not grow the stack vma

Re: [PATCH] mm: larger stack guard gap, between vmas

Here's my attempt at a backport to 3.2. This is only tested on x86_64 and I think I should introduce local variables for vma_start_gap() in a few places. I had to cherry-pick commit 09884964335e "mm: do not grow the stack vma just because of an overrun on preceding vma" before this one (which

Re: [PATCH] mm: larger stack guard gap, between vmas

Here's my attempt at a backport to 3.2. This is only tested on x86_64 and I think I should introduce local variables for vma_start_gap() in a few places. I had to cherry-pick commit 09884964335e "mm: do not grow the stack vma just because of an overrun on preceding vma" before this one (which

<    1   2