Re: [PATCH] siox: fix possible buffer overflow in device_add_store

2018-03-02 Thread Uwe Kleine-König 
Hello Greg,

On Wed, Feb 14, 2018 at 06:00:21PM +0100, Uwe Kleine-König wrote:
> On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> > Width 20 given in format string is larger than destination
> > buffer 'type[20]', use %19s to prevent overflowing it.
> > 
> > Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> > Reported-by: David Binderman 
> > Signed-off-by: Gavin Schenk 
> Reviewed-by: Uwe Kleine-König 

is this patch still in your patch queue? The patch didn't appear in next
yet.

Best regards
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |

Re: [PATCH] siox: fix possible buffer overflow in device_add_store

2018-03-02 Thread Uwe Kleine-König 
Hello Greg,

On Wed, Feb 14, 2018 at 06:00:21PM +0100, Uwe Kleine-König wrote:
> On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> > Width 20 given in format string is larger than destination
> > buffer 'type[20]', use %19s to prevent overflowing it.
> > 
> > Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> > Reported-by: David Binderman 
> > Signed-off-by: Gavin Schenk 
> Reviewed-by: Uwe Kleine-König 

is this patch still in your patch queue? The patch didn't appear in next
yet.

Best regards
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |

Re: [PATCH] siox: fix possible buffer overflow in device_add_store

2018-02-14 Thread Uwe Kleine-König 
Hello,

On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> Width 20 given in format string is larger than destination
> buffer 'type[20]', use %19s to prevent overflowing it.
> 
> Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> Reported-by: David Binderman 
> Signed-off-by: Gavin Schenk 
Reviewed-by: Uwe Kleine-König 

Thanks
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |

Re: [PATCH] siox: fix possible buffer overflow in device_add_store

2018-02-14 Thread Uwe Kleine-König 
Hello,

On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote:
> Width 20 given in format string is larger than destination
> buffer 'type[20]', use %19s to prevent overflowing it.
> 
> Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX")
> Reported-by: David Binderman 
> Signed-off-by: Gavin Schenk 
Reviewed-by: Uwe Kleine-König 

Thanks
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |