Re: [PATCH] sysfs print name of undiscoverable attribute group as well

2016-09-19 Thread Johannes Thumshirn
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name?

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

2016-09-19 Thread Johannes Thumshirn
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name?

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

2016-09-18 Thread Johannes Thumshirn
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name?

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

2016-09-18 Thread Johannes Thumshirn
On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote: > On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > > Print the name of an undiscoverable attribute group as well, not just > > the pointer's address. > > Shouldn't we just drop the pointer address and use the name?

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

2016-09-18 Thread Greg KH
On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > Print the name of an undiscoverable attribute group as well, not just > the pointer's address. Shouldn't we just drop the pointer address and use the name? It's bad form to be printing kernel addresses to the syslog these days

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

2016-09-18 Thread Greg KH
On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote: > Print the name of an undiscoverable attribute group as well, not just > the pointer's address. Shouldn't we just drop the pointer address and use the name? It's bad form to be printing kernel addresses to the syslog these days