Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-12-01 Thread Boris Brezillon
On Fri, 2 Dec 2016 13:26:27 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2016-11-28 0:42 GMT+09:00 Boris Brezillon > : > >> + if (err_byte < ECC_SECTOR_SIZE) { > >> + struct

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-12-01 Thread Boris Brezillon
On Fri, 2 Dec 2016 13:26:27 +0900 Masahiro Yamada wrote: > Hi Boris, > > > 2016-11-28 0:42 GMT+09:00 Boris Brezillon > : > >> + if (err_byte < ECC_SECTOR_SIZE) { > >> + struct mtd_info *mtd = > >> +

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-12-01 Thread Masahiro Yamada
Hi Boris, 2016-11-28 0:42 GMT+09:00 Boris Brezillon : >> + if (err_byte < ECC_SECTOR_SIZE) { >> + struct mtd_info *mtd = >> + nand_to_mtd(>nand); >> +

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-12-01 Thread Masahiro Yamada
Hi Boris, 2016-11-28 0:42 GMT+09:00 Boris Brezillon : >> + if (err_byte < ECC_SECTOR_SIZE) { >> + struct mtd_info *mtd = >> + nand_to_mtd(>nand); >> + int offset; >> + >> +

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-11-27 Thread Boris Brezillon
On Sun, 27 Nov 2016 03:06:01 +0900 Masahiro Yamada wrote: > This function is unreadable due to the deep nesting. Note this > function does a job only when INTR_STATUS__ECC_ERR is set. > So, if the flag is not set, let it bail-out. > > Signed-off-by: Masahiro

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-11-27 Thread Boris Brezillon
On Sun, 27 Nov 2016 03:06:01 +0900 Masahiro Yamada wrote: > This function is unreadable due to the deep nesting. Note this > function does a job only when INTR_STATUS__ECC_ERR is set. > So, if the flag is not set, let it bail-out. > > Signed-off-by: Masahiro Yamada > --- > >

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-11-27 Thread Boris Brezillon
On Sun, 27 Nov 2016 03:06:01 +0900 Masahiro Yamada wrote: > This function is unreadable due to the deep nesting. Note this > function does a job only when INTR_STATUS__ECC_ERR is set. > So, if the flag is not set, let it bail-out. > > Signed-off-by: Masahiro

Re: [PATCH 15/39] mtd: nand: denali: improve readability of handle_ecc()

2016-11-27 Thread Boris Brezillon
On Sun, 27 Nov 2016 03:06:01 +0900 Masahiro Yamada wrote: > This function is unreadable due to the deep nesting. Note this > function does a job only when INTR_STATUS__ECC_ERR is set. > So, if the flag is not set, let it bail-out. > > Signed-off-by: Masahiro Yamada > --- > >