Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths

2018-04-10 Thread Halil Pasic
On 04/10/2018 10:55 AM, Cornelia Huck wrote: > On Tue, 10 Apr 2018 10:16:39 +0800 > Dong Jia Shi wrote: > >> Does the following effect make sense? >> >> # tracer: nop >> # >> # _-=> irqs-off >> # / _=> need-resched >> #

Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths

2018-04-10 Thread Cornelia Huck
On Tue, 10 Apr 2018 10:16:39 +0800 Dong Jia Shi wrote: > Does the following effect make sense? > > # tracer: nop > # > # _-=> irqs-off > # / _=> need-resched > #| / _---=> hardirq/softirq > #

Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths

2018-03-29 Thread Cornelia Huck
On Tue, 27 Mar 2018 17:27:54 +0200 Halil Pasic wrote: > On 03/27/2018 12:07 PM, Cornelia Huck wrote: > > On Tue, 27 Mar 2018 15:51:14 +0800 > > Dong Jia Shi wrote: > > > >> * Cornelia Huck [2018-03-26 15:59:02 +0200]: > >> > >> [...] > >> > @@ -131,6 +138,8 @@ static void fsm_io_reque

Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths

2018-03-27 Thread Halil Pasic
On 03/27/2018 12:07 PM, Cornelia Huck wrote: > On Tue, 27 Mar 2018 15:51:14 +0800 > Dong Jia Shi wrote: > >> * Cornelia Huck [2018-03-26 15:59:02 +0200]: >> >> [...] >> @@ -131,6 +138,8 @@ static void fsm_io_request(struct vfio_ccw_private *private, io_region-

Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths

2018-03-27 Thread Cornelia Huck
On Tue, 27 Mar 2018 15:51:14 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2018-03-26 15:59:02 +0200]: > > [...] > > > > @@ -131,6 +138,8 @@ static void fsm_io_request(struct vfio_ccw_private > > > *private, > > > > > > io_region->ret_code = cp_prefetch(&private->cp); > > >

Re: [PATCH 4/4] vfio: ccw: add traceponits for interesting error paths

2018-03-26 Thread Cornelia Huck
On Wed, 21 Mar 2018 03:08:22 +0100 Dong Jia Shi wrote: > From: Halil Pasic > > Add some tracepoints so we can inspect what is not working as is should. Tracepoints are certainly helpful (we can add more later). > > Signed-off-by: Halil Pasic > Signed-off-by: Dong Jia Shi > --- > drivers/s