Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

HI Kevin On 07/23/2018 10:12 PM, Kevin Hilman wrote: > Yixun Lan writes: > > [...] > >>> Second, we might like to convert eMMC driver to also use mmc-clkc model. >>> >>> IMO, this should be done as part of merging this series. Otherwise, we >>> have duplicated code for the same thing. >>

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

HI Kevin On 07/23/2018 10:12 PM, Kevin Hilman wrote: > Yixun Lan writes: > > [...] > >>> Second, we might like to convert eMMC driver to also use mmc-clkc model. >>> >>> IMO, this should be done as part of merging this series. Otherwise, we >>> have duplicated code for the same thing. >>

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

Yixun Lan writes: [...] >> >>> Second, we might like to convert eMMC driver to also use mmc-clkc model. >> >> IMO, this should be done as part of merging this series. Otherwise, we >> have duplicated code for the same thing. > > IMO, I'd leave this out of this series, since this patch series

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

Yixun Lan writes: [...] >> >>> Second, we might like to convert eMMC driver to also use mmc-clkc model. >> >> IMO, this should be done as part of merging this series. Otherwise, we >> have duplicated code for the same thing. > > IMO, I'd leave this out of this series, since this patch series

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

Hi Rob, Jerome, Kevin see my comments On 07/13/18 08:15, Rob Herring wrote: > On Thu, Jul 12, 2018 at 5:29 PM Yixun Lan wrote: >> >> HI Rob >> >> see my comments >> >> On 07/12/2018 10:17 PM, Rob Herring wrote: >>> On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: Hi Rob see

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

Hi Rob, Jerome, Kevin see my comments On 07/13/18 08:15, Rob Herring wrote: > On Thu, Jul 12, 2018 at 5:29 PM Yixun Lan wrote: >> >> HI Rob >> >> see my comments >> >> On 07/12/2018 10:17 PM, Rob Herring wrote: >>> On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: Hi Rob see

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

On Thu, Jul 12, 2018 at 5:29 PM Yixun Lan wrote: > > HI Rob > > see my comments > > On 07/12/2018 10:17 PM, Rob Herring wrote: > > On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: > >> > >> Hi Rob > >> > >> see my comments > >> > >> On 07/12/18 03:43, Rob Herring wrote: > >>> On Tue, Jul 10,

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

On Thu, Jul 12, 2018 at 5:29 PM Yixun Lan wrote: > > HI Rob > > see my comments > > On 07/12/2018 10:17 PM, Rob Herring wrote: > > On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: > >> > >> Hi Rob > >> > >> see my comments > >> > >> On 07/12/18 03:43, Rob Herring wrote: > >>> On Tue, Jul 10,

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

HI Rob see my comments On 07/12/2018 10:17 PM, Rob Herring wrote: > On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: >> >> Hi Rob >> >> see my comments >> >> On 07/12/18 03:43, Rob Herring wrote: >>> On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: Document the MMC sub clock

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

HI Rob see my comments On 07/12/2018 10:17 PM, Rob Herring wrote: > On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: >> >> Hi Rob >> >> see my comments >> >> On 07/12/18 03:43, Rob Herring wrote: >>> On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: Document the MMC sub clock

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: > > Hi Rob > > see my comments > > On 07/12/18 03:43, Rob Herring wrote: > > On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: > >> Document the MMC sub clock controller driver, the potential consumer > >> of this driver is MMC or NAND. >

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

On Wed, Jul 11, 2018 at 8:47 PM Yixun Lan wrote: > > Hi Rob > > see my comments > > On 07/12/18 03:43, Rob Herring wrote: > > On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: > >> Document the MMC sub clock controller driver, the potential consumer > >> of this driver is MMC or NAND. >

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

Hi Rob see my comments On 07/12/18 03:43, Rob Herring wrote: > On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. > > So you all have decided to properly model this now? > Yes, ;-)

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

Hi Rob see my comments On 07/12/18 03:43, Rob Herring wrote: > On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. > > So you all have decided to properly model this now? > Yes, ;-)

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: > Document the MMC sub clock controller driver, the potential consumer > of this driver is MMC or NAND. So you all have decided to properly model this now? > > Signed-off-by: Yixun Lan > --- > .../bindings/clock/amlogic,mmc-clkc.txt

Re: [PATCH v2 1/3] clk: meson: add DT documentation for emmc clock controller

On Tue, Jul 10, 2018 at 04:36:56PM +, Yixun Lan wrote: > Document the MMC sub clock controller driver, the potential consumer > of this driver is MMC or NAND. So you all have decided to properly model this now? > > Signed-off-by: Yixun Lan > --- > .../bindings/clock/amlogic,mmc-clkc.txt