Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Jin, Yao
Reference for macro fusion is the optimization guide, http://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-optimization-manual.html 2.3.2.1 — In Intel microarchitecture code name Nehalem: CMP, TEST. — In Intel microarchitecture code name Sandy Bridge: CMP,

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Jin, Yao
Reference for macro fusion is the optimization guide, http://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-optimization-manual.html 2.3.2.1 — In Intel microarchitecture code name Nehalem: CMP, TEST. — In Intel microarchitecture code name Sandy Bridge: CMP,

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 20, 2017 at 09:25:35AM +0800, Jin, Yao escreveu: > > > Ok, thanks for making this per-arch! Some comments: > > > > I think we should have this marked permanently, i.e. not just when we go > > to the jump line, something like this (testing here in a t450s > > broadwell, function

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 20, 2017 at 09:25:35AM +0800, Jin, Yao escreveu: > > > Ok, thanks for making this per-arch! Some comments: > > > > I think we should have this marked permanently, i.e. not just when we go > > to the jump line, something like this (testing here in a t450s > > broadwell, function

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Jin, Yao
Ok, thanks for making this per-arch! Some comments: I think we should have this marked permanently, i.e. not just when we go to the jump line, something like this (testing here in a t450s broadwell, function hc_find_func, /usr/lib64/liblzma.so.5.2.2): It is like this now, when we are not on

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Jin, Yao
Ok, thanks for making this per-arch! Some comments: I think we should have this marked permanently, i.e. not just when we go to the jump line, something like this (testing here in a t450s broadwell, function hc_find_func, /usr/lib64/liblzma.so.5.2.2): It is like this now, when we are not on

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 19, 2017 at 02:35:29PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu: > > Marker always there, not just when we have the cursor on top of one of > those lines remains to be coded. > > But you state: > > >

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 19, 2017 at 02:35:29PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu: > > Marker always there, not just when we have the cursor on top of one of > those lines remains to be coded. > > But you state: > > >

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu: > For marking the fused instructions clearly, This patch adds a > line before the first instruction of pair and joins it with the > arrow of the jump. > > For example, when je is selected in annotate view, the line > before cmpl is

Re: [PATCH v2 3/3] perf report: Implement visual marker for macro fusion in annotate

2017-06-19 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 19, 2017 at 10:55:58AM +0800, Jin Yao escreveu: > For marking the fused instructions clearly, This patch adds a > line before the first instruction of pair and joins it with the > arrow of the jump. > > For example, when je is selected in annotate view, the line > before cmpl is