Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-12-05 Thread Namjae Jeon
2012/12/5, Wanpeng Li : > Hi Namjae, > > How about set bdi->dirty_background_bytes according to bdi_thresh? I found > an issue during background flush process when review codes, if over > background > flush threshold, wb_check_background_flush will kick a work to current > per-bdi > flusher, but

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-12-05 Thread Namjae Jeon
2012/12/5, Wanpeng Li liw...@linux.vnet.ibm.com: Hi Namjae, How about set bdi-dirty_background_bytes according to bdi_thresh? I found an issue during background flush process when review codes, if over background flush threshold, wb_check_background_flush will kick a work to current per-bdi

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-11-19 Thread Namjae Jeon
2012/10/22, Dave Chinner : > On Fri, Oct 19, 2012 at 04:51:05PM +0900, Namjae Jeon wrote: >> Hi Dave. >> >> Test Procedure: >> >> 1) Local USB disk WRITE speed on NFS server is ~25 MB/s >> >> 2) Run WRITE test(create 1 GB file) on NFS Client with default >> writeback settings on NFS Server. By

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-11-19 Thread Namjae Jeon
2012/10/22, Dave Chinner da...@fromorbit.com: On Fri, Oct 19, 2012 at 04:51:05PM +0900, Namjae Jeon wrote: Hi Dave. Test Procedure: 1) Local USB disk WRITE speed on NFS server is ~25 MB/s 2) Run WRITE test(create 1 GB file) on NFS Client with default writeback settings on NFS Server. By

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-10-21 Thread Dave Chinner
On Fri, Oct 19, 2012 at 04:51:05PM +0900, Namjae Jeon wrote: > Hi Dave. > > Test Procedure: > > 1) Local USB disk WRITE speed on NFS server is ~25 MB/s > > 2) Run WRITE test(create 1 GB file) on NFS Client with default > writeback settings on NFS Server. By default > bdi->dirty_background_bytes

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-10-21 Thread Dave Chinner
On Fri, Oct 19, 2012 at 04:51:05PM +0900, Namjae Jeon wrote: Hi Dave. Test Procedure: 1) Local USB disk WRITE speed on NFS server is ~25 MB/s 2) Run WRITE test(create 1 GB file) on NFS Client with default writeback settings on NFS Server. By default bdi-dirty_background_bytes = 0, that

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-10-19 Thread Namjae Jeon
Hi Dave. Test Procedure: 1) Local USB disk WRITE speed on NFS server is ~25 MB/s 2) Run WRITE test(create 1 GB file) on NFS Client with default writeback settings on NFS Server. By default bdi->dirty_background_bytes = 0, that means no change in default writeback behaviour 3) Next we change

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-10-19 Thread Namjae Jeon
Hi Dave. Test Procedure: 1) Local USB disk WRITE speed on NFS server is ~25 MB/s 2) Run WRITE test(create 1 GB file) on NFS Client with default writeback settings on NFS Server. By default bdi-dirty_background_bytes = 0, that means no change in default writeback behaviour 3) Next we change

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Namjae Jeon
2012/9/27, Jan Kara : > On Thu 27-09-12 15:00:18, Namjae Jeon wrote: >> 2012/9/27, Jan Kara : >> > On Thu 27-09-12 00:56:02, Wu Fengguang wrote: >> >> On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: >> >> > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: >> >> > > On Sun, Sep 16, 2012 at

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Jan Kara
On Thu 27-09-12 15:00:18, Namjae Jeon wrote: > 2012/9/27, Jan Kara : > > On Thu 27-09-12 00:56:02, Wu Fengguang wrote: > >> On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: > >> > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: > >> > > On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Namjae Jeon
2012/9/27, Jan Kara : > On Thu 27-09-12 00:56:02, Wu Fengguang wrote: >> On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: >> > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: >> > > On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: >> > > > From: Namjae Jeon >> > > > >> > > >

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Namjae Jeon
2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 00:56:02, Wu Fengguang wrote: On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Jan Kara
On Thu 27-09-12 15:00:18, Namjae Jeon wrote: 2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 00:56:02, Wu Fengguang wrote: On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-27 Thread Namjae Jeon
2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 15:00:18, Namjae Jeon wrote: 2012/9/27, Jan Kara j...@suse.cz: On Thu 27-09-12 00:56:02, Wu Fengguang wrote: On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-26 Thread Jan Kara
On Thu 27-09-12 00:56:02, Wu Fengguang wrote: > On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: > > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: > > > On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: > > > > From: Namjae Jeon > > > > > > > > This patch is based on

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-26 Thread Fengguang Wu
On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: > > On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: > > > From: Namjae Jeon > > > > > > This patch is based on suggestion by Wu Fengguang: > > >

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-26 Thread Fengguang Wu
On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch is based on suggestion by Wu Fengguang:

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-26 Thread Jan Kara
On Thu 27-09-12 00:56:02, Wu Fengguang wrote: On Tue, Sep 25, 2012 at 12:23:06AM +0200, Jan Kara wrote: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch is based on

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Namjae Jeon : > 2012/9/25, Dave Chinner : >> On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: >>> [ CC FS and MM lists ] >>> >>> Patch looks good to me, however we need to be careful because it's >>> introducing a new interface. So it's desirable to get some acks from >>>

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Jan Kara : > On Thu 20-09-12 16:44:22, Wu Fengguang wrote: >> On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: >> > From: Namjae Jeon >> > >> > This patch is based on suggestion by Wu Fengguang: >> > https://lkml.org/lkml/2011/8/19/19 >> > >> > kernel has mechanism to do

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Dave Chinner : > On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: >> [ CC FS and MM lists ] >> >> Patch looks good to me, however we need to be careful because it's >> introducing a new interface. So it's desirable to get some acks from >> the FS/MM developers. >> >>

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Dave Chinner da...@fromorbit.com: On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: [ CC FS and MM lists ] Patch looks good to me, however we need to be careful because it's introducing a new interface. So it's desirable to get some acks from the FS/MM developers.

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Jan Kara j...@suse.cz: On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch is based on suggestion by Wu Fengguang: https://lkml.org/lkml/2011/8/19/19 kernel has

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-25 Thread Namjae Jeon
2012/9/25, Namjae Jeon linkinj...@gmail.com: 2012/9/25, Dave Chinner da...@fromorbit.com: On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: [ CC FS and MM lists ] Patch looks good to me, however we need to be careful because it's introducing a new interface. So it's desirable to

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-24 Thread Dave Chinner
On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: > [ CC FS and MM lists ] > > Patch looks good to me, however we need to be careful because it's > introducing a new interface. So it's desirable to get some acks from > the FS/MM developers. > > Thanks, > Fengguang > > On Sun, Sep

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-24 Thread Jan Kara
On Thu 20-09-12 16:44:22, Wu Fengguang wrote: > On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: > > From: Namjae Jeon > > > > This patch is based on suggestion by Wu Fengguang: > > https://lkml.org/lkml/2011/8/19/19 > > > > kernel has mechanism to do writeback as per dirty_ratio

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-24 Thread Jan Kara
On Thu 20-09-12 16:44:22, Wu Fengguang wrote: On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon namjae.j...@samsung.com This patch is based on suggestion by Wu Fengguang: https://lkml.org/lkml/2011/8/19/19 kernel has mechanism to do writeback as per

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-24 Thread Dave Chinner
On Thu, Sep 20, 2012 at 04:44:22PM +0800, Fengguang Wu wrote: [ CC FS and MM lists ] Patch looks good to me, however we need to be careful because it's introducing a new interface. So it's desirable to get some acks from the FS/MM developers. Thanks, Fengguang On Sun, Sep 16, 2012 at

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-20 Thread Fengguang Wu
[ CC FS and MM lists ] Patch looks good to me, however we need to be careful because it's introducing a new interface. So it's desirable to get some acks from the FS/MM developers. Thanks, Fengguang On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: > From: Namjae Jeon > > This

Re: [PATCH v3 1/2] writeback: add dirty_background_centisecs per bdi variable

2012-09-20 Thread Fengguang Wu
[ CC FS and MM lists ] Patch looks good to me, however we need to be careful because it's introducing a new interface. So it's desirable to get some acks from the FS/MM developers. Thanks, Fengguang On Sun, Sep 16, 2012 at 08:25:42AM -0400, Namjae Jeon wrote: From: Namjae Jeon