Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-08 Thread Alexandre Belloni
On 08/03/2018 at 11:53:09 +, Denis OSTERLAND wrote: > Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni: > > > > > + > > > > > + tv64.tv_sec = rtc_tm_to_time64(); > > > > Why not using an unsigned long long directly here? time64_t is not the > > > > correct type. > > > Do

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-08 Thread Alexandre Belloni
On 08/03/2018 at 11:53:09 +, Denis OSTERLAND wrote: > Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni: > > > > > + > > > > > + tv64.tv_sec = rtc_tm_to_time64(); > > > > Why not using an unsigned long long directly here? time64_t is not the > > > > correct type. > > > Do

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-08 Thread Denis OSTERLAND
Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni: > > > > + > > > > + tv64.tv_sec = rtc_tm_to_time64(); > > > Why not using an unsigned long long directly here? time64_t is not the > > > correct type. > > Do you mean timespec64 is not the correct type here? > > Then yes,

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-08 Thread Denis OSTERLAND
Am Mittwoch, den 07.03.2018, 11:47 +0100 schrieb Alexandre Belloni: > > > > + > > > > + tv64.tv_sec = rtc_tm_to_time64(); > > > Why not using an unsigned long long directly here? time64_t is not the > > > correct type. > > Do you mean timespec64 is not the correct type here? > > Then yes,

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Rob Herring
On Mon, Mar 05, 2018 at 10:43:52AM +, Denis OSTERLAND wrote: > From: Michael Grzeschik > > We add support for the ISL1219 chip that got an integrated tamper > detection function. This patch implements the feature by adding > an additional timestamp0 file to sysfs

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Rob Herring
On Mon, Mar 05, 2018 at 10:43:52AM +, Denis OSTERLAND wrote: > From: Michael Grzeschik > > We add support for the ISL1219 chip that got an integrated tamper > detection function. This patch implements the feature by adding > an additional timestamp0 file to sysfs device path. > This file

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Alexandre Belloni
On 07/03/2018 at 08:19:15 +, Denis OSTERLAND wrote: > > > +/* event section */ > > > +#define ISL1208_REG_SCT 0x14 > > > +#define ISL1208_REG_MNT 0x15 > > > +#define ISL1208_REG_HRT 0x16 > > > +#define ISL1208_REG_DTT 0x17 > > > +#define ISL1208_REG_MOT 0x18 > > > +#define ISL1208_REG_YRT 0x19

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Alexandre Belloni
On 07/03/2018 at 08:19:15 +, Denis OSTERLAND wrote: > > > +/* event section */ > > > +#define ISL1208_REG_SCT 0x14 > > > +#define ISL1208_REG_MNT 0x15 > > > +#define ISL1208_REG_HRT 0x16 > > > +#define ISL1208_REG_DTT 0x17 > > > +#define ISL1208_REG_MOT 0x18 > > > +#define ISL1208_REG_YRT 0x19

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Denis OSTERLAND
Am Dienstag, den 06.03.2018, 21:42 +0100 schrieb Alexandre Belloni: > On 05/03/2018 at 10:43:52 +, Denis OSTERLAND wrote: > > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > > new file mode 100644 > >

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-07 Thread Denis OSTERLAND
Am Dienstag, den 06.03.2018, 21:42 +0100 schrieb Alexandre Belloni: > On 05/03/2018 at 10:43:52 +, Denis OSTERLAND wrote: > > > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > > new file mode 100644 > >

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-06 Thread Alexandre Belloni
On 05/03/2018 at 10:43:52 +, Denis OSTERLAND wrote: > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > new file mode 100644 > index 000..7937c13 > --- /dev/null > +++

Re: [PATCH v3 3/4] rtc: isl1208: add support for isl1219 with tamper detection

2018-03-06 Thread Alexandre Belloni
On 05/03/2018 at 10:43:52 +, Denis OSTERLAND wrote: > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > b/Documentation/devicetree/bindings/rtc/isil,isl1219.txt > new file mode 100644 > index 000..7937c13 > --- /dev/null > +++