Re: [PATCH v4 0/9] drm/vc4: Turn the TXP into a CRTC
On Mon, Jul 06, 2020 at 05:51:29PM -0700, Eric Anholt wrote: > On Tue, Jun 30, 2020 at 1:25 AM Maxime Ripard wrote: > > > > Hi Eric, > > > > On Thu, Jun 11, 2020 at 03:36:45PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > This is another part of the rpi4 HDMI series that got promoted to a > > > series of its own to try to reduce the main one. > > > > > > This rework is needed since the bcm2711 used in the rpi4 has a more > > > complex routing in the HVS that doesn't allow to use a fairly simple > > > mapping like what was used before. > > > > > > Since that mapping affects both the pixelvalves and the TXP, turning the > > > TXP into a CRTC just like pixelvalves are allows to deal with the > > > mapping in the CRTC states, which turns out to be pretty convenient. > > > > > > Let me know what you think, > > > Maxime > > > > > > Changes from v3: > > > - Stripped the patches out of the main HDMI series > > > - Change the bind order of the HVS to avoid a compatible check > > > - Added Eric's tags > > > - Rebased on top of drm-misc-next > > > > > > Maxime Ripard (9): > > > drm/vc4: Reorder the bind order of the devices > > > drm/vc4: crtc: Move HVS setup code to the HVS driver > > > > Could you review those two patches? You haven't reviewed them yet and > > it's holding back the rest of the patches. > > LKML email workflow is the worst, the patches never came through to me > so I didn't see them until you linked me the patchwork. Patch 2, > commit message should say "We'll need the HVS to be bound before the > TXP", but other than that, r-b. I've fixed the commit message and applied, thanks (and sorry for the troubles). Maxime signature.asc Description: PGP signature
Re: [PATCH v4 0/9] drm/vc4: Turn the TXP into a CRTC
On Tue, Jun 30, 2020 at 1:25 AM Maxime Ripard wrote: > > Hi Eric, > > On Thu, Jun 11, 2020 at 03:36:45PM +0200, Maxime Ripard wrote: > > Hi, > > > > This is another part of the rpi4 HDMI series that got promoted to a > > series of its own to try to reduce the main one. > > > > This rework is needed since the bcm2711 used in the rpi4 has a more > > complex routing in the HVS that doesn't allow to use a fairly simple > > mapping like what was used before. > > > > Since that mapping affects both the pixelvalves and the TXP, turning the > > TXP into a CRTC just like pixelvalves are allows to deal with the > > mapping in the CRTC states, which turns out to be pretty convenient. > > > > Let me know what you think, > > Maxime > > > > Changes from v3: > > - Stripped the patches out of the main HDMI series > > - Change the bind order of the HVS to avoid a compatible check > > - Added Eric's tags > > - Rebased on top of drm-misc-next > > > > Maxime Ripard (9): > > drm/vc4: Reorder the bind order of the devices > > drm/vc4: crtc: Move HVS setup code to the HVS driver > > Could you review those two patches? You haven't reviewed them yet and > it's holding back the rest of the patches. LKML email workflow is the worst, the patches never came through to me so I didn't see them until you linked me the patchwork. Patch 2, commit message should say "We'll need the HVS to be bound before the TXP", but other than that, r-b.
Re: [PATCH v4 0/9] drm/vc4: Turn the TXP into a CRTC
Hi Eric, On Thu, Jun 11, 2020 at 03:36:45PM +0200, Maxime Ripard wrote: > Hi, > > This is another part of the rpi4 HDMI series that got promoted to a > series of its own to try to reduce the main one. > > This rework is needed since the bcm2711 used in the rpi4 has a more > complex routing in the HVS that doesn't allow to use a fairly simple > mapping like what was used before. > > Since that mapping affects both the pixelvalves and the TXP, turning the > TXP into a CRTC just like pixelvalves are allows to deal with the > mapping in the CRTC states, which turns out to be pretty convenient. > > Let me know what you think, > Maxime > > Changes from v3: > - Stripped the patches out of the main HDMI series > - Change the bind order of the HVS to avoid a compatible check > - Added Eric's tags > - Rebased on top of drm-misc-next > > Maxime Ripard (9): > drm/vc4: Reorder the bind order of the devices > drm/vc4: crtc: Move HVS setup code to the HVS driver Could you review those two patches? You haven't reviewed them yet and it's holding back the rest of the patches. Thanks! Maxime signature.asc Description: PGP signature