Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-22 Thread Arnd Bergmann
On Fri, May 22, 2020 at 9:44 AM Bartosz Golaszewski wrote: > śr., 20 maj 2020 o 23:23 Arnd Bergmann napisał(a): > > On Wed, May 20, 2020 at 7:35 PM Bartosz Golaszewski wrote: > > > śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > > My thinking was this: if I mask the relevant interrupt

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-22 Thread Bartosz Golaszewski
śr., 20 maj 2020 o 23:23 Arnd Bergmann napisał(a): > > On Wed, May 20, 2020 at 7:35 PM Bartosz Golaszewski wrote: > > śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > > > I just noticed how the naming of NET_MEDIATEK_MAC and NET_MEDIATEK_SOC > > > for two different drivers doing the same

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-20 Thread Arnd Bergmann
On Wed, May 20, 2020 at 7:35 PM Bartosz Golaszewski wrote: > śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > I just noticed how the naming of NET_MEDIATEK_MAC and NET_MEDIATEK_SOC > > for two different drivers doing the same thing is really confusing. > > > > Maybe someone can come up

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-20 Thread Bartosz Golaszewski
śr., 20 maj 2020 o 16:37 Arnd Bergmann napisał(a): > > On Wed, May 20, 2020 at 1:25 PM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > > family. For now we only support full-duplex. > > > >

Re: [PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-20 Thread Arnd Bergmann
On Wed, May 20, 2020 at 1:25 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC > family. For now we only support full-duplex. > > Signed-off-by: Bartosz Golaszewski Looks much better, thanks for addressing my