Re: [PATCH v4 1/2] ARM: dts: sun8i: add pinmux for UART1 at PG
Hi, On Fri, Sep 16, 2016 at 11:16:41PM +0800, Icenowy Zheng wrote: > The UART1 at PG (PG6, PG7, PG8, PG9) is, in the Allwinner's reference > tablet design of A23/33, used to connect to UART Bluetooth cards. > > Add the pinmux for it. > > Signed-off-by: Icenowy Zheng> --- > This patch is splited in v4. > > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > index 7e05e09..c340885 100644 > --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > @@ -361,6 +361,20 @@ > allwinner,pull = ; > }; > > + uart1_pins_a: uart1@0 { > + allwinner,pins = "PG6", "PG7"; > + allwinner,function = "uart1"; > + allwinner,drive = ; > + allwinner,pull = ; > + }; > + > + uart1_pins_cts_rts_a: uart1-cts-rts@0 { > + allwinner,pins = "PG8", "PG9"; > + allwinner,function = "uart1"; > + allwinner,drive = ; > + allwinner,pull = ; > + }; > + It turns out the allwinner,drive and allwinner,pull properties are optionnal. I removed them, and applied that patch. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
Re: [PATCH v4 1/2] ARM: dts: sun8i: add pinmux for UART1 at PG
Hi, On Fri, Sep 16, 2016 at 11:16:41PM +0800, Icenowy Zheng wrote: > The UART1 at PG (PG6, PG7, PG8, PG9) is, in the Allwinner's reference > tablet design of A23/33, used to connect to UART Bluetooth cards. > > Add the pinmux for it. > > Signed-off-by: Icenowy Zheng > --- > This patch is splited in v4. > > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > index 7e05e09..c340885 100644 > --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi > +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi > @@ -361,6 +361,20 @@ > allwinner,pull = ; > }; > > + uart1_pins_a: uart1@0 { > + allwinner,pins = "PG6", "PG7"; > + allwinner,function = "uart1"; > + allwinner,drive = ; > + allwinner,pull = ; > + }; > + > + uart1_pins_cts_rts_a: uart1-cts-rts@0 { > + allwinner,pins = "PG8", "PG9"; > + allwinner,function = "uart1"; > + allwinner,drive = ; > + allwinner,pull = ; > + }; > + It turns out the allwinner,drive and allwinner,pull properties are optionnal. I removed them, and applied that patch. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature