Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

On 06/30/20 19:44, Patrick Bellasi wrote: [...] > > I am sorry there's no written rule that says one should do it in a specific > > way. And AFAIK both way are implemented in the kernel. I appreciate your > > suggestion but as the person who did all the hard work, I think my > > preference > >

Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

On Tue, Jun 30, 2020 at 17:40:34 +0200, Qais Yousef wrote... > Hi Patrick > > On 06/30/20 16:55, Patrick Bellasi wrote: >> >> Hi Qais, >> sorry for commenting on v5 with a v6 already posted, but... >> ... I cannot keep up with your re-spinning rate ;) > > I classified that as a nit really

Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

Hi Patrick On 06/30/20 16:55, Patrick Bellasi wrote: > > Hi Qais, > sorry for commenting on v5 with a v6 already posted, but... > ... I cannot keep up with your re-spinning rate ;) I classified that as a nit really and doesn't affect correctness. We have different subjective view on what is

Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

Hi Qais, sorry for commenting on v5 with a v6 already posted, but... ... I cannot keep up with your re-spinning rate ;) More importantly, perhaps you missed to comment on one of my previous points. Will have a better look at the rest of v6 later today. Cheers, Patrick On Tue, Jun 30, 2020 at

Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

Hi Patrick On 06/30/20 10:11, Patrick Bellasi wrote: > > Hi Qais, > here are some more 2c from me... > > On Mon, Jun 29, 2020 at 18:26:33 +0200, Qais Yousef > wrote... > > [...] > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 235b2cae00a0..8d80d6091d86 100644 > > ---

Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

On 30/06/20 09:11, Patrick Bellasi wrote: > Hi Qais, > here are some more 2c from me... > > On Mon, Jun 29, 2020 at 18:26:33 +0200, Qais Yousef > wrote... > > [...] > >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 235b2cae00a0..8d80d6091d86 100644 >> ---

Re: [PATCH v5 2/2] sched/uclamp: Protect uclamp fast path code with static key

Hi Qais, here are some more 2c from me... On Mon, Jun 29, 2020 at 18:26:33 +0200, Qais Yousef wrote... [...] > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 235b2cae00a0..8d80d6091d86 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -794,6 +794,26 @@