Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Marcin Wojtas
Hi Jisheng, 2016-12-01 13:16 GMT+01:00 Jisheng Zhang : > On Thu, 1 Dec 2016 20:02:05 +0800 Jisheng Zhang wrote: > >> Hi Marcin, >> >> On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: >> >> > Hi Jisheng, >> > >> > Which baseline do you use? >> > >> > It took me really

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Marcin Wojtas
Hi Jisheng, 2016-12-01 13:16 GMT+01:00 Jisheng Zhang : > On Thu, 1 Dec 2016 20:02:05 +0800 Jisheng Zhang wrote: > >> Hi Marcin, >> >> On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: >> >> > Hi Jisheng, >> > >> > Which baseline do you use? >> > >> > It took me really lot of time to catch

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
On Thu, 1 Dec 2016 20:02:05 +0800 Jisheng Zhang wrote: > Hi Marcin, > > On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: > > > Hi Jisheng, > > > > Which baseline do you use? > > > > It took me really lot of time to catch why RX broke after rebase from > > LKv4.1 to LKv4.4. Between those

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
On Thu, 1 Dec 2016 20:02:05 +0800 Jisheng Zhang wrote: > Hi Marcin, > > On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: > > > Hi Jisheng, > > > > Which baseline do you use? > > > > It took me really lot of time to catch why RX broke after rebase from > > LKv4.1 to LKv4.4. Between those

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
Hi Marcin, On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: > Hi Jisheng, > > Which baseline do you use? > > It took me really lot of time to catch why RX broke after rebase from > LKv4.1 to LKv4.4. Between those two, in commit: > 97303480753e ("arm64: Increase the max granular size") >

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
Hi Marcin, On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: > Hi Jisheng, > > Which baseline do you use? > > It took me really lot of time to catch why RX broke after rebase from > LKv4.1 to LKv4.4. Between those two, in commit: > 97303480753e ("arm64: Increase the max granular size") >

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Marcin Wojtas
Hi Jisheng, Which baseline do you use? It took me really lot of time to catch why RX broke after rebase from LKv4.1 to LKv4.4. Between those two, in commit: 97303480753e ("arm64: Increase the max granular size") L1_CACHE_BYTES for all ARMv8 platforms was increased to 128B and so did NET_SKB_PAD.

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Marcin Wojtas
Hi Jisheng, Which baseline do you use? It took me really lot of time to catch why RX broke after rebase from LKv4.1 to LKv4.4. Between those two, in commit: 97303480753e ("arm64: Increase the max granular size") L1_CACHE_BYTES for all ARMv8 platforms was increased to 128B and so did NET_SKB_PAD.

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
On Thu, 1 Dec 2016 19:26:04 +0800 Jisheng Zhang wrote: > Hi Gregory, Marcin, > > On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > > > From: Marcin Wojtas > > > > Prepare the mvneta driver in order to be usable on the 64 bits platform > >

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
On Thu, 1 Dec 2016 19:26:04 +0800 Jisheng Zhang wrote: > Hi Gregory, Marcin, > > On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > > > From: Marcin Wojtas > > > > Prepare the mvneta driver in order to be usable on the 64 bits platform > > such as the Armada 3700. > > > >

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
Hi Gregory, Marcin, On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > From: Marcin Wojtas > > Prepare the mvneta driver in order to be usable on the 64 bits platform > such as the Armada 3700. > > [gregory.clem...@free-electrons.com]: this patch was extract from a

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

2016-12-01 Thread Jisheng Zhang
Hi Gregory, Marcin, On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > From: Marcin Wojtas > > Prepare the mvneta driver in order to be usable on the 64 bits platform > such as the Armada 3700. > > [gregory.clem...@free-electrons.com]: this patch was extract from a larger > one to