Re: linux-next: build failure after merge of the tty tree

2019-06-13 Thread Greg KH
On Thu, Jun 13, 2019 at 03:32:15PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/stm32-usart.c: In function 'stm32_serial_suspend': > drivers/tty/serial/stm32-usart.c:1298:2:

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Greg Kroah-Hartman
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 04, 2018 at

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Greg Kroah-Hartman
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Oct 04, 2018 at

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Steve Sakoman
Hi Greg, I sent the patch you requested to fix use of the "unused" struct member in samsung.c. If that looks OK to you I'll redo my "serial:serial_core: Allow use of CTS for PPS line discipline" patch. Thanks, Steve On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman wrote: > > On Thu, Oct 04,

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Steve Sakoman
Hi Greg, I sent the patch you requested to fix use of the "unused" struct member in samsung.c. If that looks OK to you I'll redo my "serial:serial_core: Allow use of CTS for PPS line discipline" patch. Thanks, Steve On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman wrote: > > On Thu, Oct 04,

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Steve Sakoman
On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman wrote: > We should just get rid of the "unused" fields entirely. They aren't > needed here as this is not a structure that anyone really cares about. > We can move things around a bit if the padding is an issue. > > I've reverted this patch

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Steve Sakoman
On Thu, Oct 4, 2018 at 7:00 AM Greg Kroah-Hartman wrote: > We should just get rid of the "unused" fields entirely. They aren't > needed here as this is not a structure that anyone really cares about. > We can move things around a bit if the padding is an issue. > > I've reverted this patch

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Greg Kroah-Hartman
On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote: > Interesting indeed. Who would have thought someone would be using the > "unused" padding variable! Ugh :( > How would folks prefer we fix this, in the referenced patch or by > eliminating the use of "unused" in samsung.c? We

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Greg Kroah-Hartman
On Thu, Oct 04, 2018 at 06:34:31AM -1000, Steve Sakoman wrote: > Interesting indeed. Who would have thought someone would be using the > "unused" padding variable! Ugh :( > How would folks prefer we fix this, in the referenced patch or by > eliminating the use of "unused" in samsung.c? We

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Steve Sakoman
Interesting indeed. Who would have thought someone would be using the "unused" padding variable! How would folks prefer we fix this, in the referenced patch or by eliminating the use of "unused" in samsung.c? Steve On Wed, Oct 3, 2018 at 7:19 PM Stephen Rothwell wrote: > > Hi all, > > After

Re: linux-next: build failure after merge of the tty tree

2018-10-04 Thread Steve Sakoman
Interesting indeed. Who would have thought someone would be using the "unused" padding variable! How would folks prefer we fix this, in the referenced patch or by eliminating the use of "unused" in samsung.c? Steve On Wed, Oct 3, 2018 at 7:19 PM Stephen Rothwell wrote: > > Hi all, > > After

Re: linux-next: build failure after merge of the tty tree

2018-09-17 Thread Andy Shevchenko
On Tue, Sep 11, 2018 at 11:43 AM Lee Jones wrote: > On Tue, 11 Sep 2018, Nicolas Ferre wrote: > > Actually it is due to the missing of as Stephen > > suggested. It is due to the patch ac3167257b9f ("headers: separate > > linux/mod_devicetable.h from linux/platform_device.h") merged in

Re: linux-next: build failure after merge of the tty tree

2018-09-17 Thread Andy Shevchenko
On Tue, Sep 11, 2018 at 11:43 AM Lee Jones wrote: > On Tue, 11 Sep 2018, Nicolas Ferre wrote: > > Actually it is due to the missing of as Stephen > > suggested. It is due to the patch ac3167257b9f ("headers: separate > > linux/mod_devicetable.h from linux/platform_device.h") merged in

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Lee Jones
On Tue, 11 Sep 2018, Nicolas Ferre wrote: > On 11/09/2018 at 10:25, Lee Jones wrote: > > On Tue, 11 Sep 2018, Stephen Rothwell wrote: > > > > > Hi Greg, > > > > > > After merging the tty tree, today's linux-next build (arm > > > multi_v7_defconfig) failed like this: > > > > > >

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Lee Jones
On Tue, 11 Sep 2018, Nicolas Ferre wrote: > On 11/09/2018 at 10:25, Lee Jones wrote: > > On Tue, 11 Sep 2018, Stephen Rothwell wrote: > > > > > Hi Greg, > > > > > > After merging the tty tree, today's linux-next build (arm > > > multi_v7_defconfig) failed like this: > > > > > >

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Nicolas Ferre
On 11/09/2018 at 10:25, Lee Jones wrote: On Tue, 11 Sep 2018, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Nicolas Ferre
On 11/09/2018 at 10:25, Lee Jones wrote: On Tue, 11 Sep 2018, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Lee Jones
On Tue, 11 Sep 2018, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type > 'struct of_device_id' > static const struct

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Lee Jones
On Tue, 11 Sep 2018, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type > 'struct of_device_id' > static const struct

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Greg KH
On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type > 'struct of_device_id' > static

Re: linux-next: build failure after merge of the tty tree

2018-09-11 Thread Greg KH
On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type > 'struct of_device_id' > static

Re: linux-next: build failure after merge of the tty tree

2017-12-18 Thread Greg KH
On Mon, Dec 18, 2017 at 10:02:08AM +0100, Greg KH wrote: > On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote: > > Hi Stephen, > > > > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell > > wrote: > > > After merging the tty tree, today's linux-next build

Re: linux-next: build failure after merge of the tty tree

2017-12-18 Thread Greg KH
On Mon, Dec 18, 2017 at 10:02:08AM +0100, Greg KH wrote: > On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote: > > Hi Stephen, > > > > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell > > wrote: > > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) >

Re: linux-next: build failure after merge of the tty tree

2017-12-18 Thread Greg KH
On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote: > Hi Stephen, > > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell > wrote: > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > >

Re: linux-next: build failure after merge of the tty tree

2017-12-18 Thread Greg KH
On Mon, Dec 18, 2017 at 09:52:50AM +0100, Geert Uytterhoeven wrote: > Hi Stephen, > > On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell > wrote: > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > > failed like this: > > > > .config:4300:warning: symbol value ''

Re: linux-next: build failure after merge of the tty tree

2017-12-18 Thread Geert Uytterhoeven
Hi Stephen, On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell wrote: > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS > * > * Restart config... > *

Re: linux-next: build failure after merge of the tty tree

2017-12-18 Thread Geert Uytterhoeven
Hi Stephen, On Mon, Dec 18, 2017 at 4:28 AM, Stephen Rothwell wrote: > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > .config:4300:warning: symbol value '' invalid for SERIAL_SH_SCI_NR_UARTS > * > * Restart config... > * > * > * Serial drivers

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Stephen Rothwell
Hi Greg, On Mon, 6 Feb 2017 16:18:22 +0100 Greg KH wrote: > > On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote: > > > > It didn't, but we happened to already have a fix queued up for 4.11. > > The fix is in your usb-next branch: > > > > commit

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Stephen Rothwell
Hi Greg, On Mon, 6 Feb 2017 16:18:22 +0100 Greg KH wrote: > > On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote: > > > > It didn't, but we happened to already have a fix queued up for 4.11. > > The fix is in your usb-next branch: > > > > commit

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Greg KH
On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote: > On Mon, Feb 6, 2017 at 2:51 AM, Greg KH wrote: > > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote: > >> Hi Greg, > >> > >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig) >

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Greg KH
On Mon, Feb 06, 2017 at 08:09:16AM -0600, Rob Herring wrote: > On Mon, Feb 6, 2017 at 2:51 AM, Greg KH wrote: > > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote: > >> Hi Greg, > >> > >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > >> failed like

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Rob Herring
On Mon, Feb 6, 2017 at 2:51 AM, Greg KH wrote: > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote: >> Hi Greg, >> >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig) >> failed like this: >> >> ERROR: "of_device_uevent_modalias"

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Rob Herring
On Mon, Feb 6, 2017 at 2:51 AM, Greg KH wrote: > On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote: >> Hi Greg, >> >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig) >> failed like this: >> >> ERROR: "of_device_uevent_modalias"

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Greg KH
On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined! > ERROR: "of_device_get_modalias"

Re: linux-next: build failure after merge of the tty tree

2017-02-06 Thread Greg KH
On Mon, Feb 06, 2017 at 03:22:09PM +1100, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko] undefined! > ERROR: "of_device_get_modalias"

Re: linux-next: build failure after merge of the tty tree

2016-09-29 Thread Greg KH
On Fri, Sep 30, 2016 at 01:54:37PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match': > drivers/tty/serial/amba-pl011.c:2346:44:

Re: linux-next: build failure after merge of the tty tree

2016-09-29 Thread Greg KH
On Fri, Sep 30, 2016 at 01:54:37PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/amba-pl011.c: In function 'pl011_console_match': > drivers/tty/serial/amba-pl011.c:2346:44:

Re: linux-next: build failure after merge of the tty tree

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 04:01:16PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > make[2]: *** No rule to make target 'arch/arm/boot/dts/imx6sl-fox-p1.dtb', > needed by '__build'. Stop. > >

Re: linux-next: build failure after merge of the tty tree

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 04:01:16PM +1000, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) failed like this: make[2]: *** No rule to make target 'arch/arm/boot/dts/imx6sl-fox-p1.dtb', needed by '__build'. Stop. Caused by

Re: linux-next: build failure after merge of the tty tree

2015-05-11 Thread Dave Martin
On Mon, May 11, 2015 at 06:16:26AM +0100, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) > failed like this: > > drivers/tty/serial/amba-pl011.c: In function 'pl011_startup': > drivers/tty/serial/amba-pl011.c:1582:5: error:

Re: linux-next: build failure after merge of the tty tree

2015-05-11 Thread Dave Martin
On Mon, May 11, 2015 at 06:16:26AM +0100, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/tty/serial/amba-pl011.c: In function 'pl011_startup': drivers/tty/serial/amba-pl011.c:1582:5: error: 'struct

Re: linux-next: build failure after merge of the tty tree

2014-09-30 Thread Stephen Rothwell
Hi Sebastian, On Tue, 30 Sep 2014 09:52:39 +0200 Sebastian Andrzej Siewior wrote: > > this should have been fixed by commit baeb7ef34952f ("tty: serial: 8250: > use 32bit variable for rpm_tx_active") in Greg's tty-next tree. Isn't > this the case or did you fetch the tty tree before Greg pushed

Re: linux-next: build failure after merge of the tty tree

2014-09-30 Thread Sebastian Andrzej Siewior
* Stephen Rothwell | 2014-09-30 17:39:00 [+1000]: >Hi Greg, Hi Stephen, >After merging the tty tree, today's linux-next build (powerpc >ppc64_defconfig) failed like this: > > >drivers/built-in.o: In function `.serial8250_stop_tx': >8250_core.c:(.text+0xda1f4): undefined reference to

Re: linux-next: build failure after merge of the tty tree

2014-09-30 Thread Sebastian Andrzej Siewior
* Stephen Rothwell | 2014-09-30 17:39:00 [+1000]: Hi Greg, Hi Stephen, After merging the tty tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: drivers/built-in.o: In function `.serial8250_stop_tx': 8250_core.c:(.text+0xda1f4): undefined reference to

Re: linux-next: build failure after merge of the tty tree

2014-09-30 Thread Stephen Rothwell
Hi Sebastian, On Tue, 30 Sep 2014 09:52:39 +0200 Sebastian Andrzej Siewior bige...@linutronix.de wrote: this should have been fixed by commit baeb7ef34952f (tty: serial: 8250: use 32bit variable for rpm_tx_active) in Greg's tty-next tree. Isn't this the case or did you fetch the tty tree

Re: linux-next: build failure after merge of the tty tree

2014-09-25 Thread Greg KH
On Thu, Sep 25, 2014 at 04:30:36PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) > failed like this: > > In file included from init/do_mounts.c:15:0: > include/linux/tty.h:267:9: error: width of 'unused' exceeds its

Re: linux-next: build failure after merge of the tty tree

2014-09-25 Thread Greg KH
On Thu, Sep 25, 2014 at 04:30:36PM +1000, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from init/do_mounts.c:15:0: include/linux/tty.h:267:9: error: width of 'unused' exceeds its type

Re: linux-next: build failure after merge of the tty tree

2014-05-29 Thread Barry Song
2014-05-29 20:18 GMT+08:00 Barry Song : > From: Stephen Rothwell [s...@canb.auug.org.au] > Sent: Thursday, May 29, 2014 15:28 > To: Greg KH > Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Qipan Li; Barry > Song > Subject: linux-next: build failure after merge of the tty tree > >

Re: linux-next: build failure after merge of the tty tree

2014-05-29 Thread Barry Song
2014-05-29 20:18 GMT+08:00 Barry Song barry.s...@csr.com: From: Stephen Rothwell [s...@canb.auug.org.au] Sent: Thursday, May 29, 2014 15:28 To: Greg KH Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Qipan Li; Barry Song Subject: linux-next: build failure after merge of the

Re: linux-next: build failure after merge of the tty tree

2013-10-31 Thread Greg KH
"LKML" , > > linux-ser...@vger.kernel.org > > Sent: Thursday, 31 October, 2013 6:35:23 AM > > Subject: Re: linux-next: build failure after merge of the tty tree > > > > On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell > > wrote: > > > Hi Greg,

Re: linux-next: build failure after merge of the tty tree

2013-10-31 Thread Philippe Proulx
- Original Message - > From: "Sedat Dilek" > To: "Stephen Rothwell" , "Philippe Proulx" > > Cc: "Greg KH" , "linux-next" , > "LKML" , > linux-ser...@vger.kernel.org > Sent: Thursday, 31 October, 201

Re: linux-next: build failure after merge of the tty tree

2013-10-31 Thread Sedat Dilek
On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe': > drivers/tty/serial/omap-serial.c:1724:22: error:

Re: linux-next: build failure after merge of the tty tree

2013-10-31 Thread Sedat Dilek
On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':

Re: linux-next: build failure after merge of the tty tree

2013-10-31 Thread Philippe Proulx
...@vger.kernel.org Sent: Thursday, 31 October, 2013 6:35:23 AM Subject: Re: linux-next: build failure after merge of the tty tree On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Greg, After merging the tty tree, today's linux-next build (arm multi_v7_defconfig

Re: linux-next: build failure after merge of the tty tree

2013-10-31 Thread Greg KH
...@vger.kernel.org, LKML linux-kernel@vger.kernel.org, linux-ser...@vger.kernel.org Sent: Thursday, 31 October, 2013 6:35:23 AM Subject: Re: linux-next: build failure after merge of the tty tree On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Greg

Re: linux-next: build failure after merge of the tty tree

2013-07-24 Thread Peter Hurley
On 07/24/2013 12:42 AM, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: Sorry. Patch coming. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: linux-next: build failure after merge of the tty tree

2013-07-24 Thread Peter Hurley
On 07/24/2013 12:42 AM, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: Sorry. Patch coming. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Stephen Rothwell
Hi Greg, On Thu, 21 Mar 2013 16:47:24 -0700 Greg KH wrote: > > On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote: > > > > Except, of course, commit 27b351c is not in your tty tree :-( > > Which was causing me lots of confusion :) > > I've merged it in there now, and reverted

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Greg KH
On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote: > Hi Greg, > > On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell > wrote: > > > > On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH wrote: > > > > > > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: > > > > Jiri Slaby

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Greg KH
On Fri, Mar 22, 2013 at 09:54:23AM +1100, Stephen Rothwell wrote: > Hi Greg, > > On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH wrote: > > > > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: > > > Jiri Slaby writes: > > > > > > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote: > > >

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Stephen Rothwell
Hi Greg, On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell wrote: > > On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH wrote: > > > > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: > > > Jiri Slaby writes: > > > > > > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote: > > > > > >

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Stephen Rothwell
Hi Greg, On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH wrote: > > On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: > > Jiri Slaby writes: > > > > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote: > > > > > > Asking Greg to revert should suffice. I commented on that patch, but in >

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Stephen Rothwell
Hi Greg, On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote: On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: Jiri Slaby writes: On 03/20/2013 03:42 PM, Bill Pemberton wrote: Asking Greg to revert should suffice. I commented on that patch, but in a

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Stephen Rothwell
Hi Greg, On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote: On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: Jiri Slaby writes: On 03/20/2013 03:42 PM, Bill Pemberton

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Greg KH
On Fri, Mar 22, 2013 at 09:54:23AM +1100, Stephen Rothwell wrote: Hi Greg, On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote: On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: Jiri Slaby writes: On 03/20/2013 03:42 PM, Bill Pemberton wrote:

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Greg KH
On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote: Hi Greg, On Fri, 22 Mar 2013 09:54:23 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: On Wed, 20 Mar 2013 17:16:28 -0700 Greg KH g...@kroah.com wrote: On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton

Re: linux-next: build failure after merge of the tty tree

2013-03-21 Thread Stephen Rothwell
Hi Greg, On Thu, 21 Mar 2013 16:47:24 -0700 Greg KH g...@kroah.com wrote: On Fri, Mar 22, 2013 at 10:28:08AM +1100, Stephen Rothwell wrote: Except, of course, commit 27b351c is not in your tty tree :-( Which was causing me lots of confusion :) I've merged it in there now, and

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Stephen Rothwell
Hi Greg, On Wed, 20 Mar 2013 14:12:11 +1100 Stephen Rothwell wrote: > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/net/caif/caif_serial.c: In function 'update_tty_status': > drivers/net/caif/caif_serial.c:94:11: error: 'struct

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Greg KH
On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: > Jiri Slaby writes: > > > > On 03/20/2013 03:42 PM, Bill Pemberton wrote: > > > Ok, for the unopened ports there *should* never be any actual data to > > > push so the push is really doing nothing anyhow in these cases. It's > > >

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
On 03/20/2013 03:42 PM, Bill Pemberton wrote: > Ok, for the unopened ports there *should* never be any actual data to > push so the push is really doing nothing anyhow in these cases. It's > coming from the device sending an initial change port command. > > Anyhow, so my patch adding more

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: > > On 03/20/2013 03:42 PM, Bill Pemberton wrote: > > Ok, for the unopened ports there *should* never be any actual data to > > push so the push is really doing nothing anyhow in these cases. It's > > coming from the device sending an initial change port command. > > > >

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: > > On 03/20/2013 01:51 PM, Bill Pemberton wrote: > > Jiri Slaby writes: > >> > >>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': > >>> drivers/usb/serial/quatech2.c:661:18: error: 'struct > >>> qt2_port_private' has no member named 'is_open' > >>>

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
On 03/20/2013 01:51 PM, Bill Pemberton wrote: > Jiri Slaby writes: >> >>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': >>> drivers/usb/serial/quatech2.c:661:18: error: 'struct >>> qt2_port_private' has no member named 'is_open' >>> drivers/usb/serial/quatech2.c:705:15:

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: > > > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': > > drivers/usb/serial/quatech2.c:661:18: error: 'struct > > qt2_port_private' has no member named 'is_open' > > drivers/usb/serial/quatech2.c:705:15: error: 'struct > > qt2_port_private' has no member

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
Hi, On 03/20/2013 04:12 AM, Stephen Rothwell wrote: > drivers/net/caif/caif_serial.c: In function 'update_tty_status': > drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' > has no member named 'warned' > > Caused by commit 6865ff222cca ("TTY: do not warn about setting > speed via

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
Hi, On 03/20/2013 04:12 AM, Stephen Rothwell wrote: drivers/net/caif/caif_serial.c: In function 'update_tty_status': drivers/net/caif/caif_serial.c:94:11: error: 'struct tty_struct' has no member named 'warned' Caused by commit 6865ff222cca (TTY: do not warn about setting speed via

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no member named 'is_open' drivers/usb/serial/quatech2.c:705:15: error: 'struct qt2_port_private' has no member named

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
On 03/20/2013 01:51 PM, Bill Pemberton wrote: Jiri Slaby writes: drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no member named 'is_open' drivers/usb/serial/quatech2.c:705:15: error: 'struct

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: On 03/20/2013 01:51 PM, Bill Pemberton wrote: Jiri Slaby writes: drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': drivers/usb/serial/quatech2.c:661:18: error: 'struct qt2_port_private' has no member named 'is_open'

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: On 03/20/2013 03:42 PM, Bill Pemberton wrote: Ok, for the unopened ports there *should* never be any actual data to push so the push is really doing nothing anyhow in these cases. It's coming from the device sending an initial change port command. Anyhow, so my

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Jiri Slaby
On 03/20/2013 03:42 PM, Bill Pemberton wrote: Ok, for the unopened ports there *should* never be any actual data to push so the push is really doing nothing anyhow in these cases. It's coming from the device sending an initial change port command. Anyhow, so my patch adding more is_open

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Greg KH
On Wed, Mar 20, 2013 at 11:15:11AM -0400, Bill Pemberton wrote: Jiri Slaby writes: On 03/20/2013 03:42 PM, Bill Pemberton wrote: Ok, for the unopened ports there *should* never be any actual data to push so the push is really doing nothing anyhow in these cases. It's coming from

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Stephen Rothwell
Hi Greg, On Wed, 20 Mar 2013 14:12:11 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/caif/caif_serial.c: In function 'update_tty_status': drivers/net/caif/caif_serial.c:94:11:

Re: linux-next: build failure after merge of the tty tree

2012-10-23 Thread Greg KH
On Wed, Oct 24, 2012 at 01:28:27PM +1100, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input': > drivers/staging/dgrp/dgrp_net_ops.c:216:27: error:

Re: linux-next: build failure after merge of the tty tree

2012-10-23 Thread Greg KH
On Wed, Oct 24, 2012 at 01:28:27PM +1100, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input': drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct

Re: linux-next: build failure after merge of the tty tree

2012-09-06 Thread Alan Cox
On Thu, 6 Sep 2012 15:10:14 +1000 Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > In file included from drivers/tty/serial/sccnxp.c:20:0: > include/linux/serial_core.h: In function 'uart_handle_break': >

Re: linux-next: build failure after merge of the tty tree

2012-09-06 Thread Alan Cox
On Thu, 6 Sep 2012 15:10:14 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Greg, After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/tty/serial/sccnxp.c:20:0: include/linux/serial_core.h: In function

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Alan Cox
On Thu, 26 Jul 2012 08:51:27 +1000 Stephen Rothwell wrote: > Hi Greg, Alan, > > [Sorry, Alan, I forgot to cc you the first time around.] > > On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell > wrote: > > > > After merging the tty tree, today's linux-next build (x86_64 > > allmodconfig)

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Stephen Rothwell
Hi Greg, Alan, [Sorry, Alan, I forgot to cc you the first time around.] On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell wrote: > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/staging/serqt_usb2/serqt_usb2.c: In function

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Stephen Rothwell
Hi Greg, Alan, On Fri, 20 Jul 2012 13:28:40 +1000 Stephen Rothwell wrote: > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios': >

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Greg KH
On Fri, Jul 20, 2012 at 01:28:40PM +1000, Stephen Rothwell wrote: > Hi Greg, > > After merging the tty tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios': >

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Greg KH
On Fri, Jul 20, 2012 at 01:28:40PM +1000, Stephen Rothwell wrote: Hi Greg, After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Stephen Rothwell
Hi Greg, Alan, On Fri, 20 Jul 2012 13:28:40 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/ipack/devices/ipoctal.c: In function 'ipoctal_set_termios':

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Stephen Rothwell
Hi Greg, Alan, [Sorry, Alan, I forgot to cc you the first time around.] On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/serqt_usb2/serqt_usb2.c: In

Re: linux-next: build failure after merge of the tty tree

2012-07-25 Thread Alan Cox
On Thu, 26 Jul 2012 08:51:27 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Hi Greg, Alan, [Sorry, Alan, I forgot to cc you the first time around.] On Fri, 20 Jul 2012 13:33:49 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the tty tree, today's linux-next

Re: linux-next: build failure after merge of the tty tree

2012-07-20 Thread Geert Uytterhoeven
Hi Alan, On Fri, Jul 20, 2012 at 10:55 PM, Alan Cox wrote: >> Today's build failed because there's a new user in the MIPS tree: >> arch/mips/cavium-octeon/serial.c >> >> http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/ > > The version in the tree I have registers a platform device rather

Re: linux-next: build failure after merge of the tty tree

2012-07-20 Thread Alan Cox
> Today's build failed because there's a new user in the MIPS tree: > arch/mips/cavium-octeon/serial.c > > http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/ The version in the tree I have registers a platform device rather than calling into 8250 directly. That appears to be rather better

Re: linux-next: build failure after merge of the tty tree

2012-07-20 Thread Geert Uytterhoeven
Hi Alan, David, On Fri, Jul 13, 2012 at 1:10 PM, Alan Cox wrote: > On Fri, 13 Jul 2012 14:13:45 +1000 > Stephen Rothwell wrote: >> After merging the tty tree, today's linux-next build (x86_64 allmodconfig) >> failed like this: >> >> drivers/char/mwave/mwavedd.c: In function

Re: linux-next: build failure after merge of the tty tree

2012-07-20 Thread Geert Uytterhoeven
Hi Alan, David, On Fri, Jul 13, 2012 at 1:10 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Fri, 13 Jul 2012 14:13:45 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the tty tree, today's linux-next build (x86_64 allmodconfig) failed like this:

Re: linux-next: build failure after merge of the tty tree

2012-07-20 Thread Alan Cox
Today's build failed because there's a new user in the MIPS tree: arch/mips/cavium-octeon/serial.c http://kisskb.ellerman.id.au/kisskb/buildresult/6739341/ The version in the tree I have registers a platform device rather than calling into 8250 directly. That appears to be rather better

  1   2   >