Re: linux-next: Fixes tag needs some work in the clockevents tree

2019-06-16 Thread Dmitry Osipenko 
16.06.2019 17:18, Daniel Lezcano пишет:
> On 16/06/2019 16:08, Dmitry Osipenko wrote:
>> 16.06.2019 16:24, Stephen Rothwell пишет:
>>> Hi Daniel,
>>>
>>> [Sorry for the slow response.]
>>>
>>> On Thu, 13 Jun 2019 08:52:21 +0200 Daniel Lezcano 
>>>  wrote:

 actually it returns:

 git log -1 --format='Fixes: %h ("%s")' 3be2a85a0b61

 Fixes: 3be2a85a0b61 ("clocksource/drivers/tegra: Support per-CPU timers on 
 all Tegra's")
>>>
>>> Indeed.
>>>
 Is it ok to shorten the subject?
>>>
>>> I figure it is easier to just use the "git log" result and to give
>>> anyone (or any script) the wants to use the Fixes tag as much
>>> information as possible.
>>>
>>
>> Daniel, I'd also recommend to shorten the common subsys prefix in general to 
>> something
>> like "clocksource: tegra:".
> 
> Actually I can't, I have been asked by the tip team to follow this format.

Oh well.

Also please feel free to fixup the offending commit's tag if you think that it's
necessary. I'll keep a full subject line in the future patches to a void that 
situation.

Re: linux-next: Fixes tag needs some work in the clockevents tree

2019-06-16 Thread Daniel Lezcano 
On 16/06/2019 16:08, Dmitry Osipenko wrote:
> 16.06.2019 16:24, Stephen Rothwell пишет:
>> Hi Daniel,
>>
>> [Sorry for the slow response.]
>>
>> On Thu, 13 Jun 2019 08:52:21 +0200 Daniel Lezcano 
>>  wrote:
>>>
>>> actually it returns:
>>>
>>> git log -1 --format='Fixes: %h ("%s")' 3be2a85a0b61
>>>
>>> Fixes: 3be2a85a0b61 ("clocksource/drivers/tegra: Support per-CPU timers on 
>>> all Tegra's")
>>
>> Indeed.
>>
>>> Is it ok to shorten the subject?
>>
>> I figure it is easier to just use the "git log" result and to give
>> anyone (or any script) the wants to use the Fixes tag as much
>> information as possible.
>>
> 
> Daniel, I'd also recommend to shorten the common subsys prefix in general to 
> something
> like "clocksource: tegra:".

Actually I can't, I have been asked by the tip team to follow this format.


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: linux-next: Fixes tag needs some work in the clockevents tree

2019-06-16 Thread Dmitry Osipenko 
16.06.2019 16:24, Stephen Rothwell пишет:
> Hi Daniel,
> 
> [Sorry for the slow response.]
> 
> On Thu, 13 Jun 2019 08:52:21 +0200 Daniel Lezcano  
> wrote:
>>
>> actually it returns:
>>
>> git log -1 --format='Fixes: %h ("%s")' 3be2a85a0b61
>>
>> Fixes: 3be2a85a0b61 ("clocksource/drivers/tegra: Support per-CPU timers on 
>> all Tegra's")
> 
> Indeed.
> 
>> Is it ok to shorten the subject?
> 
> I figure it is easier to just use the "git log" result and to give
> anyone (or any script) the wants to use the Fixes tag as much
> information as possible.
> 

Daniel, I'd also recommend to shorten the common subsys prefix in general to 
something
like "clocksource: tegra:".

Re: linux-next: Fixes tag needs some work in the clockevents tree

2019-06-16 Thread Stephen Rothwell 
Hi Daniel,

[Sorry for the slow response.]

On Thu, 13 Jun 2019 08:52:21 +0200 Daniel Lezcano  
wrote:
>
> actually it returns:
> 
> git log -1 --format='Fixes: %h ("%s")' 3be2a85a0b61
> 
> Fixes: 3be2a85a0b61 ("clocksource/drivers/tegra: Support per-CPU timers on 
> all Tegra's")

Indeed.

> Is it ok to shorten the subject?

I figure it is easier to just use the "git log" result and to give
anyone (or any script) the wants to use the Fixes tag as much
information as possible.

-- 
Cheers,
Stephen Rothwell


pgpf7LDWD5Cr1.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the clockevents tree

2019-06-13 Thread Stephen Rothwell 
Hi all,

In commit

  98793726ab3f ("clocksource/drivers/tegra: Restore timer rate on Tegra210")

Fixes tag

  Fixes: 3be2a85a0b61 ("Support per-CPU timers on all Tegra's")

has these problem(s):

  - Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell


pgpR1MVc4kbbf.pgp
Description: OpenPGP digital signature

Re: linux-next: Fixes tag needs some work in the clockevents tree

2019-06-13 Thread Daniel Lezcano 
On 13/06/2019 01:07, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   98793726ab3f ("clocksource/drivers/tegra: Restore timer rate on Tegra210")
> 
> Fixes tag
> 
>   Fixes: 3be2a85a0b61 ("Support per-CPU timers on all Tegra's")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
> Just use
>   git log -1 --format='Fixes: %h ("%s")'

Hi Stephen,

actually it returns:

git log -1 --format='Fixes: %h ("%s")' 3be2a85a0b61

Fixes: 3be2a85a0b61 ("clocksource/drivers/tegra: Support per-CPU timers
on all Tegra's")

Is it ok to shorten the subject?


-- 
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog