linux-next: Fixes tag needs some work in the spi tree

2021-04-11 Thread Stephen Rothwell 
Hi all,

In commit

  e980048263ba ("spi: orion: set devdata properly as it is being used later")

Fixes tag

  Fixes: 0e6521f13c2 ("spi: orion: Use device_get_match_data() helper")

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing to fix, but this can be avoided in future
commits by setting core.abbrev to 12 (or more) or (for git v2.11 or later)
just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell


pgpCn3AX9grnz.pgp
Description: OpenPGP digital signature

Re: linux-next: Fixes tag needs some work in the spi tree

2021-01-11 Thread Mark Brown 
On Tue, Jan 12, 2021 at 02:28:12AM +0530, Pratyush Yadav wrote:

> I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
> now?

Not without rebasing which I generally avoid.


signature.asc
Description: PGP signature

Re: linux-next: Fixes tag needs some work in the spi tree

2021-01-11 Thread Pratyush Yadav 
+Cc checkpatch.pl maintainers.

On 12/01/21 07:36AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")
> 
> Fixes tag
> 
>   Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct 
> reads")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
> Just use
>   git log -1 --format='Fixes: %h ("%s")'
> 
> Did yu mean
> 
> Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")
> 
> or
> 
> Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct 
> reads")

I meant this one. My mistake. Copied the wrong hash. Any way to fix this 
now?

This check should probably be added in checkpatch.pl so mistakes like 
this can be avoided in the future.

-- 
Regards,
Pratyush Yadav
Texas Instruments India

linux-next: Fixes tag needs some work in the spi tree

2021-01-11 Thread Stephen Rothwell 
Hi all,

In commit

  2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")

Fixes tag

  Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct 
reads")

has these problem(s):

  - Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Did yu mean

Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")

or

Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct 
reads")

-- 
Cheers,
Stephen Rothwell


pgp1UaC7bBnIn.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the spi tree

2019-04-01 Thread Stephen Rothwell 
Hi Mark,

In commit

  fc9ba6e3e28a ("spi: tegra114: use packed mode for 32 bits per word")

Fixes tag

  Fixes: Use packed mode for 32 bits per word transfers to increase

has these problem(s):

  - No SHA1 recognised

-- 
Cheers,
Stephen Rothwell


pgpHxA2nbfwQH.pgp
Description: OpenPGP digital signature