Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Maxime Ripard]

On Tue, Apr 06, 2021 at 11:44:27PM +0200, Arnd Bergmann wrote:
> On Tue, Apr 6, 2021 at 12:11 AM Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > On Tue, 6 Apr 2021 08:11:00 +1000 Stephen Rothwell  
> > wrote:
> > >
> > > Hi all,
> > >
> > > Commit
> > >
> > >   3b493ac0ac04 ("arm64: dts: allwinner: h6: Switch to macros for RSB 
> > > clock/reset indices")
> > >
> > > is missing a Signed-off-by from its committer.
> >
> > Sorry, that commit is in the arm-soc-fixes tree.
> 
> Thanks for the report, I've temporarily removed the sunx-fixes branch merge
> from the arm/fixes branch and will send the pull request without it.
> 
> Maxime, can you fix it up and resend the pull request?
> Feel free to add any other fixes that have come up since then.

I just did. Is there a way to prevent this from happening when one
rebase a branch that was partially committed by someone else?

git rebase --signoff doesn't seem to detect if there's already a SoB, so
it might produce duplicates which isn't great either.

Maxime


signature.asc
Description: PGP signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Tue, Apr 6, 2021 at 12:11 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> On Tue, 6 Apr 2021 08:11:00 +1000 Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > Commit
> >
> >   3b493ac0ac04 ("arm64: dts: allwinner: h6: Switch to macros for RSB 
> > clock/reset indices")
> >
> > is missing a Signed-off-by from its committer.
>
> Sorry, that commit is in the arm-soc-fixes tree.

Thanks for the report, I've temporarily removed the sunx-fixes branch merge
from the arm/fixes branch and will send the pull request without it.

Maxime, can you fix it up and resend the pull request?
Feel free to add any other fixes that have come up since then.

   Arnd

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

On Tue, 6 Apr 2021 08:11:00 +1000 Stephen Rothwell  
wrote:
>
> Hi all,
> 
> Commit
> 
>   3b493ac0ac04 ("arm64: dts: allwinner: h6: Switch to macros for RSB 
> clock/reset indices")
> 
> is missing a Signed-off-by from its committer.

Sorry, that commit is in the arm-soc-fixes tree.

-- 
Cheers,
Stephen Rothwell


pgp3RvLEVftCx.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  3b493ac0ac04 ("arm64: dts: allwinner: h6: Switch to macros for RSB 
clock/reset indices")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgp4HbSMcZlhk.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  70ba3b1adbf5 ("arm64: defconfig: Enable RT5659")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpMjyQjBZ9rf.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Tue, Feb 2, 2021 at 9:04 PM Stephen Rothwell  wrote:
> On Wed, 3 Feb 2021 06:57:54 +1100 Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > Commit
> >
> >   4e238bfd83f3 ("ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode")
> >
> > is missing a Signed-off-by from its committer.
>
> This is actually in the arm-soc-fixes tree, sorry.

Ok, thanks for letting me know. I've removed it from the arm-soc-fixes tree
now (it's still in for-next for the moment, but I won't send that to Linus).

Maxime, can you resend the bugfix as a patch or pull request with your
signoff added?

Arnd

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

On Wed, 3 Feb 2021 06:57:54 +1100 Stephen Rothwell  
wrote:
>
> Hi all,
> 
> Commit
> 
>   4e238bfd83f3 ("ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode")
> 
> is missing a Signed-off-by from its committer.

This is actually in the arm-soc-fixes tree, sorry.

-- 
Cheers,
Stephen Rothwell


pgp26UbJaFFlo.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  4e238bfd83f3 ("ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpKtSiQBkpMj.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Wed, Dec 9, 2020 at 10:35 PM Stephen Rothwell  wrote:
>
>   2305d20f251d ("firmware: xilinx: Mark pm_api_features_map with static 
> keyword")
>
> is missing a Signed-off-by from its committer.

Thanks for pointing it out. Just when I apply two last fixes before
sending out the
fixes pull request to Linus, I make a mess of the trivial fix...

   Arnd

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  2305d20f251d ("firmware: xilinx: Mark pm_api_features_map with static 
keyword")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpoUowBVuoOV.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  ab7eff24a1e9 ("dt-bindings: net: dsa: b53: Add YAML bindings")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpxeYGQ4ubCL.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Fri, May 22, 2020 at 3:28 AM Masahiro Yamada  wrote:
>
> On Fri, May 22, 2020 at 7:24 AM Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > Commit
> >
> >   82ab9b6705bd ("dt-bindings: arm: Add Akebi96 board support")
> >
> > is missing a Signed-off-by from its committer.
>
>
> Sorry, I missed to add it.
>
> Olof, Arnd,
> If you want me to resend the pull-request,
> please let me know.
> (but, probably it is too late, I guess...)

Yes, I think it's too late, I did a lot of merges yesterday and would
rather not rebase them.

   Arnd

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Masahiro Yamada]

On Fri, May 22, 2020 at 7:24 AM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   82ab9b6705bd ("dt-bindings: arm: Add Akebi96 board support")
>
> is missing a Signed-off-by from its committer.


Sorry, I missed to add it.

Olof, Arnd,
If you want me to resend the pull-request,
please let me know.
(but, probably it is too late, I guess...)


-- 
Best Regards
Masahiro Yamada

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  82ab9b6705bd ("dt-bindings: arm: Add Akebi96 board support")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpqQ_b7o7pel.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Florian Fainelli]

On 6/25/19 3:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   cbbe88333062 ("ARM: bcm283x: Enable DMA support for SPI controller")
> 
> is missing a Signed-off-by from its committer.

Yes, had to rebase and missed adding my SoB back onto the commit. Olof
already warned me a bout this.
-- 
Florian

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  cbbe88333062 ("ARM: bcm283x: Enable DMA support for SPI controller")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgp5uA69u_m1c.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Olof Johansson]

Looks like I accidentally rebased the fixes branch locally after
merging that patch in. Will fixup, thanks for reporting.


-Olof

On Fri, Nov 2, 2018 at 8:58 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   cda58c80fe27 ("ARM: OMAP1: ams-delta: Fix impossible .irq < 0")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Olof Johansson]

Looks like I accidentally rebased the fixes branch locally after
merging that patch in. Will fixup, thanks for reporting.


-Olof

On Fri, Nov 2, 2018 at 8:58 PM Stephen Rothwell  wrote:
>
> Hi all,
>
> Commit
>
>   cda58c80fe27 ("ARM: OMAP1: ams-delta: Fix impossible .irq < 0")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  cda58c80fe27 ("ARM: OMAP1: ams-delta: Fix impossible .irq < 0")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpe0FrniLfHl.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  cda58c80fe27 ("ARM: OMAP1: ams-delta: Fix impossible .irq < 0")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpe0FrniLfHl.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi Alexandre,

On Tue, 15 May 2018 09:15:23 +0200 Alexandre Torgue  
wrote:
>
> On 05/14/2018 11:22 PM, Stephen Rothwell wrote:
> > 
> > Commit
> > 
> >949a0c0dec85 ("ARM: dts: stm32: add USB Host (USBH) support to 
> > stm32mp157c")
> > 
> > is missing a Signed-off-by from its committer.
> 
> My fault, I forgot it when I applied patch on my branch. Do we need an 
> update or it is just a reminder?

Some people rebase their tree to fix these up, some just take it as a
learning experience :-)

-- 
Cheers,
Stephen Rothwell


pgpA6BoV8DAYk.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi Alexandre,

On Tue, 15 May 2018 09:15:23 +0200 Alexandre Torgue  
wrote:
>
> On 05/14/2018 11:22 PM, Stephen Rothwell wrote:
> > 
> > Commit
> > 
> >949a0c0dec85 ("ARM: dts: stm32: add USB Host (USBH) support to 
> > stm32mp157c")
> > 
> > is missing a Signed-off-by from its committer.
> 
> My fault, I forgot it when I applied patch on my branch. Do we need an 
> update or it is just a reminder?

Some people rebase their tree to fix these up, some just take it as a
learning experience :-)

-- 
Cheers,
Stephen Rothwell


pgpA6BoV8DAYk.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Torgue]

On 05/14/2018 11:22 PM, Stephen Rothwell wrote:

Hi all,

Commit

   949a0c0dec85 ("ARM: dts: stm32: add USB Host (USBH) support to stm32mp157c")

is missing a Signed-off-by from its committer.



My fault, I forgot it when I applied patch on my branch. Do we need an 
update or it is just a reminder?


regards
alex

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Torgue]

On 05/14/2018 11:22 PM, Stephen Rothwell wrote:

Hi all,

Commit

   949a0c0dec85 ("ARM: dts: stm32: add USB Host (USBH) support to stm32mp157c")

is missing a Signed-off-by from its committer.



My fault, I forgot it when I applied patch on my branch. Do we need an 
update or it is just a reminder?


regards
alex

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  949a0c0dec85 ("ARM: dts: stm32: add USB Host (USBH) support to stm32mp157c")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpNX46tUXrvj.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  949a0c0dec85 ("ARM: dts: stm32: add USB Host (USBH) support to stm32mp157c")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpNX46tUXrvj.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Patrice CHOTARD]

On 03/22/2018 10:01 PM, Alexandre Belloni wrote:
> On 16/03/2018 at 07:34:06 +, Patrice CHOTARD wrote:
>> Hi Arnd, Stephen
>>
>> On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
>>> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  
>>> wrote:
 Hi all,

 Commit

 9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")

 is missing a Signed-off-by from its committer.
>>>
>>> Thanks for the report.
>>>
>>> What script do you use to find those? I guess I should check for
>>> missing signoffs as well when pulling a branch.
>>>
>>> Patrice, I've dropped the merge now, and picked up the one
>>> patch in it directly, with my signoff. This should fix the issue this
>>> time, but please make sure you always sign off patches when
>>> you apply them from the list.
>>>
>>>   Arnd
>>>
>>
>> Ok i will update my script on my side with Stephen's script to avoid
>> this in the future.
>>
> 
> FWIW, last time this happened in the at91 tree, I've switched to use
> Stephen's script as a pre-push hook:
> https://raw.githubusercontent.com/alexandrebelloni/tools/master/pre-push_signed-off
> 
> 

Thanks Alexandre

Patrice

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Patrice CHOTARD]

On 03/22/2018 10:01 PM, Alexandre Belloni wrote:
> On 16/03/2018 at 07:34:06 +, Patrice CHOTARD wrote:
>> Hi Arnd, Stephen
>>
>> On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
>>> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  
>>> wrote:
 Hi all,

 Commit

 9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")

 is missing a Signed-off-by from its committer.
>>>
>>> Thanks for the report.
>>>
>>> What script do you use to find those? I guess I should check for
>>> missing signoffs as well when pulling a branch.
>>>
>>> Patrice, I've dropped the merge now, and picked up the one
>>> patch in it directly, with my signoff. This should fix the issue this
>>> time, but please make sure you always sign off patches when
>>> you apply them from the list.
>>>
>>>   Arnd
>>>
>>
>> Ok i will update my script on my side with Stephen's script to avoid
>> this in the future.
>>
> 
> FWIW, last time this happened in the at91 tree, I've switched to use
> Stephen's script as a pre-push hook:
> https://raw.githubusercontent.com/alexandrebelloni/tools/master/pre-push_signed-off
> 
> 

Thanks Alexandre

Patrice

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Belloni]

On 16/03/2018 at 07:34:06 +, Patrice CHOTARD wrote:
> Hi Arnd, Stephen
> 
> On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
> > On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  
> > wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >>9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
> >>
> >> is missing a Signed-off-by from its committer.
> > 
> > Thanks for the report.
> > 
> > What script do you use to find those? I guess I should check for
> > missing signoffs as well when pulling a branch.
> > 
> > Patrice, I've dropped the merge now, and picked up the one
> > patch in it directly, with my signoff. This should fix the issue this
> > time, but please make sure you always sign off patches when
> > you apply them from the list.
> > 
> >  Arnd
> > 
> 
> Ok i will update my script on my side with Stephen's script to avoid 
> this in the future.
> 

FWIW, last time this happened in the at91 tree, I've switched to use
Stephen's script as a pre-push hook:
https://raw.githubusercontent.com/alexandrebelloni/tools/master/pre-push_signed-off


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Belloni]

On 16/03/2018 at 07:34:06 +, Patrice CHOTARD wrote:
> Hi Arnd, Stephen
> 
> On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
> > On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  
> > wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >>9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
> >>
> >> is missing a Signed-off-by from its committer.
> > 
> > Thanks for the report.
> > 
> > What script do you use to find those? I guess I should check for
> > missing signoffs as well when pulling a branch.
> > 
> > Patrice, I've dropped the merge now, and picked up the one
> > patch in it directly, with my signoff. This should fix the issue this
> > time, but please make sure you always sign off patches when
> > you apply them from the list.
> > 
> >  Arnd
> > 
> 
> Ok i will update my script on my side with Stephen's script to avoid 
> this in the future.
> 

FWIW, last time this happened in the at91 tree, I've switched to use
Stephen's script as a pre-push hook:
https://raw.githubusercontent.com/alexandrebelloni/tools/master/pre-push_signed-off


-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Patrice CHOTARD]

Hi Arnd, Stephen

On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  
> wrote:
>> Hi all,
>>
>> Commit
>>
>>9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>>
>> is missing a Signed-off-by from its committer.
> 
> Thanks for the report.
> 
> What script do you use to find those? I guess I should check for
> missing signoffs as well when pulling a branch.
> 
> Patrice, I've dropped the merge now, and picked up the one
> patch in it directly, with my signoff. This should fix the issue this
> time, but please make sure you always sign off patches when
> you apply them from the list.
> 
>  Arnd
> 

Ok i will update my script on my side with Stephen's script to avoid 
this in the future.

Thanks

Patrice

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Patrice CHOTARD]

Hi Arnd, Stephen

On 03/15/2018 10:06 PM, Arnd Bergmann wrote:
> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  
> wrote:
>> Hi all,
>>
>> Commit
>>
>>9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>>
>> is missing a Signed-off-by from its committer.
> 
> Thanks for the report.
> 
> What script do you use to find those? I guess I should check for
> missing signoffs as well when pulling a branch.
> 
> Patrice, I've dropped the merge now, and picked up the one
> patch in it directly, with my signoff. This should fix the issue this
> time, but please make sure you always sign off patches when
> you apply them from the list.
> 
>  Arnd
> 

Ok i will update my script on my side with Stephen's script to avoid 
this in the future.

Thanks

Patrice

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi Arnd,

On Thu, 15 Mar 2018 22:06:29 +0100 Arnd Bergmann  wrote:
>
> What script do you use to find those? I guess I should check for
> missing signoffs as well when pulling a branch.

See below.  You can give it any commit range you would give e.g. gitk.
I run this using he ranges reported by the "git fetch" for each tree
each day.
-- 
Cheers,
Stephen Rothwell

#!/bin/bash

if [ "$#" -lt 1 ]; then
printf "Usage: %s \n", "$0" 1>&2
exit 1
fi

commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi

for c in $commits; do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i 
'^[[:space:]]*Signed-off-by:')

am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true

if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done

exec gitk "$@"


pgp4_WmYk3K0A.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi Arnd,

On Thu, 15 Mar 2018 22:06:29 +0100 Arnd Bergmann  wrote:
>
> What script do you use to find those? I guess I should check for
> missing signoffs as well when pulling a branch.

See below.  You can give it any commit range you would give e.g. gitk.
I run this using he ranges reported by the "git fetch" for each tree
each day.
-- 
Cheers,
Stephen Rothwell

#!/bin/bash

if [ "$#" -lt 1 ]; then
printf "Usage: %s \n", "$0" 1>&2
exit 1
fi

commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi

for c in $commits; do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i 
'^[[:space:]]*Signed-off-by:')

am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true

if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done

exec gitk "$@"


pgp4_WmYk3K0A.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>
> is missing a Signed-off-by from its committer.

Thanks for the report.

What script do you use to find those? I guess I should check for
missing signoffs as well when pulling a branch.

Patrice, I've dropped the merge now, and picked up the one
patch in it directly, with my signoff. This should fix the issue this
time, but please make sure you always sign off patches when
you apply them from the list.

Arnd

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")
>
> is missing a Signed-off-by from its committer.

Thanks for the report.

What script do you use to find those? I guess I should check for
missing signoffs as well when pulling a branch.

Patrice, I've dropped the merge now, and picked up the one
patch in it directly, with my signoff. This should fix the issue this
time, but please make sure you always sign off patches when
you apply them from the list.

Arnd

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpoI52on2xrE.pgp
Description: OpenPGP digital signature

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell


pgpoI52on2xrE.pgp
Description: OpenPGP digital signature

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Tue, Jan 23, 2018 at 6:16 AM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   8dd0e9b5f7fa ("of: platform: fix OF node refcount leak")
>
> is missing a Signed-off-by from its committer.

Fixed now, thanks for pointing out my mistake.

   Arnd

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Arnd Bergmann]

On Tue, Jan 23, 2018 at 6:16 AM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   8dd0e9b5f7fa ("of: platform: fix OF node refcount leak")
>
> is missing a Signed-off-by from its committer.

Fixed now, thanks for pointing out my mistake.

   Arnd

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  8dd0e9b5f7fa ("of: platform: fix OF node refcount leak")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  8dd0e9b5f7fa ("of: platform: fix OF node refcount leak")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Kevin Hilman]

Olof Johansson  writes:

> Thanks, Stephen. I need to get a similar script going to catch these
> things in our own tree.
>
> Since this was a clean revert, I've redone it myself, carrying over
> descriptions from the pull request and keeping attribution to Kevin.
>
> Kevin; hope this is alright with you. We can revisit if not.

Yes, that's fine with me.  Thanks for cleaning up, and sorry I missed
the sign-off.

Kevin



>
> -Olof
>
>
> On Sun, Dec 3, 2017 at 1:32 PM, Stephen Rothwell  
> wrote:
>> Hi all,
>>
>> Commit
>>
>>   5f56b7f4854a ("Revert "Merge tag 'scpi-updates-4.15' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux
>> into next/drivers"")
>>
>> is missing a Signed-off-by from its author or committer.
>>
>> Reverts are commits as well and so need an explanation of why they
>> are done and Signed-off-by tags.
>>
>> --
>> Cheers,
>> Stephen Rothwell
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-next" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Kevin Hilman]

Olof Johansson  writes:

> Thanks, Stephen. I need to get a similar script going to catch these
> things in our own tree.
>
> Since this was a clean revert, I've redone it myself, carrying over
> descriptions from the pull request and keeping attribution to Kevin.
>
> Kevin; hope this is alright with you. We can revisit if not.

Yes, that's fine with me.  Thanks for cleaning up, and sorry I missed
the sign-off.

Kevin



>
> -Olof
>
>
> On Sun, Dec 3, 2017 at 1:32 PM, Stephen Rothwell  
> wrote:
>> Hi all,
>>
>> Commit
>>
>>   5f56b7f4854a ("Revert "Merge tag 'scpi-updates-4.15' of
>> git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux
>> into next/drivers"")
>>
>> is missing a Signed-off-by from its author or committer.
>>
>> Reverts are commits as well and so need an explanation of why they
>> are done and Signed-off-by tags.
>>
>> --
>> Cheers,
>> Stephen Rothwell
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-next" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Olof Johansson]

Thanks, Stephen. I need to get a similar script going to catch these
things in our own tree.

Since this was a clean revert, I've redone it myself, carrying over
descriptions from the pull request and keeping attribution to Kevin.

Kevin; hope this is alright with you. We can revisit if not.


-Olof


On Sun, Dec 3, 2017 at 1:32 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   5f56b7f4854a ("Revert "Merge tag 'scpi-updates-4.15' of 
> git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into 
> next/drivers"")
>
> is missing a Signed-off-by from its author or committer.
>
> Reverts are commits as well and so need an explanation of why they
> are done and Signed-off-by tags.
>
> --
> Cheers,
> Stephen Rothwell
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Olof Johansson]

Thanks, Stephen. I need to get a similar script going to catch these
things in our own tree.

Since this was a clean revert, I've redone it myself, carrying over
descriptions from the pull request and keeping attribution to Kevin.

Kevin; hope this is alright with you. We can revisit if not.


-Olof


On Sun, Dec 3, 2017 at 1:32 PM, Stephen Rothwell  wrote:
> Hi all,
>
> Commit
>
>   5f56b7f4854a ("Revert "Merge tag 'scpi-updates-4.15' of 
> git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into 
> next/drivers"")
>
> is missing a Signed-off-by from its author or committer.
>
> Reverts are commits as well and so need an explanation of why they
> are done and Signed-off-by tags.
>
> --
> Cheers,
> Stephen Rothwell
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  5f56b7f4854a ("Revert "Merge tag 'scpi-updates-4.15' of 
git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into 
next/drivers"")

is missing a Signed-off-by from its author or committer.

Reverts are commits as well and so need an explanation of why they
are done and Signed-off-by tags.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  5f56b7f4854a ("Revert "Merge tag 'scpi-updates-4.15' of 
git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into 
next/drivers"")

is missing a Signed-off-by from its author or committer.

Reverts are commits as well and so need an explanation of why they
are done and Signed-off-by tags.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi Olof,

On Wed, 30 Aug 2017 09:21:47 -0700 Olof Johansson  wrote:
>
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?

Script below.

-- 
Cheers,
Stephen Rothwell

#!/bin/bash

if [ "$#" -lt 1 ]; then
printf "Usage: %s \n", "$0" 1>&2
exit 1
fi

for c in $(git rev-list --no-merges "$@"); do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i 
'^[[:space:]]*Signed-off-by:')

am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true

if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done

exec gitk "$@"

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi Olof,

On Wed, 30 Aug 2017 09:21:47 -0700 Olof Johansson  wrote:
>
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?

Script below.

-- 
Cheers,
Stephen Rothwell

#!/bin/bash

if [ "$#" -lt 1 ]; then
printf "Usage: %s \n", "$0" 1>&2
exit 1
fi

for c in $(git rev-list --no-merges "$@"); do
ae=$(git log -1 --format='%ae' "$c")
aE=$(git log -1 --format='%aE' "$c")
an=$(git log -1 --format='%an' "$c")
aN=$(git log -1 --format='%aN' "$c")
ce=$(git log -1 --format='%ce' "$c")
cE=$(git log -1 --format='%cE' "$c")
cn=$(git log -1 --format='%cn' "$c")
cN=$(git log -1 --format='%cN' "$c")
sob=$(git log -1 --format='%b' "$c" | grep -i 
'^[[:space:]]*Signed-off-by:')

am=false
cm=false
grep -i -q "<$ae>" <<<"$sob" ||
grep -i -q "<$aE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$an[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$aN[[:space:]]*<" <<<"$sob" ||
am=true
grep -i -q "<$ce>" <<<"$sob" ||
grep -i -q "<$cE>" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cn[[:space:]]*<" <<<"$sob" ||
grep -i -q ":[[:space:]]*$cN[[:space:]]*<" <<<"$sob" ||
cm=true

if "$am" || "$cm"; then
printf "Commit %s\n" "$c"
"$am" && printf "\tauthor SOB missing\n"
"$cm" && printf "\tcommitter SOB missing\n"
printf "%s %s\n%s\n" "$ae" "$ce" "$sob"
fi
done

exec gitk "$@"

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Belloni]

On 30/08/2017 at 09:21:47 -0700, Olof Johansson wrote:
> On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
>  wrote:
> > On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >>   1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
> >>
> >> is missing a Signed-off-by from its author.
> >>
> >
> > Oh crap, it was the only one not in linux-next... iThe original
> > submission had the SoB:
> > https://patchwork.kernel.org/patch/9794803/
> >
> > Olof, how do you want to proceed?
> 
> Please prepare a new branch. I'll rebuild next/dt (and our for-next)
> to drop your previous version, and merge it when it's ready.
> 
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?
> 

Yeah, I'm interested as well as I'm already using a pre_push hook to check
that my SoB is there.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Belloni]

On 30/08/2017 at 09:21:47 -0700, Olof Johansson wrote:
> On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
>  wrote:
> > On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> Commit
> >>
> >>   1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
> >>
> >> is missing a Signed-off-by from its author.
> >>
> >
> > Oh crap, it was the only one not in linux-next... iThe original
> > submission had the SoB:
> > https://patchwork.kernel.org/patch/9794803/
> >
> > Olof, how do you want to proceed?
> 
> Please prepare a new branch. I'll rebuild next/dt (and our for-next)
> to drop your previous version, and merge it when it's ready.
> 
> Thanks for the heads up, Stephen. I presume you have a script that
> checks this? It's something we should run too, do you keep it in a
> shared location?
> 

Yeah, I'm interested as well as I'm already using a pre_push hook to check
that my SoB is there.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Olof Johansson]

On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
 wrote:
> On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>>   1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
>>
>> is missing a Signed-off-by from its author.
>>
>
> Oh crap, it was the only one not in linux-next... iThe original
> submission had the SoB:
> https://patchwork.kernel.org/patch/9794803/
>
> Olof, how do you want to proceed?

Please prepare a new branch. I'll rebuild next/dt (and our for-next)
to drop your previous version, and merge it when it's ready.

Thanks for the heads up, Stephen. I presume you have a script that
checks this? It's something we should run too, do you keep it in a
shared location?


-Olof

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Olof Johansson]

On Wed, Aug 30, 2017 at 6:19 AM, Alexandre Belloni
 wrote:
> On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> Commit
>>
>>   1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
>>
>> is missing a Signed-off-by from its author.
>>
>
> Oh crap, it was the only one not in linux-next... iThe original
> submission had the SoB:
> https://patchwork.kernel.org/patch/9794803/
>
> Olof, how do you want to proceed?

Please prepare a new branch. I'll rebuild next/dt (and our for-next)
to drop your previous version, and merge it when it's ready.

Thanks for the heads up, Stephen. I presume you have a script that
checks this? It's something we should run too, do you keep it in a
shared location?


-Olof

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Belloni]

On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
> 
> is missing a Signed-off-by from its author.
> 

Oh crap, it was the only one not in linux-next... iThe original
submission had the SoB:
https://patchwork.kernel.org/patch/9794803/

Olof, how do you want to proceed?

> -- 
> Cheers,
> Stephen Rothwell

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

[Alexandre Belloni]

On 30/08/2017 at 23:07:12 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")
> 
> is missing a Signed-off-by from its author.
> 

Oh crap, it was the only one not in linux-next... iThe original
submission had the SoB:
https://patchwork.kernel.org/patch/9794803/

Olof, how do you want to proceed?

> -- 
> Cheers,
> Stephen Rothwell

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

Commit

  1a9f9af07e80 ("ARM: dts: at91: at91sam9g45: add AC97")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing in commit in the arm-soc tree

[Arnd Bergmann]

On Thu, Jul 27, 2017 at 5:21 PM, Stephen Rothwell  wrote:
> Hi all,
>
> I noticed that commit
>
>   2cb68e9b44f7 ("ARM: ep93xx: normalize clk API")
>
> has no Signed-off-by from its committer.

Thanks, my mistake. I initially cherry-picked this one and added my S-o-B,
but then had to do it again and forgot to add it when I picked it the
second time.

I uploaded the new head now. Alexander, when you rebase your other patches
on top of the fixes branch, please make sure you have the version I
just uploaded,
not the one from earlier today.  I usually don't rebase that branch,
but it seemed
otherwise harmless enough.

  Arnd

Re: linux-next: Signed-off-by missing in commit in the arm-soc tree

[Arnd Bergmann]

On Thu, Jul 27, 2017 at 5:21 PM, Stephen Rothwell  wrote:
> Hi all,
>
> I noticed that commit
>
>   2cb68e9b44f7 ("ARM: ep93xx: normalize clk API")
>
> has no Signed-off-by from its committer.

Thanks, my mistake. I initially cherry-picked this one and added my S-o-B,
but then had to do it again and forgot to add it when I picked it the
second time.

I uploaded the new head now. Alexander, when you rebase your other patches
on top of the fixes branch, please make sure you have the version I
just uploaded,
not the one from earlier today.  I usually don't rebase that branch,
but it seemed
otherwise harmless enough.

  Arnd

linux-next: Signed-off-by missing in commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

I noticed that commit

  2cb68e9b44f7 ("ARM: ep93xx: normalize clk API")

has no Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing in commit in the arm-soc tree

[Stephen Rothwell]

Hi all,

I noticed that commit

  2cb68e9b44f7 ("ARM: ep93xx: normalize clk API")

has no Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell