Re: + fls-change-parameter-to-unsigned-int.patch added to -mm tree

2018-11-06 Thread Alexey Dobriyan
On Tue, Nov 06, 2018 at 07:44:37AM -0800, Matthew Wilcox wrote: > On Tue, Nov 06, 2018 at 06:14:44PM +0300, Alexey Dobriyan wrote: > > On Mon, Nov 05, 2018 at 03:33:01PM -0800, a...@linux-foundation.org wrote: > > > > > -static inline int fls(int x) > > > +static inline int fls(unsigned int x) > >

Re: + fls-change-parameter-to-unsigned-int.patch added to -mm tree

2018-11-06 Thread Matthew Wilcox
On Tue, Nov 06, 2018 at 06:14:44PM +0300, Alexey Dobriyan wrote: > On Mon, Nov 05, 2018 at 03:33:01PM -0800, a...@linux-foundation.org wrote: > > > -static inline int fls(int x) > > +static inline int fls(unsigned int x) > > { > > - return fls64((unsigned int) x); > > + return fls64(x); > >

Re: + fls-change-parameter-to-unsigned-int.patch added to -mm tree

2018-11-06 Thread Alexey Dobriyan
On Mon, Nov 05, 2018 at 03:33:01PM -0800, a...@linux-foundation.org wrote: > -static inline int fls(int x) > +static inline int fls(unsigned int x) > { > - return fls64((unsigned int) x); > + return fls64(x); > } Should it return "unsigned"? Logically it should. I remember doing this an