Re: [ 13/40] vmscan: shrinker->nr updates race and go wrong

2012-07-30 Thread Greg Kroah-Hartman
On Mon, Jul 30, 2012 at 10:06:45AM +0100, Mel Gorman wrote: > On Sun, Jul 29, 2012 at 09:29:30PM +0100, Ben Hutchings wrote: > > > --- a/mm/vmscan.c > > > +++ b/mm/vmscan.c > > > @@ -251,17 +251,29 @@ unsigned long shrink_slab(struct shrink_ > > > unsigned long total_scan; > > [...] > > >

Re: [ 13/40] vmscan: shrinker->nr updates race and go wrong

2012-07-30 Thread Mel Gorman
On Sun, Jul 29, 2012 at 09:29:30PM +0100, Ben Hutchings wrote: > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -251,17 +251,29 @@ unsigned long shrink_slab(struct shrink_ > > unsigned long total_scan; > [...] > > + total_scan += delta; > > + if (total_scan < 0) {

Re: [ 13/40] vmscan: shrinker->nr updates race and go wrong

2012-07-29 Thread Ben Hutchings
On Thu, 2012-07-26 at 14:29 -0700, Greg Kroah-Hartman wrote: > From: Greg KH > > 3.0-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Dave Chinner > > commit acf92b485cccf028177f46918e045c0c4e80ee10 upstream. > > Stable note: Not tracke

[ 13/40] vmscan: shrinker->nr updates race and go wrong

2012-07-26 Thread Greg Kroah-Hartman
From: Greg KH 3.0-stable review patch. If anyone has any objections, please let me know. -- From: Dave Chinner commit acf92b485cccf028177f46918e045c0c4e80ee10 upstream. Stable note: Not tracked in Bugzilla. This patch reduces excessive reclaim of slab objects reducin