Re: [ patch 5/7] drivers/serial/jsm: new serial device driver
Jeff Garzik wrote: Wen Xiong wrote: +/* Our "in use" variables, to enforce 1 open only */ +static int jsm_mgmt_in_use[MAXMGMTDEVICES]; Eliminate MAXMGMTDEVICES + +/* + * jsm_mgmt_open() + * + * Open the mgmt/downld/dpa device + */ +int jsm_mgmt_open(struct inode *inode, struct file *file) +{ +unsigned long lock_flags; +unsigned int minor = JSM_MINOR(inode); + +DPR_MGMT(("jsm_mgmt_open start.\n")); + +spin_lock_irqsave(_global_lock, lock_flags); + +/* mgmt device */ +if (minor < MAXMGMTDEVICES) { +/* Only allow 1 open at a time on mgmt device */ +if (jsm_mgmt_in_use[minor]) { +spin_unlock_irqrestore(_global_lock, lock_flags); +return -EBUSY; +} +jsm_mgmt_in_use[minor]++; An interruptible sleep (semaphore?) is usually preferred to EBUSY. +else { +spin_unlock_irqrestore(_global_lock, lock_flags); +return -ENXIO; +} + +spin_unlock_irqrestore(_global_lock, lock_flags); + +DPR_MGMT(("jsm_mgmt_open finish.\n")); + +return 0; +} + +/* + * jsm_mgmt_close() + * + * Open the mgmt/dpa device + */ +int jsm_mgmt_close(struct inode *inode, struct file *file) +{ +unsigned long lock_flags; +unsigned int minor = JSM_MINOR(inode); + +DPR_MGMT(("jsm_mgmt_close start.\n")); + +spin_lock_irqsave(_global_lock, lock_flags); + +/* mgmt device */ +if (minor < MAXMGMTDEVICES) { +if (jsm_mgmt_in_use[minor]) +jsm_mgmt_in_use[minor] = 0; +} +spin_unlock_irqrestore(_global_lock, lock_flags); + +DPR_MGMT(("jsm_mgmt_close finish.\n")); + +return 0; +} + +/* + * jsm_mgmt_ioctl() + * + * ioctl the mgmt/dpa device + */ + +int jsm_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +{ +unsigned long lock_flags; +void __user *uarg = (void __user *) arg; + +DPR_MGMT(("jsm_mgmt_ioctl start.\n")); + +switch (cmd) { + +case DIGI_GETDD: +{ +/* + * This returns the total number of boards + * in the system, as well as driver version + * and has space for a reserved entry + */ +struct digi_dinfo ddi; stack usage +spin_lock_irqsave(_global_lock, lock_flags); + +ddi.dinfo_nboards = jsm_NumBoards; +sprintf(ddi.dinfo_version, "%s", "40002438_A-INKERNEL"); + +spin_unlock_irqrestore(_global_lock, lock_flags); + +DPR_MGMT(("DIGI_GETDD returning numboards: %d version: %s\n", +ddi.dinfo_nboards, ddi.dinfo_version)); + +if (copy_to_user(uarg, , sizeof (ddi))) +return -EFAULT; + +break; +} + +case DIGI_GETBD: +{ +int brd; + +struct digi_info di; ditto +if (copy_from_user(, uarg, sizeof(int))) +return -EFAULT; + +DPR_MGMT(("DIGI_GETBD asking about board: %d\n", brd)); + +if ((brd < 0) || (brd > jsm_NumBoards) || (jsm_NumBoards == 0)) +return -ENODEV; + +memset(, 0, sizeof(di)); + +di.info_bdnum = brd; + +spin_lock_irqsave(_Board[brd]->bd_lock, lock_flags); + +di.info_bdtype = jsm_Board[brd]->dpatype; +di.info_bdstate = jsm_Board[brd]->dpastatus; +di.info_ioport = 0; +di.info_physaddr = (ulong) jsm_Board[brd]->membase; +di.info_physsize = (ulong) jsm_Board[brd]->membase - jsm_Board[brd]->membase_end; +if (jsm_Board[brd]->state != BOARD_FAILED) +di.info_nports = jsm_Board[brd]->nasync; +else +di.info_nports = 0; + +spin_unlock_irqrestore(_Board[brd]->bd_lock, lock_flags); + +DPR_MGMT(("DIGI_GETBD returning type: %x state: %x ports: %x size: %x\n", +di.info_bdtype, di.info_bdstate, di.info_nports, di.info_physsize)); + +if (copy_to_user(uarg, , sizeof (di))) +return -EFAULT; + +break; +} + +case DIGI_GET_NI_INFO: +{ +struct channel_t *ch; +struct ni_info ni; +ulong lock_flags; +uchar mstat = 0; +uint board = 0; +uint channel = 0; + +if (copy_from_user(, uarg, sizeof(struct ni_info))) +return -EFAULT; + +DPR_MGMT(("DIGI_GETBD asking about board: %d channel: %d\n", +ni.board, ni.channel)); + +board = ni.board; +channel = ni.channel; + +/* Verify boundaries on board */ +if ((board < 0) || (board > jsm_NumBoards) || (jsm_NumBoards == 0)) +return -ENODEV; + +/* Verify boundaries on channel */ +if ((channel < 0) || (channel > jsm_Board[board]->nasync)) +return -ENODEV; + +ch = jsm_Board[board]->channels[channel]; + +if (!ch || ch->magic != JSM_CHANNEL_MAGIC) +return -ENODEV; + +memset(, 0, sizeof(ni)); +ni.board = board; +ni.channel = channel; + +spin_lock_irqsave(>ch_lock, lock_flags); + +mstat = (ch->ch_mostat | ch->ch_mistat);
Re: [ patch 5/7] drivers/serial/jsm: new serial device driver
Jeff Garzik wrote: Wen Xiong wrote: +/* Our in use variables, to enforce 1 open only */ +static int jsm_mgmt_in_use[MAXMGMTDEVICES]; Eliminate MAXMGMTDEVICES + +/* + * jsm_mgmt_open() + * + * Open the mgmt/downld/dpa device + */ +int jsm_mgmt_open(struct inode *inode, struct file *file) +{ +unsigned long lock_flags; +unsigned int minor = JSM_MINOR(inode); + +DPR_MGMT((jsm_mgmt_open start.\n)); + +spin_lock_irqsave(jsm_global_lock, lock_flags); + +/* mgmt device */ +if (minor MAXMGMTDEVICES) { +/* Only allow 1 open at a time on mgmt device */ +if (jsm_mgmt_in_use[minor]) { +spin_unlock_irqrestore(jsm_global_lock, lock_flags); +return -EBUSY; +} +jsm_mgmt_in_use[minor]++; An interruptible sleep (semaphore?) is usually preferred to EBUSY. +else { +spin_unlock_irqrestore(jsm_global_lock, lock_flags); +return -ENXIO; +} + +spin_unlock_irqrestore(jsm_global_lock, lock_flags); + +DPR_MGMT((jsm_mgmt_open finish.\n)); + +return 0; +} + +/* + * jsm_mgmt_close() + * + * Open the mgmt/dpa device + */ +int jsm_mgmt_close(struct inode *inode, struct file *file) +{ +unsigned long lock_flags; +unsigned int minor = JSM_MINOR(inode); + +DPR_MGMT((jsm_mgmt_close start.\n)); + +spin_lock_irqsave(jsm_global_lock, lock_flags); + +/* mgmt device */ +if (minor MAXMGMTDEVICES) { +if (jsm_mgmt_in_use[minor]) +jsm_mgmt_in_use[minor] = 0; +} +spin_unlock_irqrestore(jsm_global_lock, lock_flags); + +DPR_MGMT((jsm_mgmt_close finish.\n)); + +return 0; +} + +/* + * jsm_mgmt_ioctl() + * + * ioctl the mgmt/dpa device + */ + +int jsm_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +{ +unsigned long lock_flags; +void __user *uarg = (void __user *) arg; + +DPR_MGMT((jsm_mgmt_ioctl start.\n)); + +switch (cmd) { + +case DIGI_GETDD: +{ +/* + * This returns the total number of boards + * in the system, as well as driver version + * and has space for a reserved entry + */ +struct digi_dinfo ddi; stack usage +spin_lock_irqsave(jsm_global_lock, lock_flags); + +ddi.dinfo_nboards = jsm_NumBoards; +sprintf(ddi.dinfo_version, %s, 40002438_A-INKERNEL); + +spin_unlock_irqrestore(jsm_global_lock, lock_flags); + +DPR_MGMT((DIGI_GETDD returning numboards: %d version: %s\n, +ddi.dinfo_nboards, ddi.dinfo_version)); + +if (copy_to_user(uarg, ddi, sizeof (ddi))) +return -EFAULT; + +break; +} + +case DIGI_GETBD: +{ +int brd; + +struct digi_info di; ditto +if (copy_from_user(brd, uarg, sizeof(int))) +return -EFAULT; + +DPR_MGMT((DIGI_GETBD asking about board: %d\n, brd)); + +if ((brd 0) || (brd jsm_NumBoards) || (jsm_NumBoards == 0)) +return -ENODEV; + +memset(di, 0, sizeof(di)); + +di.info_bdnum = brd; + +spin_lock_irqsave(jsm_Board[brd]-bd_lock, lock_flags); + +di.info_bdtype = jsm_Board[brd]-dpatype; +di.info_bdstate = jsm_Board[brd]-dpastatus; +di.info_ioport = 0; +di.info_physaddr = (ulong) jsm_Board[brd]-membase; +di.info_physsize = (ulong) jsm_Board[brd]-membase - jsm_Board[brd]-membase_end; +if (jsm_Board[brd]-state != BOARD_FAILED) +di.info_nports = jsm_Board[brd]-nasync; +else +di.info_nports = 0; + +spin_unlock_irqrestore(jsm_Board[brd]-bd_lock, lock_flags); + +DPR_MGMT((DIGI_GETBD returning type: %x state: %x ports: %x size: %x\n, +di.info_bdtype, di.info_bdstate, di.info_nports, di.info_physsize)); + +if (copy_to_user(uarg, di, sizeof (di))) +return -EFAULT; + +break; +} + +case DIGI_GET_NI_INFO: +{ +struct channel_t *ch; +struct ni_info ni; +ulong lock_flags; +uchar mstat = 0; +uint board = 0; +uint channel = 0; + +if (copy_from_user(ni, uarg, sizeof(struct ni_info))) +return -EFAULT; + +DPR_MGMT((DIGI_GETBD asking about board: %d channel: %d\n, +ni.board, ni.channel)); + +board = ni.board; +channel = ni.channel; + +/* Verify boundaries on board */ +if ((board 0) || (board jsm_NumBoards) || (jsm_NumBoards == 0)) +return -ENODEV; + +/* Verify boundaries on channel */ +if ((channel 0) || (channel jsm_Board[board]-nasync)) +return -ENODEV; + +ch = jsm_Board[board]-channels[channel]; + +if (!ch || ch-magic != JSM_CHANNEL_MAGIC) +return -ENODEV; + +memset(ni, 0, sizeof(ni)); +ni.board = board; +ni.channel = channel; + +spin_lock_irqsave(ch-ch_lock, lock_flags); + +mstat = (ch-ch_mostat | ch-ch_mistat);
Re: [ patch 5/7] drivers/serial/jsm: new serial device driver
Wen Xiong wrote: +/* Our "in use" variables, to enforce 1 open only */ +static int jsm_mgmt_in_use[MAXMGMTDEVICES]; Eliminate MAXMGMTDEVICES + +/* + * jsm_mgmt_open() + * + * Open the mgmt/downld/dpa device + */ +int jsm_mgmt_open(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT(("jsm_mgmt_open start.\n")); + + spin_lock_irqsave(_global_lock, lock_flags); + + /* mgmt device */ + if (minor < MAXMGMTDEVICES) { + /* Only allow 1 open at a time on mgmt device */ + if (jsm_mgmt_in_use[minor]) { + spin_unlock_irqrestore(_global_lock, lock_flags); + return -EBUSY; + } + jsm_mgmt_in_use[minor]++; An interruptible sleep (semaphore?) is usually preferred to EBUSY. + else { + spin_unlock_irqrestore(_global_lock, lock_flags); + return -ENXIO; + } + + spin_unlock_irqrestore(_global_lock, lock_flags); + + DPR_MGMT(("jsm_mgmt_open finish.\n")); + + return 0; +} + +/* + * jsm_mgmt_close() + * + * Open the mgmt/dpa device + */ +int jsm_mgmt_close(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT(("jsm_mgmt_close start.\n")); + + spin_lock_irqsave(_global_lock, lock_flags); + + /* mgmt device */ + if (minor < MAXMGMTDEVICES) { + if (jsm_mgmt_in_use[minor]) + jsm_mgmt_in_use[minor] = 0; + } + spin_unlock_irqrestore(_global_lock, lock_flags); + + DPR_MGMT(("jsm_mgmt_close finish.\n")); + + return 0; +} + +/* + * jsm_mgmt_ioctl() + * + * ioctl the mgmt/dpa device + */ + +int jsm_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +{ + unsigned long lock_flags; + void __user *uarg = (void __user *) arg; + + DPR_MGMT(("jsm_mgmt_ioctl start.\n")); + + switch (cmd) { + + case DIGI_GETDD: + { + /* + * This returns the total number of boards + * in the system, as well as driver version + * and has space for a reserved entry + */ + struct digi_dinfo ddi; stack usage + spin_lock_irqsave(_global_lock, lock_flags); + + ddi.dinfo_nboards = jsm_NumBoards; + sprintf(ddi.dinfo_version, "%s", "40002438_A-INKERNEL"); + + spin_unlock_irqrestore(_global_lock, lock_flags); + + DPR_MGMT(("DIGI_GETDD returning numboards: %d version: %s\n", + ddi.dinfo_nboards, ddi.dinfo_version)); + + if (copy_to_user(uarg, , sizeof (ddi))) + return -EFAULT; + + break; + } + + case DIGI_GETBD: + { + int brd; + + struct digi_info di; ditto + if (copy_from_user(, uarg, sizeof(int))) + return -EFAULT; + + DPR_MGMT(("DIGI_GETBD asking about board: %d\n", brd)); + + if ((brd < 0) || (brd > jsm_NumBoards) || (jsm_NumBoards == 0)) + return -ENODEV; + + memset(, 0, sizeof(di)); + + di.info_bdnum = brd; + + spin_lock_irqsave(_Board[brd]->bd_lock, lock_flags); + + di.info_bdtype = jsm_Board[brd]->dpatype; + di.info_bdstate = jsm_Board[brd]->dpastatus; + di.info_ioport = 0; + di.info_physaddr = (ulong) jsm_Board[brd]->membase; + di.info_physsize = (ulong) jsm_Board[brd]->membase - jsm_Board[brd]->membase_end; + if (jsm_Board[brd]->state != BOARD_FAILED) + di.info_nports = jsm_Board[brd]->nasync; + else + di.info_nports = 0; + + spin_unlock_irqrestore(_Board[brd]->bd_lock, lock_flags); + + DPR_MGMT(("DIGI_GETBD returning type: %x state: %x ports: %x size: %x\n", + di.info_bdtype, di.info_bdstate, di.info_nports, di.info_physsize)); + + if (copy_to_user(uarg, , sizeof (di))) + return -EFAULT; + + break; + } + + case DIGI_GET_NI_INFO: + { + struct channel_t *ch; + struct ni_info ni; + ulong lock_flags; + uchar mstat = 0; + uint board = 0; + uint channel = 0; + + if (copy_from_user(, uarg, sizeof(struct ni_info))) + return -EFAULT; + + DPR_MGMT(("DIGI_GETBD asking about board: %d channel: %d\n", + ni.board, ni.channel)); + + board = ni.board; + channel = ni.channel; + + /* Verify boundaries on board */ + if ((board < 0) || (board > jsm_NumBoards) || (jsm_NumBoards == 0)) + return -ENODEV; + + /* Verify boundaries on channel */ + if ((channel < 0) || (channel > jsm_Board[board]->nasync)) + return -ENODEV; + + ch = jsm_Board[board]->channels[channel]; + + if (!ch || ch->magic !=
[ patch 5/7] drivers/serial/jsm: new serial device driver
This patch is for jsm_mgmt.c. It includes the functions to process management ports. Signed-off-by: Wen Xiong <[EMAIL PROTECTED]> diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c linux-2.6.9.new/drivers/serial/jsm/jsm_mgmt.c --- linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c 1969-12-31 18:00:00.0 -0600 +++ linux-2.6.9.new/drivers/serial/jsm/jsm_mgmt.c 2005-02-27 17:13:56.783921464 -0600 @@ -0,0 +1,296 @@ +/* + * Copyright 2003 Digi International (www.digi.com) + * Scott H Kilau + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the + * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * + * + * NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! + * + * This is shared code between Digi's CVS archive and the + * Linux Kernel sources. + * Changing the source just for reformatting needlessly breaks + * our CVS diff history. + * + * Send any bug fixes/changes to: Eng.Linux at digi dot com. + * Thank you. + * + */ + +/ + * + * This file implements the mgmt functionality for the + * Neo and ClassicBoard based product lines. + * + + * $Id: jsm_mgmt.c,v 1.16 2004/08/30 21:40:39 scottk Exp $ + */ +#include +#include +#include +#include/* For jiffies, task states */ +#include/* For tasklet and interrupt structs/defines */ +#include +#include +#include/* For copy_from_user/copy_to_user */ + +#include "jsm_driver.h" +#include "jsm_pci.h" +#include "jsm_kcompat.h" /* Kernel 2.4/2.6 compat includes */ +#include "jsm_mgmt.h" +#include "dpacompat.h" + + +/* Our "in use" variables, to enforce 1 open only */ +static int jsm_mgmt_in_use[MAXMGMTDEVICES]; + +/* + * jsm_mgmt_open() + * + * Open the mgmt/downld/dpa device + */ +int jsm_mgmt_open(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT(("jsm_mgmt_open start.\n")); + + spin_lock_irqsave(_global_lock, lock_flags); + + /* mgmt device */ + if (minor < MAXMGMTDEVICES) { + /* Only allow 1 open at a time on mgmt device */ + if (jsm_mgmt_in_use[minor]) { + spin_unlock_irqrestore(_global_lock, lock_flags); + return -EBUSY; + } + jsm_mgmt_in_use[minor]++; + } + else { + spin_unlock_irqrestore(_global_lock, lock_flags); + return -ENXIO; + } + + spin_unlock_irqrestore(_global_lock, lock_flags); + + DPR_MGMT(("jsm_mgmt_open finish.\n")); + + return 0; +} + +/* + * jsm_mgmt_close() + * + * Open the mgmt/dpa device + */ +int jsm_mgmt_close(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT(("jsm_mgmt_close start.\n")); + + spin_lock_irqsave(_global_lock, lock_flags); + + /* mgmt device */ + if (minor < MAXMGMTDEVICES) { + if (jsm_mgmt_in_use[minor]) + jsm_mgmt_in_use[minor] = 0; + } + spin_unlock_irqrestore(_global_lock, lock_flags); + + DPR_MGMT(("jsm_mgmt_close finish.\n")); + + return 0; +} + +/* + * jsm_mgmt_ioctl() + * + * ioctl the mgmt/dpa device + */ + +int jsm_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +{ + unsigned long lock_flags; + void __user *uarg = (void __user *) arg; + + DPR_MGMT(("jsm_mgmt_ioctl start.\n")); + + switch (cmd) { + + case DIGI_GETDD: + { + /* +* This returns the total number of boards +* in the system, as well as driver version +* and has space for a reserved entry +*/ + struct digi_dinfo ddi; + + spin_lock_irqsave(_global_lock, lock_flags); + + ddi.dinfo_nboards = jsm_NumBoards; + sprintf(ddi.dinfo_version, "%s", "40002438_A-INKERNEL"); + + spin_unlock_irqrestore(_global_lock, lock_flags); + + DPR_MGMT(("DIGI_GETDD returning numboards: %d version: %s\n", + ddi.dinfo_nboards, ddi.dinfo_version)); +
[ patch 5/7] drivers/serial/jsm: new serial device driver
This patch is for jsm_mgmt.c. It includes the functions to process management ports. Signed-off-by: Wen Xiong [EMAIL PROTECTED] diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c linux-2.6.9.new/drivers/serial/jsm/jsm_mgmt.c --- linux-2.6.9.orig/drivers/serial/jsm/jsm_mgmt.c 1969-12-31 18:00:00.0 -0600 +++ linux-2.6.9.new/drivers/serial/jsm/jsm_mgmt.c 2005-02-27 17:13:56.783921464 -0600 @@ -0,0 +1,296 @@ +/* + * Copyright 2003 Digi International (www.digi.com) + * Scott H Kilau Scott_Kilau at digi dot com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the + * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * + * + * NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE! + * + * This is shared code between Digi's CVS archive and the + * Linux Kernel sources. + * Changing the source just for reformatting needlessly breaks + * our CVS diff history. + * + * Send any bug fixes/changes to: Eng.Linux at digi dot com. + * Thank you. + * + */ + +/ + * + * This file implements the mgmt functionality for the + * Neo and ClassicBoard based product lines. + * + + * $Id: jsm_mgmt.c,v 1.16 2004/08/30 21:40:39 scottk Exp $ + */ +#include linux/kernel.h +#include linux/version.h +#include linux/ctype.h +#include linux/sched.h /* For jiffies, task states */ +#include linux/interrupt.h /* For tasklet and interrupt structs/defines */ +#include linux/serial_reg.h +#include linux/termios.h +#include asm/uaccess.h /* For copy_from_user/copy_to_user */ + +#include jsm_driver.h +#include jsm_pci.h +#include jsm_kcompat.h /* Kernel 2.4/2.6 compat includes */ +#include jsm_mgmt.h +#include dpacompat.h + + +/* Our in use variables, to enforce 1 open only */ +static int jsm_mgmt_in_use[MAXMGMTDEVICES]; + +/* + * jsm_mgmt_open() + * + * Open the mgmt/downld/dpa device + */ +int jsm_mgmt_open(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT((jsm_mgmt_open start.\n)); + + spin_lock_irqsave(jsm_global_lock, lock_flags); + + /* mgmt device */ + if (minor MAXMGMTDEVICES) { + /* Only allow 1 open at a time on mgmt device */ + if (jsm_mgmt_in_use[minor]) { + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + return -EBUSY; + } + jsm_mgmt_in_use[minor]++; + } + else { + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + return -ENXIO; + } + + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + + DPR_MGMT((jsm_mgmt_open finish.\n)); + + return 0; +} + +/* + * jsm_mgmt_close() + * + * Open the mgmt/dpa device + */ +int jsm_mgmt_close(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT((jsm_mgmt_close start.\n)); + + spin_lock_irqsave(jsm_global_lock, lock_flags); + + /* mgmt device */ + if (minor MAXMGMTDEVICES) { + if (jsm_mgmt_in_use[minor]) + jsm_mgmt_in_use[minor] = 0; + } + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + + DPR_MGMT((jsm_mgmt_close finish.\n)); + + return 0; +} + +/* + * jsm_mgmt_ioctl() + * + * ioctl the mgmt/dpa device + */ + +int jsm_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +{ + unsigned long lock_flags; + void __user *uarg = (void __user *) arg; + + DPR_MGMT((jsm_mgmt_ioctl start.\n)); + + switch (cmd) { + + case DIGI_GETDD: + { + /* +* This returns the total number of boards +* in the system, as well as driver version +* and has space for a reserved entry +*/ + struct digi_dinfo ddi; + + spin_lock_irqsave(jsm_global_lock, lock_flags); + + ddi.dinfo_nboards = jsm_NumBoards; + sprintf(ddi.dinfo_version, %s, 40002438_A-INKERNEL); + + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + +
Re: [ patch 5/7] drivers/serial/jsm: new serial device driver
Wen Xiong wrote: +/* Our in use variables, to enforce 1 open only */ +static int jsm_mgmt_in_use[MAXMGMTDEVICES]; Eliminate MAXMGMTDEVICES + +/* + * jsm_mgmt_open() + * + * Open the mgmt/downld/dpa device + */ +int jsm_mgmt_open(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT((jsm_mgmt_open start.\n)); + + spin_lock_irqsave(jsm_global_lock, lock_flags); + + /* mgmt device */ + if (minor MAXMGMTDEVICES) { + /* Only allow 1 open at a time on mgmt device */ + if (jsm_mgmt_in_use[minor]) { + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + return -EBUSY; + } + jsm_mgmt_in_use[minor]++; An interruptible sleep (semaphore?) is usually preferred to EBUSY. + else { + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + return -ENXIO; + } + + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + + DPR_MGMT((jsm_mgmt_open finish.\n)); + + return 0; +} + +/* + * jsm_mgmt_close() + * + * Open the mgmt/dpa device + */ +int jsm_mgmt_close(struct inode *inode, struct file *file) +{ + unsigned long lock_flags; + unsigned int minor = JSM_MINOR(inode); + + DPR_MGMT((jsm_mgmt_close start.\n)); + + spin_lock_irqsave(jsm_global_lock, lock_flags); + + /* mgmt device */ + if (minor MAXMGMTDEVICES) { + if (jsm_mgmt_in_use[minor]) + jsm_mgmt_in_use[minor] = 0; + } + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + + DPR_MGMT((jsm_mgmt_close finish.\n)); + + return 0; +} + +/* + * jsm_mgmt_ioctl() + * + * ioctl the mgmt/dpa device + */ + +int jsm_mgmt_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +{ + unsigned long lock_flags; + void __user *uarg = (void __user *) arg; + + DPR_MGMT((jsm_mgmt_ioctl start.\n)); + + switch (cmd) { + + case DIGI_GETDD: + { + /* + * This returns the total number of boards + * in the system, as well as driver version + * and has space for a reserved entry + */ + struct digi_dinfo ddi; stack usage + spin_lock_irqsave(jsm_global_lock, lock_flags); + + ddi.dinfo_nboards = jsm_NumBoards; + sprintf(ddi.dinfo_version, %s, 40002438_A-INKERNEL); + + spin_unlock_irqrestore(jsm_global_lock, lock_flags); + + DPR_MGMT((DIGI_GETDD returning numboards: %d version: %s\n, + ddi.dinfo_nboards, ddi.dinfo_version)); + + if (copy_to_user(uarg, ddi, sizeof (ddi))) + return -EFAULT; + + break; + } + + case DIGI_GETBD: + { + int brd; + + struct digi_info di; ditto + if (copy_from_user(brd, uarg, sizeof(int))) + return -EFAULT; + + DPR_MGMT((DIGI_GETBD asking about board: %d\n, brd)); + + if ((brd 0) || (brd jsm_NumBoards) || (jsm_NumBoards == 0)) + return -ENODEV; + + memset(di, 0, sizeof(di)); + + di.info_bdnum = brd; + + spin_lock_irqsave(jsm_Board[brd]-bd_lock, lock_flags); + + di.info_bdtype = jsm_Board[brd]-dpatype; + di.info_bdstate = jsm_Board[brd]-dpastatus; + di.info_ioport = 0; + di.info_physaddr = (ulong) jsm_Board[brd]-membase; + di.info_physsize = (ulong) jsm_Board[brd]-membase - jsm_Board[brd]-membase_end; + if (jsm_Board[brd]-state != BOARD_FAILED) + di.info_nports = jsm_Board[brd]-nasync; + else + di.info_nports = 0; + + spin_unlock_irqrestore(jsm_Board[brd]-bd_lock, lock_flags); + + DPR_MGMT((DIGI_GETBD returning type: %x state: %x ports: %x size: %x\n, + di.info_bdtype, di.info_bdstate, di.info_nports, di.info_physsize)); + + if (copy_to_user(uarg, di, sizeof (di))) + return -EFAULT; + + break; + } + + case DIGI_GET_NI_INFO: + { + struct channel_t *ch; + struct ni_info ni; + ulong lock_flags; + uchar mstat = 0; + uint board = 0; + uint channel = 0; + + if (copy_from_user(ni, uarg, sizeof(struct ni_info))) + return -EFAULT; + + DPR_MGMT((DIGI_GETBD asking about board: %d channel: %d\n, + ni.board, ni.channel)); + + board = ni.board; + channel = ni.channel; + + /* Verify boundaries on board */ + if ((board 0) || (board jsm_NumBoards) || (jsm_NumBoards == 0)) + return -ENODEV; + + /* Verify boundaries on channel */ + if ((channel 0) || (channel jsm_Board[board]-nasync)) + return -ENODEV; + + ch = jsm_Board[board]-channels[channel]; + + if (!ch || ch-magic !=