Re: [01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-19 Thread Kalle Valo
Brian Norris wrote: > If we fail to add an interface in mwifiex_add_virtual_intf(), we might > hit a BUG_ON() in the networking code, because we didn't tear things > down properly. Among the problems: > > (a) when failing to allocate workqueues, we fail to unregister

Re: [01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-19 Thread Kalle Valo
Brian Norris wrote: > If we fail to add an interface in mwifiex_add_virtual_intf(), we might > hit a BUG_ON() in the networking code, because we didn't tear things > down properly. Among the problems: > > (a) when failing to allocate workqueues, we fail to unregister the > netdev before

RE: [PATCH 01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-16 Thread Xinming Hu
el@vger.kernel.org; Dmitry Torokhov; Amitkumar Karwar; Kalle > Valo; linux-wirel...@vger.kernel.org; Doug Anderson; Brian Norris > Subject: [PATCH 01/11] mwifiex: fixup error cases in > mwifiex_add_virtual_intf() > > If we fail to add an interface in mwifiex_add_virtual_intf(), we might h

RE: [PATCH 01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-16 Thread Xinming Hu
el@vger.kernel.org; Dmitry Torokhov; Amitkumar Karwar; Kalle > Valo; linux-wirel...@vger.kernel.org; Doug Anderson; Brian Norris > Subject: [PATCH 01/11] mwifiex: fixup error cases in > mwifiex_add_virtual_intf() > > If we fail to add an interface in mwifiex_add_virtual_intf(), we might h

[PATCH 01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-12 Thread Brian Norris
If we fail to add an interface in mwifiex_add_virtual_intf(), we might hit a BUG_ON() in the networking code, because we didn't tear things down properly. Among the problems: (a) when failing to allocate workqueues, we fail to unregister the netdev before calling free_netdev() (b) even if

[PATCH 01/11] mwifiex: fixup error cases in mwifiex_add_virtual_intf()

2017-05-12 Thread Brian Norris
If we fail to add an interface in mwifiex_add_virtual_intf(), we might hit a BUG_ON() in the networking code, because we didn't tear things down properly. Among the problems: (a) when failing to allocate workqueues, we fail to unregister the netdev before calling free_netdev() (b) even if