Re: [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef

2005-07-23 Thread Stefan Richter 
On 22 Jul, Adrian Bunk wrote:
> drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
> defined
> drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
> defined
> drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
> defined
> drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
> defined

Here is a minimally improved version of the patch. I kept your sign-off.

- - - - - - - - - - - - 8< - - - - - - - - - - - -


sbp2: fix compiler warnings with -Wundef

Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>

Index: linux-2.6.13-rc3/drivers/ieee1394/sbp2.c
===
--- linux-2.6.13-rc3/drivers/ieee1394/sbp2.c(revision 1316)
+++ linux-2.6.13-rc3/drivers/ieee1394/sbp2.c(working copy)
@@ -171,10 +171,12 @@
 
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
 /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
 
+/* increase to 1 for verbose logging, to 2 for even more logging */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
+
 #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
 #define SBP2_ORB_DEBUG(fmt, args...)   HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, 
## args)
 static u32 global_outstanding_command_orbs = 0;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef

2005-07-23 Thread Stefan Richter 
On 22 Jul, Adrian Bunk wrote:
 drivers/ieee1394/sbp2.c:202:5: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
 defined
 drivers/ieee1394/sbp2.c:207:7: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
 defined
 drivers/ieee1394/sbp2.c:2053:6: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
 defined
 drivers/ieee1394/sbp2.c:2623:5: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
 defined

Here is a minimally improved version of the patch. I kept your sign-off.

- - - - - - - - - - - - 8 - - - - - - - - - - - -


sbp2: fix compiler warnings with -Wundef

Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Signed-off-by: Stefan Richter [EMAIL PROTECTED]

Index: linux-2.6.13-rc3/drivers/ieee1394/sbp2.c
===
--- linux-2.6.13-rc3/drivers/ieee1394/sbp2.c(revision 1316)
+++ linux-2.6.13-rc3/drivers/ieee1394/sbp2.c(working copy)
@@ -171,10 +171,12 @@
 
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
 /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
 
+/* increase to 1 for verbose logging, to 2 for even more logging */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
+
 #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
 #define SBP2_ORB_DEBUG(fmt, args...)   HPSB_ERR(sbp2(%s): fmt, __FUNCTION__, 
## args)
 static u32 global_outstanding_command_orbs = 0;


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef

2005-07-22 Thread Adrian Bunk 
This patch fixes the following warnings with -Wundef:

<--  snip  -->

...
  CC  drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
defined
drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
defined
drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
defined
drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not 
defined
...

<--  snip  -->


Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>

--- linux-2.6.13-rc3-mm1-full/drivers/ieee1394/sbp2.c.old   2005-07-22 
18:19:38.0 +0200
+++ linux-2.6.13-rc3-mm1-full/drivers/ieee1394/sbp2.c   2005-07-22 
18:20:32.0 +0200
@@ -171,10 +171,11 @@
 
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
 /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
 
+/* CONFIG_IEEE1394_SBP2_DEBUG: 0-2 */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
 #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
 #define SBP2_ORB_DEBUG(fmt, args...)   HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, 
## args)
 static u32 global_outstanding_command_orbs = 0;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef

2005-07-22 Thread Adrian Bunk 
This patch fixes the following warnings with -Wundef:

--  snip  --

...
  CC  drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c:202:5: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
defined
drivers/ieee1394/sbp2.c:207:7: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
defined
drivers/ieee1394/sbp2.c:2053:6: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
defined
drivers/ieee1394/sbp2.c:2623:5: warning: CONFIG_IEEE1394_SBP2_DEBUG is not 
defined
...

--  snip  --


Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

--- linux-2.6.13-rc3-mm1-full/drivers/ieee1394/sbp2.c.old   2005-07-22 
18:19:38.0 +0200
+++ linux-2.6.13-rc3-mm1-full/drivers/ieee1394/sbp2.c   2005-07-22 
18:20:32.0 +0200
@@ -171,10 +171,11 @@
 
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
 /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
 
+/* CONFIG_IEEE1394_SBP2_DEBUG: 0-2 */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
 #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
 #define SBP2_ORB_DEBUG(fmt, args...)   HPSB_ERR(sbp2(%s): fmt, __FUNCTION__, 
## args)
 static u32 global_outstanding_command_orbs = 0;

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/