Every file should #include the headers containing the prototypes for
its global functions (in this case for scsi_schedule_eh()).
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c.old 2007-07-28
17:10:48.0 +0200
+++
Every file should #include the headers containing the prototypes for
its global functions (in this case for scsi_schedule_eh()).
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
--- linux-2.6.23-rc1-mm1/drivers/scsi/scsi_error.c.old 2007-07-28
17:10:48.0 +0200
+++
On Wed, Nov 29, 2006 at 06:16:24AM -0700, Matthew Wilcox wrote:
> On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
> > +#include "scsi_transport_api.h"
>
> scsi_transport_api.h is a weird little file. It's not included by
> anything in the drivers/scsi directory, only
>
On Wed, Nov 29, 2006 at 06:16:24AM -0700, Matthew Wilcox wrote:
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
+#include scsi_transport_api.h
scsi_transport_api.h is a weird little file. It's not included by
anything in the drivers/scsi directory, only
On Wed, Nov 29, 2006 at 09:13:35AM -0500, James Smart wrote:
> would it only go in include/scsi if it intends to be an exported
> api for LLDD's and/or user apps ? and stay in drivers/scsi if its
> an internal api within the scsi subsystem itself ?
It isn't clear to me that's the intended use of
Matthew Wilcox wrote:
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
+#include "scsi_transport_api.h"
scsi_transport_api.h is a weird little file. It's not included by
anything in the drivers/scsi directory, only
drivers/scsi/libsas/sas_scsi_host.c:#include
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
> +#include "scsi_transport_api.h"
scsi_transport_api.h is a weird little file. It's not included by
anything in the drivers/scsi directory, only
drivers/scsi/libsas/sas_scsi_host.c:#include "../scsi_transport_api.h"
Every file should #include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
--- linux-2.6.19-rc6-mm2/drivers/scsi/scsi_error.c.old 2006-11-29
09:58:41.0 +0100
+++ linux-2.6.19-rc6-mm2/drivers/scsi/scsi_error.c
Every file should #include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
--- linux-2.6.19-rc6-mm2/drivers/scsi/scsi_error.c.old 2006-11-29
09:58:41.0 +0100
+++ linux-2.6.19-rc6-mm2/drivers/scsi/scsi_error.c 2006-11-29
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
+#include scsi_transport_api.h
scsi_transport_api.h is a weird little file. It's not included by
anything in the drivers/scsi directory, only
drivers/scsi/libsas/sas_scsi_host.c:#include ../scsi_transport_api.h
Matthew Wilcox wrote:
On Wed, Nov 29, 2006 at 11:04:22AM +0100, Adrian Bunk wrote:
+#include scsi_transport_api.h
scsi_transport_api.h is a weird little file. It's not included by
anything in the drivers/scsi directory, only
drivers/scsi/libsas/sas_scsi_host.c:#include
On Wed, Nov 29, 2006 at 09:13:35AM -0500, James Smart wrote:
would it only go in include/scsi if it intends to be an exported
api for LLDD's and/or user apps ? and stay in drivers/scsi if its
an internal api within the scsi subsystem itself ?
It isn't clear to me that's the intended use of
12 matches
Mail list logo
