Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: > In the Linux kernel, it's more common to put such header dependencies > for header files into the C files, but if the ACPI people agree a patch > to add the #include to acpi_bus.h is the other possble > correct solution for this issue. With the exception of linux/config.h. Do a 'make configcheck' and it'll tell you where linux/config.h is missing and where it shouldn't be. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
On Sat, Apr 16, 2005 at 04:38:52AM +0200, Adrian Bunk wrote: In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include linux/config.h to acpi_bus.h is the other possble correct solution for this issue. With the exception of linux/config.h. Do a 'make configcheck' and it'll tell you where linux/config.h is missing and where it shouldn't be. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
>> drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.
>
> 8250_acpi.c #include's which requires config.h .
>
> In the Linux kernel, it's more common to put such header dependencies
> for header files into the C files, but if the ACPI people agree a patch
I disagree with this assertion. Try
grep -l linux/config.h include/linux/*.h | wc -l
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote: > On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > > > This patch fixes the following warning: > > > CC drivers/serial/8250_acpi.o > > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function > > `acpi_register_gsi' > > > --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old > > +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c > > > +#include > > drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. 8250_acpi.c #include's which requires config.h . In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include to acpi_bus.h is the other possble correct solution for this issue. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: > This patch fixes the following warning: > CC drivers/serial/8250_acpi.o > drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': > drivers/serial/8250_acpi.c:51: warning: implicit declaration of function > `acpi_register_gsi' > --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old > +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c > +#include drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/serial/8250_acpi.c: fix a warning
This patch fixes the following warning: <-- snip --> ... CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' ... <-- snip --> This patch was already ACK'ed by Bjorn Helgaas. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 5 Apr 2005 --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old2005-04-05 15:58:59.0 +0200 +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c2005-04-05 16:01:47.0 +0200 @@ -9,6 +9,7 @@ * (at your option) any later version. */ +#include #include #include #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[2.6 patch] drivers/serial/8250_acpi.c: fix a warning
This patch fixes the following warning: -- snip -- ... CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' ... -- snip -- This patch was already ACK'ed by Bjorn Helgaas. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 5 Apr 2005 --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old2005-04-05 15:58:59.0 +0200 +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c2005-04-05 16:01:47.0 +0200 @@ -9,6 +9,7 @@ * (at your option) any later version. */ +#include linux/config.h #include linux/acpi.h #include linux/init.h #include linux/module.h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: This patch fixes the following warning: CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c +#include linux/config.h drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
On Fri, Apr 15, 2005 at 08:10:54PM +0400, Alexey Dobriyan wrote: On Fri, 15 Apr 2005 17:10:53 +0200, Adrian Bunk wrote: This patch fixes the following warning: CC drivers/serial/8250_acpi.o drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq': drivers/serial/8250_acpi.c:51: warning: implicit declaration of function `acpi_register_gsi' --- linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c.old +++ linux-2.6.12-rc2-mm1-full/drivers/serial/8250_acpi.c +#include linux/config.h drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols. 8250_acpi.c #include's acpi/acpi_bus.h which requires config.h . In the Linux kernel, it's more common to put such header dependencies for header files into the C files, but if the ACPI people agree a patch to add the #include linux/config.h to acpi_bus.h is the other possble correct solution for this issue. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [2.6 patch] drivers/serial/8250_acpi.c: fix a warning
Adrian Bunk [EMAIL PROTECTED] wrote:
drivers/serial/8250_acpi.c doesn't use CONFIG_ symbols.
8250_acpi.c #include's acpi/acpi_bus.h which requires config.h .
In the Linux kernel, it's more common to put such header dependencies
for header files into the C files, but if the ACPI people agree a patch
I disagree with this assertion. Try
grep -l linux/config.h include/linux/*.h | wc -l
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
