Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static

2005-03-16 Thread David S. Miller
On Thu, 17 Mar 2005 02:08:21 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > inet_peer_unused_tailp might be referenced from other files via > inetpeer.h, but inet_peer_unused_head isn't referenced directly from > other files. I misread your patch, I thought you were marking both as static. My

[2.6 patch] net/ipv4/inetpeer.c: make a struct static

2005-03-16 Thread Adrian Bunk
On Wed, Mar 16, 2005 at 02:54:48PM -0800, David S. Miller wrote: > On Wed, 16 Mar 2005 14:53:43 -0800 > "David S. Miller" <[EMAIL PROTECTED]> wrote: > > > On Tue, 15 Mar 2005 15:44:08 +0100 > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > This patch makes a needlessly global struct static. >

Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static

2005-03-16 Thread David S. Miller
On Wed, 16 Mar 2005 14:53:43 -0800 "David S. Miller" <[EMAIL PROTECTED]> wrote: > On Tue, 15 Mar 2005 15:44:08 +0100 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch makes a needlessly global struct static. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > You need to also kil

Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static

2005-03-16 Thread David S. Miller
On Tue, 15 Mar 2005 15:44:08 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch makes a needlessly global struct static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> You need to also kill the externs in net/inetpeer.h Please fix this up and resubmit. Thanks Adrian. - To unsubscrib

[2.6 patch] net/ipv4/inetpeer.c: make a struct static

2005-03-15 Thread Adrian Bunk
This patch makes a needlessly global struct static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.11-mm3-full/net/ipv4/inetpeer.c.old 2005-03-15 13:29:32.0 +0100 +++ linux-2.6.11-mm3-full/net/ipv4/inetpeer.c 2005-03-15 13:30:13.0 +0100 @@ -92,9 +92,9 @@ i