Re: [3/3] 2.6.23-rc6: known regressions v2
On Mon, 2007-09-17 at 23:03 +0200, Thomas Gleixner wrote: > On Mon, 2007-09-17 at 22:51 +0200, Arkadiusz Miskiewicz wrote: > > > > clockevents: fix resume logic > > > > > > Linus pulled a series of patches which are addressing this issue into > > > his tree yesterday. Can you please retest against current git ? > > > > Looks like the problem is fixed in current git for me. Thanks! > > Thanks for testing. I can confirm that the problem is fixed for me too in current git when using the free avivo driver (with the binary only fglrx driver the machine just hangs on resume or even sometimes on sleep). So it might be worth to purposely keep that such that people transit from fglrx to the free avivo/radeonhd drivers. Anyway s2ram with avivo takes 2-3 sec to suspend and 4-5 for resume (when fglrx worked it was more in the 10-20 secs). Soeren. -- Sometimes, there's a moment as you're waking, when you become aware of the real world around you, but you're still dreaming. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [3/3] 2.6.23-rc6: known regressions v2
On Mon, 2007-09-17 at 22:51 +0200, Arkadiusz Miskiewicz wrote: > > > clockevents: fix resume logic > > > > Linus pulled a series of patches which are addressing this issue into > > his tree yesterday. Can you please retest against current git ? > > Looks like the problem is fixed in current git for me. Thanks! Thanks for testing. > ps. The description about vaio not resuming without key pressing matches what > I was seeing here on thinkpad z60m, too. Sigh, there were several subtle reason why you would need to press keys during resume. The one you are referring to is the one which is the most obscure. It would be nice if you could revert that particular one and check whether it still works on your box. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [3/3] 2.6.23-rc6: known regressions v2
On Monday 17 of September 2007, Thomas Gleixner wrote: > On Mon, 2007-09-17 at 21:44 +0200, Arkadiusz Miskiewicz wrote: > > On Saturday 15 of September 2007, Rafael J. Wysocki wrote: > > > On Saturday, 15 September 2007 04:29, Michal Piotrowski wrote: > > > > Subject : resume from ram much slower > > > > References : http://lkml.org/lkml/2007/8/10/275 > > > > Last known good : 2.6.23-rc1 ? > > > > Submitter : Arkadiusz Miskiewicz <[EMAIL PROTECTED]> > > > > Caused-By : ? > > > > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> > > > > Status : problem is being debugged > > > > > > Unresolved, bisection might be helpful. > > > > Took 16 hours of bisecting and playing with stuff. > > > > It looks like the problematic patch is > > 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6. bisection was hard and I'm 95% > > sure that this is the problematic patch. I'm currently using 2.6.23-rc6 > > with this reverted and so far resume works as it should. > > > > > > commit 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 > > Author: Thomas Gleixner <[EMAIL PROTECTED]> > > Date: Sat Jul 21 04:37:34 2007 -0700 > > > > clockevents: fix resume logic > > Linus pulled a series of patches which are addressing this issue into > his tree yesterday. Can you please retest against current git ? Looks like the problem is fixed in current git for me. Thanks! ps. The description about vaio not resuming without key pressing matches what I was seeing here on thinkpad z60m, too. > tglx -- Arkadiusz MiśkiewiczPLD/Linux Team arekm / maven.plhttp://ftp.pld-linux.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [3/3] 2.6.23-rc6: known regressions v2
On Mon, 2007-09-17 at 21:44 +0200, Arkadiusz Miskiewicz wrote: > On Saturday 15 of September 2007, Rafael J. Wysocki wrote: > > On Saturday, 15 September 2007 04:29, Michal Piotrowski wrote: > > > > Subject : resume from ram much slower > > > References : http://lkml.org/lkml/2007/8/10/275 > > > Last known good : 2.6.23-rc1 ? > > > Submitter : Arkadiusz Miskiewicz <[EMAIL PROTECTED]> > > > Caused-By : ? > > > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> > > > Status : problem is being debugged > > > > Unresolved, bisection might be helpful. > > Took 16 hours of bisecting and playing with stuff. > > It looks like the problematic patch is > 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6. > bisection was hard and I'm 95% sure that this is the problematic patch. > I'm currently using 2.6.23-rc6 with this reverted and so far resume works as > it should. > > > commit 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6 > Author: Thomas Gleixner <[EMAIL PROTECTED]> > Date: Sat Jul 21 04:37:34 2007 -0700 > > clockevents: fix resume logic Linus pulled a series of patches which are addressing this issue into his tree yesterday. Can you please retest against current git ? tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [3/3] 2.6.23-rc6: known regressions v2
On Saturday 15 of September 2007, Rafael J. Wysocki wrote:
> On Saturday, 15 September 2007 04:29, Michal Piotrowski wrote:
> > Subject : resume from ram much slower
> > References : http://lkml.org/lkml/2007/8/10/275
> > Last known good : 2.6.23-rc1 ?
> > Submitter : Arkadiusz Miskiewicz <[EMAIL PROTECTED]>
> > Caused-By : ?
> > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]>
> > Status : problem is being debugged
>
> Unresolved, bisection might be helpful.
Took 16 hours of bisecting and playing with stuff.
It looks like the problematic patch is 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6.
bisection was hard and I'm 95% sure that this is the problematic patch.
I'm currently using 2.6.23-rc6 with this reverted and so far resume works as it
should.
commit 18de5bc4c1f1f1fa5e14f354a7603bd6e9d4e3b6
Author: Thomas Gleixner <[EMAIL PROTECTED]>
Date: Sat Jul 21 04:37:34 2007 -0700
clockevents: fix resume logic
We need to make sure, that the clockevent devices are resumed, before
the tick is resumed. The current resume logic does not guarantee this.
Add CLOCK_EVT_MODE_RESUME and call the set mode functions of the clock
event devices before resuming the tick / oneshot functionality.
Fixup the existing users.
Thanks to Nigel Cunningham for tracking down a long standing thinko,
which affected the jinxed VAIO.
[EMAIL PROTECTED]: xen build fix]
Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
Cc: john stultz <[EMAIL PROTECTED]>
Cc: Rusty Russell <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Linus Torvalds <[EMAIL PROTECTED]>
diff --git a/arch/arm/mach-davinci/time.c b/arch/arm/mach-davinci/time.c
index 4d8425d..e96a3dc 100644
--- a/arch/arm/mach-davinci/time.c
+++ b/arch/arm/mach-davinci/time.c
@@ -285,6 +285,8 @@ static void davinci_set_mode(enum clock_event_mode mode,
case CLOCK_EVT_MODE_SHUTDOWN:
t->opts = TIMER_OPTS_DISABLED;
break;
+ case CLOCK_EVT_MODE_RESUME:
+ break;
}
}
diff --git a/arch/arm/mach-imx/time.c b/arch/arm/mach-imx/time.c
index 010f6fa..d86d124 100644
--- a/arch/arm/mach-imx/time.c
+++ b/arch/arm/mach-imx/time.c
@@ -159,6 +159,7 @@ static void imx_set_mode(enum clock_event_mode mode, struct
clock_event_device *
break;
case CLOCK_EVT_MODE_SHUTDOWN:
case CLOCK_EVT_MODE_UNUSED:
+ case CLOCK_EVT_MODE_RESUME:
/* Left event sources disabled, no more interrupts appears */
break;
}
diff --git a/arch/arm/mach-ixp4xx/common.c b/arch/arm/mach-ixp4xx/common.c
index 8112f72..23e7fba 100644
--- a/arch/arm/mach-ixp4xx/common.c
+++ b/arch/arm/mach-ixp4xx/common.c
@@ -459,6 +459,8 @@ static void ixp4xx_set_mode(enum clock_event_mode mode,
default:
osrt = opts = 0;
break;
+ case CLOCK_EVT_MODE_RESUME:
+ break;
}
*IXP4XX_OSRT1 = osrt | opts;
diff --git a/arch/arm/mach-omap1/time.c b/arch/arm/mach-omap1/time.c
index 3705d20..237651e 100644
--- a/arch/arm/mach-omap1/time.c
+++ b/arch/arm/mach-omap1/time.c
@@ -156,6 +156,7 @@ static void omap_mpu_set_mode(enum clock_event_mode mode,
break;
case CLOCK_EVT_MODE_UNUSED:
case CLOCK_EVT_MODE_SHUTDOWN:
+ case CLOCK_EVT_MODE_RESUME:
break;
}
}
diff --git a/arch/arm/plat-omap/timer32k.c b/arch/arm/plat-omap/timer32k.c
index 2feceec..b0af014 100644
--- a/arch/arm/plat-omap/timer32k.c
+++ b/arch/arm/plat-omap/timer32k.c
@@ -156,6 +156,8 @@ static void omap_32k_timer_set_mode(enum clock_event_mode
mode,
case CLOCK_EVT_MODE_SHUTDOWN:
omap_32k_timer_stop();
break;
+ case CLOCK_EVT_MODE_RESUME:
+ break;
}
}
diff --git a/arch/i386/kernel/apic.c b/arch/i386/kernel/apic.c
index 67824f3..610f44b 100644
--- a/arch/i386/kernel/apic.c
+++ b/arch/i386/kernel/apic.c
@@ -263,6 +263,9 @@ static void lapic_timer_setup(enum clock_event_mode mode,
v |= (APIC_LVT_MASKED | LOCAL_TIMER_VECTOR);
apic_write_around(APIC_LVTT, v);
break;
+ case CLOCK_EVT_MODE_RESUME:
+ /* Nothing to do here */
+ break;
}
local_irq_restore(flags);
diff --git a/arch/i386/kernel/hpet.c b/arch/i386/kernel/hpet.c
index 17d7345..cfbf792 100644
--- a/arch/i386/kernel/hpet.c
+++ b/arch/i386/kernel/hpet.c
@@ -187,6 +187,10 @@ static void hpet_set_mode(enum clock_event_mode mode,
cfg &= ~HPET_TN_ENABLE;
hpet_writel(cfg, HPET_T0_CFG);
break;
+
+ case CLOCK_EVT_MODE_RESUME:
+ hpet_enable_int();
+ break;
}
}
@@ -217,6 +221,7 @@ static struct clocksource clocksource_hpet = {
.mask = HPET_MASK,
.sh
Re: [3/3] 2.6.23-rc6: known regressions v2
On Saturday, 15 September 2007 04:29, Michal Piotrowski wrote: > Hi all, > > Here is a list of some known regressions in 2.6.23-rc6. > > Feel free to add new regressions/remove fixed etc. > http://kernelnewbies.org/known_regressions > > List of Aces > > NameRegressions fixed since 21-Jun-2007 > Adrian Bunk10 > Andi Kleen 7 > Linus Torvalds 6 > Alan Stern 5 > Hugh Dickins 5 > Trond Myklebust5 > Andrew Morton 4 > David S. Miller4 > Al Viro3 > Alexey Starikovskiy3 > Cornelia Huck 3 > Jens Axboe 3 > Stephen Hemminger 3 > Tejun Heo 3 > > > > Power management > > Subject : powersaving degradation, (time spend in C0 goes up after a > while) > References : http://lkml.org/lkml/2007/9/2/142 > Last known good : ? > Submitter : Christian Leber <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : ? > Status : unknown > > Subject : something broke resume from s2ram on mbp c1d (??? :)) > References : http://lkml.org/lkml/2007/8/28/67 > Last known good : 2.6.23-rc3 > Submitter : Soeren Sonnenburg <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> > Status : unknown Soeren said he would bisect, but I guess he didn't have the time. > Subject : 2.6.23-rc2 swsusp, suddenly increased uptime > References : http://lkml.org/lkml/2007/8/12/249 > Last known good : ? > Submitter : Thomas Voegtle <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> > Status : problem is being debugged This is hard to reproduce, AFAICS, and unreproducible on any boxes I have access to. > Subject : resume from ram much slower > References : http://lkml.org/lkml/2007/8/10/275 > Last known good : 2.6.23-rc1 ? > Submitter : Arkadiusz Miskiewicz <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> > Status : problem is being debugged Unresolved, bisection might be helpful. Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [3/3] 2.6.23-rc6: known regressions v2
Hi all, Here is a list of some known regressions in 2.6.23-rc6. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk10 Andi Kleen 7 Linus Torvalds 6 Alan Stern 5 Hugh Dickins 5 Trond Myklebust5 Andrew Morton 4 David S. Miller4 Al Viro3 Alexey Starikovskiy3 Cornelia Huck 3 Jens Axboe 3 Stephen Hemminger 3 Tejun Heo 3 Power management Subject : powersaving degradation, (time spend in C0 goes up after a while) References : http://lkml.org/lkml/2007/9/2/142 Last known good : ? Submitter : Christian Leber <[EMAIL PROTECTED]> Caused-By : ? Handled-By : ? Status : unknown Subject : something broke resume from s2ram on mbp c1d (??? :)) References : http://lkml.org/lkml/2007/8/28/67 Last known good : 2.6.23-rc3 Submitter : Soeren Sonnenburg <[EMAIL PROTECTED]> Caused-By : ? Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> Status : unknown Subject : 2.6.23-rc2 swsusp, suddenly increased uptime References : http://lkml.org/lkml/2007/8/12/249 Last known good : ? Submitter : Thomas Voegtle <[EMAIL PROTECTED]> Caused-By : ? Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> Status : problem is being debugged Subject : resume from ram much slower References : http://lkml.org/lkml/2007/8/10/275 Last known good : 2.6.23-rc1 ? Submitter : Arkadiusz Miskiewicz <[EMAIL PROTECTED]> Caused-By : ? Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]> Status : problem is being debugged USB Subject : usb 1-1: device not accepting address 2, error -62 References : http://lkml.org/lkml/2007/9/14/302 Last known good : ? Submitter : Christian Volkmann <[EMAIL PROTECTED]> Caused-By : ? Handled-By : ? Status : unknown Farewell! Michal -- LOGOUT http://www.stardust.webpages.pl/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
