Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Thu, Oct 27, 2016 at 10:02:10PM -0400, Al Viro wrote: > ... and frankly, backporting 548acf19234d would be my preference. It's a bit > more intrusive than needed (_ASM_EXTABLE_FAULT is used only in > memcpy_mcsafe(), > which is used only by pmem and it's the only reason for passing the trap >

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Thu, Oct 27, 2016 at 10:02:10PM -0400, Al Viro wrote: > ... and frankly, backporting 548acf19234d would be my preference. It's a bit > more intrusive than needed (_ASM_EXTABLE_FAULT is used only in > memcpy_mcsafe(), > which is used only by pmem and it's the only reason for passing the trap >

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 08:49:58PM +0100, Al Viro wrote: > On Fri, Oct 28, 2016 at 11:21:24AM -0700, Linus Torvalds wrote: > > > End result: either commit 1c109fabbd51 shouldn't be backported (it's > > really not that important - if people properly check the exception > > error results it

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 08:49:58PM +0100, Al Viro wrote: > On Fri, Oct 28, 2016 at 11:21:24AM -0700, Linus Torvalds wrote: > > > End result: either commit 1c109fabbd51 shouldn't be backported (it's > > really not that important - if people properly check the exception > > error results it

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 11:21:24AM -0700, Linus Torvalds wrote: > End result: either commit 1c109fabbd51 shouldn't be backported (it's > really not that important - if people properly check the exception > error results it shouldn't matter), or you need to also backport > 548acf19234d as Al

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 11:21:24AM -0700, Linus Torvalds wrote: > End result: either commit 1c109fabbd51 shouldn't be backported (it's > really not that important - if people properly check the exception > error results it shouldn't matter), or you need to also backport > 548acf19234d as Al

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 12:40:33PM -0400, Joe Korty wrote: > Backporting 548acf19234d to 4.1.35 does indeed fix the > issue. However, it is not clear to my _why_ it works, > so it might be better that someone else push the backport > to stable. Because the trick used in fixup_exception() prior

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 12:40:33PM -0400, Joe Korty wrote: > Backporting 548acf19234d to 4.1.35 does indeed fix the > issue. However, it is not clear to my _why_ it works, > so it might be better that someone else push the backport > to stable. Because the trick used in fixup_exception() prior

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

rea On Fri, Oct 28, 2016 at 9:40 AM, Joe Korty wrote: > > Backporting 548acf19234d to 4.1.35 does indeed fix the > issue. However, it is not clear to my _why_ it works, > so it might be better that someone else push the backport > to stable. The problem is that the

Re: [4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

rea On Fri, Oct 28, 2016 at 9:40 AM, Joe Korty wrote: > > Backporting 548acf19234d to 4.1.35 does indeed fix the > issue. However, it is not clear to my _why_ it works, > so it might be better that someone else push the backport > to stable. The problem is that the old _ASM_EXTABLE_EXT

[4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 01:03:55AM +0100, Al Viro wrote: > On Thu, Oct 27, 2016 at 03:32:10PM -0400, Joe Korty wrote: [oops in 4.1.35, bisected to 319fe1151940] > > The following test program can be used to trigger the problem: > > > > /* gcc -m32 c.c -o c */ > > #define _GNU_SOURCE > > #include

[4.1 backport trouble] Re: BUGreport: fix minor infoleak in get_user_ex()

On Fri, Oct 28, 2016 at 01:03:55AM +0100, Al Viro wrote: > On Thu, Oct 27, 2016 at 03:32:10PM -0400, Joe Korty wrote: [oops in 4.1.35, bisected to 319fe1151940] > > The following test program can be used to trigger the problem: > > > > /* gcc -m32 c.c -o c */ > > #define _GNU_SOURCE > > #include