Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra
On Wed, 2019-08-14 at 20:42 -0700, Bart Van Assche wrote: > On 8/14/19 10:18 AM, Abdul Haleem wrote: > > On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote: > >> On 8/14/19 9:52 AM, Abdul Haleem wrote: > >>> Greeting's > >>> > >>> Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning > >>> on my powerpc power 8 lpar > >>> > >>> The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: > >>> Complain if sp->done() is not...) > >>> > >>> boot logs: > >>> > >>> WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 > >> > >> Hi Abdul, > >> > >> Thank you for having reported this. Is that the only warning reported on > >> your setup by the qla2xxx > >> driver? If that warning is commented out, does the qla2xxx driver work as > >> expected? > > > > boot warning did not show up when the commit is reverted. > > > > should I comment out only the WARN_ON_ONCE() which is causing the issue, > > and not the other one ? > > Yes please. Commit 88263208 introduced five kernel warnings but I think > only one of these should be removed again, e.g. as follows: > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index cd39ac18c5fd..d81b5ecce24b 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct > rsp_que *rsp, void *pkt) > > if (rsp->status_srb == NULL) > sp->done(sp, res); > - else > - WARN_ON_ONCE(true); > } > > /** Applying above patch on system boots fine. i.e no warnings pop up when keeping all WARN_ON_ONCE() except above one. Reported-and-Tested-by: Abdul Haleem -- Regard's Abdul Haleem IBM Linux Technology Centre
Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra
On 8/14/19 10:18 AM, Abdul Haleem wrote: On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote: On 8/14/19 9:52 AM, Abdul Haleem wrote: Greeting's Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on my powerpc power 8 lpar The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...) boot logs: WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 Hi Abdul, Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx driver? If that warning is commented out, does the qla2xxx driver work as expected? boot warning did not show up when the commit is reverted. should I comment out only the WARN_ON_ONCE() which is causing the issue, and not the other one ? Yes please. Commit 88263208 introduced five kernel warnings but I think only one of these should be removed again, e.g. as follows: diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index cd39ac18c5fd..d81b5ecce24b 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) if (rsp->status_srb == NULL) sp->done(sp, res); - else - WARN_ON_ONCE(true); } /**
Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra
On 8/14/19 9:52 AM, Abdul Haleem wrote: > Greeting's > > Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on > my powerpc power 8 lpar > > The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain > if sp->done() is not...) > > boot logs: > > WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 Hi Abdul, Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx driver? If that warning is commented out, does the qla2xxx driver work as expected? Thanks, Bart.
Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra
On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote: > On 8/14/19 9:52 AM, Abdul Haleem wrote: > > Greeting's > > > > Today's linux-next kernel (5.3.0-rc4-next-20190813) booted with warning on > > my powerpc power 8 lpar > > > > The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: > > Complain if sp->done() is not...) > > > > boot logs: > > > > WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 > > Hi Abdul, > > Thank you for having reported this. Is that the only warning reported on your > setup by the qla2xxx > driver? If that warning is commented out, does the qla2xxx driver work as > expected? boot warning did not show up when the commit is reverted. should I comment out only the WARN_ON_ONCE() which is causing the issue, and not the other one ? -- Regard's Abdul Haleem IBM Linux Technology Centre
