Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-23 Thread NeilBrown
On Wed, Aug 22 2018, NeilBrown wrote: > > Oh dear. > nfs4_alloc_lockdata contains: > memcpy(>fl, fl, sizeof(p->fl)); > > so any list_heads that are valid in fl will be invalid in p->fl. > > Maybe I should initialize the relevant list_heads at the start of wait > functions. > I should look

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-23 Thread NeilBrown
On Wed, Aug 22 2018, NeilBrown wrote: > > Oh dear. > nfs4_alloc_lockdata contains: > memcpy(>fl, fl, sizeof(p->fl)); > > so any list_heads that are valid in fl will be invalid in p->fl. > > Maybe I should initialize the relevant list_heads at the start of wait > functions. > I should look

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-21 Thread NeilBrown
On Tue, Aug 21 2018, Jeff Layton wrote: > On Tue, 2018-08-21 at 15:11 +1000, NeilBrown wrote: >> On Thu, Aug 16 2018, NeilBrown wrote: >> >> > On Wed, Aug 15 2018, Jeff Layton wrote: >> > >> > > On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >> > > > Hi, >> > > > >> > > > Bisect

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-21 Thread NeilBrown
On Tue, Aug 21 2018, Jeff Layton wrote: > On Tue, 2018-08-21 at 15:11 +1000, NeilBrown wrote: >> On Thu, Aug 16 2018, NeilBrown wrote: >> >> > On Wed, Aug 15 2018, Jeff Layton wrote: >> > >> > > On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >> > > > Hi, >> > > > >> > > > Bisect

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-21 Thread Jeff Layton
On Tue, 2018-08-21 at 15:11 +1000, NeilBrown wrote: > On Thu, Aug 16 2018, NeilBrown wrote: > > > On Wed, Aug 15 2018, Jeff Layton wrote: > > > > > On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: > > > > Hi, > > > > > > > > Bisect pointed commit

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-21 Thread Jeff Layton
On Tue, 2018-08-21 at 15:11 +1000, NeilBrown wrote: > On Thu, Aug 16 2018, NeilBrown wrote: > > > On Wed, Aug 15 2018, Jeff Layton wrote: > > > > > On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: > > > > Hi, > > > > > > > > Bisect pointed commit

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-20 Thread NeilBrown
On Thu, Aug 16 2018, NeilBrown wrote: > On Wed, Aug 15 2018, Jeff Layton wrote: > >> On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d >>> ("fs/locks: allow a lock request to block other requests.") to

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-20 Thread NeilBrown
On Thu, Aug 16 2018, NeilBrown wrote: > On Wed, Aug 15 2018, Jeff Layton wrote: > >> On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d >>> ("fs/locks: allow a lock request to block other requests.") to

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread NeilBrown
On Wed, Aug 15 2018, Jeff Layton wrote: > On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >> Hi, >> >> Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d >> ("fs/locks: allow a lock request to block other requests.") to failure >> boot of NFSv4 with root on several

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread NeilBrown
On Wed, Aug 15 2018, Jeff Layton wrote: > On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: >> Hi, >> >> Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d >> ("fs/locks: allow a lock request to block other requests.") to failure >> boot of NFSv4 with root on several

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread Jeff Layton
On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: > Hi, > > Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d > ("fs/locks: allow a lock request to block other requests.") to failure > boot of NFSv4 with root on several boards. > > Log is here: >

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread Jeff Layton
On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: > Hi, > > Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d > ("fs/locks: allow a lock request to block other requests.") to failure > boot of NFSv4 with root on several boards. > > Log is here: >

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread Jeff Layton
On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: > Hi, > > Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d > ("fs/locks: allow a lock request to block other requests.") to failure > boot of NFSv4 with root on several boards. > > Log is here: >

Re: [BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread Jeff Layton
On Wed, 2018-08-15 at 14:28 +0200, Krzysztof Kozlowski wrote: > Hi, > > Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d > ("fs/locks: allow a lock request to block other requests.") to failure > boot of NFSv4 with root on several boards. > > Log is here: >

[BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread Krzysztof Kozlowski
Hi, Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d ("fs/locks: allow a lock request to block other requests.") to failure boot of NFSv4 with root on several boards. Log is here: https://krzk.eu/#/builders/21/builds/836/steps/12/logs/serial0 With several errors: kernel BUG at

[BUG][BISECT] NFSv4 root failures after "fs/locks: allow a lock request to block other requests."

2018-08-15 Thread Krzysztof Kozlowski
Hi, Bisect pointed commit ce3147990450a68b3f549088b30f087742a08b5d ("fs/locks: allow a lock request to block other requests.") to failure boot of NFSv4 with root on several boards. Log is here: https://krzk.eu/#/builders/21/builds/836/steps/12/logs/serial0 With several errors: kernel BUG at