Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Tony Luck
On Thu, Aug 15, 2013 at 5:33 PM, Linus Torvalds wrote: > I'll probably delay committing it until tomorrow, in the hope that > somebody using one of the other architectures will at least ack that > it compiles. I'm re-attaching the patch (with the two "logn" -> "long" > fixes) just to encourage

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Peter Zijlstra
On Fri, Aug 16, 2013 at 01:00:31PM +0200, Michal Hocko wrote: > I was thinking about teaching __tlb_remove_page to update the range > automatically from the given address. The mmu_gather unification stuff I had did it differently still: http://permalink.gmane.org/gmane.linux.kernel.mm/81287

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Michal Hocko
On Thu 15-08-13 17:33:28, Linus Torvalds wrote: > On Thu, Aug 15, 2013 at 4:05 PM, Ben Tebulin wrote: > > > >> Ben, please test. I'm worried that the problem you see is something > >> even more fundamentally wrong with the whole "oops, must flush in the > >> middle" logic, but I'm _hoping_ this

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread richard -rw- weinberger
On Fri, Aug 16, 2013 at 2:33 AM, Linus Torvalds wrote: > I'll probably delay committing it until tomorrow, in the hope that > somebody using one of the other architectures will at least ack that > it compiles. I'm re-attaching the patch (with the two "logn" -> "long" > fixes) just to encourage

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Stephen Rothwell
Hi Linus, On Thu, 15 Aug 2013 17:33:28 -0700 Linus Torvalds wrote: > > I'll probably delay committing it until tomorrow, in the hope that > somebody using one of the other architectures will at least ack that > it compiles. I'm re-attaching the patch (with the two "logn" -> "long" > fixes) just

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Stephen Rothwell
Hi Linus, On Thu, 15 Aug 2013 17:33:28 -0700 Linus Torvalds torva...@linux-foundation.org wrote: I'll probably delay committing it until tomorrow, in the hope that somebody using one of the other architectures will at least ack that it compiles. I'm re-attaching the patch (with the two logn

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread richard -rw- weinberger
On Fri, Aug 16, 2013 at 2:33 AM, Linus Torvalds torva...@linux-foundation.org wrote: I'll probably delay committing it until tomorrow, in the hope that somebody using one of the other architectures will at least ack that it compiles. I'm re-attaching the patch (with the two logn - long fixes)

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Michal Hocko
On Thu 15-08-13 17:33:28, Linus Torvalds wrote: On Thu, Aug 15, 2013 at 4:05 PM, Ben Tebulin tebu...@googlemail.com wrote: Ben, please test. I'm worried that the problem you see is something even more fundamentally wrong with the whole oops, must flush in the middle logic, but I'm

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Peter Zijlstra
On Fri, Aug 16, 2013 at 01:00:31PM +0200, Michal Hocko wrote: I was thinking about teaching __tlb_remove_page to update the range automatically from the given address. The mmu_gather unification stuff I had did it differently still: http://permalink.gmane.org/gmane.linux.kernel.mm/81287

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-16 Thread Tony Luck
On Thu, Aug 15, 2013 at 5:33 PM, Linus Torvalds torva...@linux-foundation.org wrote: I'll probably delay committing it until tomorrow, in the hope that somebody using one of the other architectures will at least ack that it compiles. I'm re-attaching the patch (with the two logn - long fixes)

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-15 Thread Linus Torvalds
On Thu, Aug 15, 2013 at 4:05 PM, Ben Tebulin wrote: > >> Ben, please test. I'm worried that the problem you see is something >> even more fundamentally wrong with the whole "oops, must flush in the >> middle" logic, but I'm _hoping_ this fixes it. > > It's gone. > > Really! > > I git-fsck'ed

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-15 Thread Ben Tebulin
Am 15.08.2013 20:00, schrieb Linus Torvalds: > Ok, so I've slept on it, and here's my current thinking. > [...] Many thoughts which as a user I'm am unable to follow ;-) > This patch tries to fix the interface instead of trying to patch up > the individual places that *should* set the range

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-15 Thread Ben Tebulin
Am 15.08.2013 20:00, schrieb Linus Torvalds: Ok, so I've slept on it, and here's my current thinking. [...] Many thoughts which as a user I'm am unable to follow ;-) This patch tries to fix the interface instead of trying to patch up the individual places that *should* set the range some

Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-)

2013-08-15 Thread Linus Torvalds
On Thu, Aug 15, 2013 at 4:05 PM, Ben Tebulin tebu...@googlemail.com wrote: Ben, please test. I'm worried that the problem you see is something even more fundamentally wrong with the whole oops, must flush in the middle logic, but I'm _hoping_ this fixes it. It's gone. Really! I