Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-23 Thread Andi Kleen
Andrew Morton writes: > > Would it not be better to fix this by assigning those CPUs to their real, > memoryless node right at the initial boot? Or is there something in > the kernel which makes cpus-on-a-memoryless-node not work correctly? I probably added this originally. The original reason

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-23 Thread Andi Kleen
Andrew Morton a...@linux-foundation.org writes: Would it not be better to fix this by assigning those CPUs to their real, memoryless node right at the initial boot? Or is there something in the kernel which makes cpus-on-a-memoryless-node not work correctly? I probably added this originally.

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/23 9:34, Andrew Morton wrote: On Tue, 23 Apr 2013 09:04:46 +0900 Yasuaki Ishimatsu wrote: 2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu wrote: When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Andrew Morton
On Tue, 23 Apr 2013 09:04:46 +0900 Yasuaki Ishimatsu wrote: > 2013/04/23 7:35, Andrew Morton wrote: > > On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu > > wrote: > > > >> When booting x86 system contains memoryless node, node numbers of CPUs > >> on memoryless node were changed to

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu wrote: When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node were changed to nearest online node number by init_cpu_to_node() because the node is not online. ...

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Andrew Morton
On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu wrote: > When booting x86 system contains memoryless node, node numbers of CPUs > on memoryless node were changed to nearest online node number by > init_cpu_to_node() because the node is not online. > > ... > > If we hot add memory to

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Andrew Morton
On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node were changed to nearest online node number by init_cpu_to_node() because the node is not online. ... If we

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node were changed to nearest online node number by init_cpu_to_node() because

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Andrew Morton
On Tue, 23 Apr 2013 09:04:46 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: 2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: When booting x86 system contains memoryless node, node numbers of

Re: [Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-22 Thread Yasuaki Ishimatsu
2013/04/23 9:34, Andrew Morton wrote: On Tue, 23 Apr 2013 09:04:46 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: 2013/04/23 7:35, Andrew Morton wrote: On Fri, 19 Apr 2013 14:23:23 +0900 Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com wrote: When booting x86 system

[Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-18 Thread Yasuaki Ishimatsu
When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node were changed to nearest online node number by init_cpu_to_node() because the node is not online. In my system, node numbers of cpu#30-44 and 75-89 were changed from 2 to 0 as follows: $ numactl --hardware

[Bug fix PATCH v2] numa, cpu hotplug: Change links of CPU and node when changing node number by onlining CPU

2013-04-18 Thread Yasuaki Ishimatsu
When booting x86 system contains memoryless node, node numbers of CPUs on memoryless node were changed to nearest online node number by init_cpu_to_node() because the node is not online. In my system, node numbers of cpu#30-44 and 75-89 were changed from 2 to 0 as follows: $ numactl --hardware