RE: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-06-01 Thread Khachaturov, Vassilii
If you do implement such a thing, make sure that you don't mistakenly spot smth that gets exported to a non-kernel-tree driver, or smth that gets called by a non-__init, --- but not in the current kernel config! V. > -Original Message- > From: Dawson Engler [mailto:[EMAIL PROTECTED]] > c

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-06-01 Thread Geert Uytterhoeven
On Wed, 30 May 2001, Dawson Engler wrote: > Here are *uninspected* 2.4.5-ac4 results of a checker that warns when a > non-__init function calls an __init function (suggested by > [EMAIL PROTECTED]). There seem to be two cases: > > 1. The best case: the caller should actually be an __init

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-31 Thread Dawson Engler
> These are actual (performance) bugs. > Patch is appended. Thanks for the quick feedback! > BTW: I don't if you did so already, but if you extended the checker to > find functions which are only called from __init functions, but not > marked __init themselves, you'd most likely find lots more p

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-30 Thread David Woodhouse
[EMAIL PROTECTED] said: > It's a space/performance bug, though, right? From the original mail: > 1. The best case: the caller should actually be an __init function > as well. This is a performance bug since it won't be freed. Yes, sorry. I hadn't properly read the beginning o

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-30 Thread Dawson Engler
> > drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn > > 'DoC_Probe' calling init fn 'doccheck' > > Strictly speaking, not actually a bug. DoC_Probe() itself is only ever > called from __init code. But it's probably not worth trying to make the > checker notice that situation - I'v

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-30 Thread Oliver Xymoron
On Wed, 30 May 2001, David Woodhouse wrote: > > [EMAIL PROTECTED] said: > > drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn > > 'DoC_Probe' calling init fn 'doccheck' > > Strictly speaking, not actually a bug. DoC_Probe() itself is only ever > called from __init code. But it's proba

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-30 Thread Harald Welte
On Wed, May 30, 2001 at 01:08:40PM -0700, Dawson Engler wrote: > Here are *uninspected* 2.4.5-ac4 results of a checker that warns when a > non-__init function calls an __init function (suggested by > [EMAIL PROTECTED]). There seem to be two cases: > > 1. The best case: the caller should

Re: [CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-30 Thread David Woodhouse
[EMAIL PROTECTED] said: > drivers/mtd/docprobe.c:195:DoC_Probe: ERROR:INIT: non-init fn > 'DoC_Probe' calling init fn 'doccheck' Strictly speaking, not actually a bug. DoC_Probe() itself is only ever called from __init code. But it's probably not worth trying to make the checker notice that si

[CHECKER] 2.4.5-ac4 non-init functions calling init functions

2001-05-30 Thread Dawson Engler
Here are *uninspected* 2.4.5-ac4 results of a checker that warns when a non-__init function calls an __init function (suggested by [EMAIL PROTECTED]). There seem to be two cases: 1. The best case: the caller should actually be an __init function as well. This is a performance bu