Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

2016-06-28 Thread Dave Chinner
On Tue, Jun 28, 2016 at 10:13:32AM +0100, Steven Whitehouse wrote: > Hi, > > On 28/06/16 03:08, Dave Chinner wrote: > >On Fri, Jun 24, 2016 at 02:50:11PM -0500, Bob Peterson wrote: > >>This patch adds a new prune_icache_sb function for the VFS slab > >>shrinker to call. Trying to directly free the

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

2016-06-28 Thread Steven Whitehouse
Hi, On 28/06/16 03:08, Dave Chinner wrote: On Fri, Jun 24, 2016 at 02:50:11PM -0500, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls into DLM

Re: [Cluster-devel] [PATCH 2/2] GFS2: Add a gfs2-specific prune_icache_sb

2016-06-26 Thread Steven Whitehouse
Hi, I think the idea looks good. A couple of comments below though... On 24/06/16 20:50, Bob Peterson wrote: This patch adds a new prune_icache_sb function for the VFS slab shrinker to call. Trying to directly free the inodes from memory might deadlock because it evicts inodes, which calls into