Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-11 Thread Pengfei Wang
> 在 2017年1月11日，下午2:12，Julia Lawall 写道： > > I looked at the get_user part of the original script. It looks like most > of the complexity is to deal with the possibility of the src location > being expressed in two different ways between the two calls. Yes, in addition to pointer alias and the

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-10 Thread Julia Lawall
I looked at the get_user part of the original script. It looks like most of the complexity is to deal with the possibility of the src location being expressed in two different ways between the two calls. Even if this happens in practice only for get_user, it would seem that it could happen for co

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-10 Thread Kees Cook
On Tue, Jan 10, 2017 at 12:40 AM, Vaishali Thakkar wrote: > On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: >> >> >>> 在 2017年1月10日，上午1:05，Vaishali Thakkar 写道： >>> >>> On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to V

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-10 Thread Kees Cook
On Tue, Jan 10, 2017 at 12:21 AM, Pengfei Wang wrote: > > 在 2017年1月10日，上午1:05，Vaishali Thakkar 写道： > > On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: > > I totally dropped the ball on this. Many thanks to Vaishali for > resurrecting it. > > Some changes are suggested below. > > On Tue

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-10 Thread Vaishali Thakkar
On Tuesday 10 January 2017 02:32 PM, Pengfei Wang wrote: 在 2017年1月10日，下午4:40，Vaishali Thakkar 写道： On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: 在 2017年1月10日，上午1:05，Vaishali Thakkar 写道： On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on thi

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-10 Thread Vaishali Thakkar
On Tuesday 10 January 2017 01:51 PM, Pengfei Wang wrote: 在 2017年1月10日，上午1:05，Vaishali Thakkar 写道： On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to Vaishali for resurrecting it. Some changes are suggested below. On Tue, 26 Apr 201

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-09 Thread Kees Cook
On Mon, Jan 9, 2017 at 12:56 PM, Kees Cook wrote: > On Mon, Jan 9, 2017 at 11:08 AM, Julia Lawall wrote: >> >> On Mon, 9 Jan 2017, Vaishali Thakkar wrote: >> >>> Here, may be we should add few more lines from Pengfei's >>> script to avoid th potential FPs. >> >> Which lines (I don't have it handy

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-09 Thread Kees Cook
On Mon, Jan 9, 2017 at 11:08 AM, Julia Lawall wrote: > > > On Mon, 9 Jan 2017, Vaishali Thakkar wrote: > >> On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: >> > I totally dropped the ball on this. Many thanks to Vaishali for >> > resurrecting it. >> > >> > Some changes are suggested bel

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-09 Thread Julia Lawall
On Mon, 9 Jan 2017, Vaishali Thakkar wrote: > On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: > > I totally dropped the ball on this. Many thanks to Vaishali for > > resurrecting it. > > > > Some changes are suggested below. > > > > On Tue, 26 Apr 2016, Kees Cook wrote: > > > > > This

Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user

2017-01-09 Thread Vaishali Thakkar
On Tuesday 27 December 2016 11:51 PM, Julia Lawall wrote: I totally dropped the ball on this. Many thanks to Vaishali for resurrecting it. Some changes are suggested below. On Tue, 26 Apr 2016, Kees Cook wrote: This is usually a sign of a resized request. This adds a check for potential race