Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread SF Markus Elfring
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html >> http://marc.info/?l=kernel-janitors=139405971927100=2 > Regular expressions do not allow taking advantage of the optimizations > provided by Coccinelle and are not easy for a reader to understand. I find that the application of

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-29 Thread SF Markus Elfring
https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html http://marc.info/?l=kernel-janitorsm=139405971927100w=2 Regular expressions do not allow taking advantage of the optimizations provided by Coccinelle and are not easy for a reader to understand. I find that the application of

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: > > Sorry but I'm not working on coccinelle ; just did a small script for > > kernel tree. > > I would appreciate a more constructive feedback for my update suggestions > around > the topic "Deletion of unnecessary checks before specific function

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: > > > V3: > >-Update print_main message. > > Does the discussion topic need also an adjustment? > > How do you think about my previous update suggestion "Deletion of > unnecessary checks before specific function calls"? >

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: V3: -Update print_main message. Does the discussion topic need also an adjustment? How do you think about my previous update suggestion Deletion of unnecessary checks before specific function calls?

Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?

2014-06-28 Thread Julia Lawall
On Sat, 28 Jun 2014, SF Markus Elfring wrote: Sorry but I'm not working on coccinelle ; just did a small script for kernel tree. I would appreciate a more constructive feedback for my update suggestions around the topic Deletion of unnecessary checks before specific function calls. -