Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 8:23 PM, Stephen Warren wrote: > The entire reason I created the directory (rather than > just putting *.h into e.g. arch/arm/boot/dts) was to provide a place to > share binding-defined constants between the DT files and drivers that > implement that binding. It's

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-11 Thread Linus Walleij
On Mon, Jun 10, 2013 at 8:23 PM, Stephen Warren swar...@wwwdotorg.org wrote: The entire reason I created the dt-bindings/ directory (rather than just putting *.h into e.g. arch/arm/boot/dts) was to provide a place to share binding-defined constants between the DT files and drivers that

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Rob Herring
On 06/10/2013 01:23 PM, Stephen Warren wrote: > On 06/10/2013 07:00 AM, Linus Walleij wrote: >> On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner wrote: >> >> (...) >>> +#include >>> +#include >>> +#include >> >> Hm I don't know if we're supposed to do things like this actually. >> >> It depends

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Stephen Warren
On 06/10/2013 07:00 AM, Linus Walleij wrote: > On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner wrote: > > (...) >> +#include >> +#include >> +#include > > Hm I don't know if we're supposed to do things like this actually. > > It depends on whether the hierarchy is supposed > to stay in the

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Linus Walleij
On Mon, Jun 10, 2013 at 3:10 PM, Heiko Stübner wrote: > Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij: >> On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner wrote: >> >> (...) >> >> > +#include >> > +#include >> > +#include >> >> Hm I don't know if we're supposed to do things like this

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Heiko Stübner
Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij: > On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner wrote: > > (...) > > > +#include > > +#include > > +#include > > Hm I don't know if we're supposed to do things like this actually. > > It depends on whether the hierarchy is supposed

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Linus Walleij
On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner wrote: (...) > +#include > +#include > +#include Hm I don't know if we're supposed to do things like this actually. It depends on whether the hierarchy is supposed to stay in the kernel after the device trees are moved out to a separate repo.

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Linus Walleij
On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner wrote: > This driver adds support the Cortex-A9 based SoCs from Rockchip, > so at least the RK2928, RK3066 (a and b) and RK3188. > Earlier Rockchip SoCs seem to use similar mechanics for gpio > handling so should be supportable with relative small

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Linus Walleij
On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner he...@sntech.de wrote: This driver adds support the Cortex-A9 based SoCs from Rockchip, so at least the RK2928, RK3066 (a and b) and RK3188. Earlier Rockchip SoCs seem to use similar mechanics for gpio handling so should be supportable with

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Linus Walleij
On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner he...@sntech.de wrote: (...) +#include linux/irqchip/chained_irq.h +#include linux/clk-provider.h +#include dt-bindings/pinctrl/rockchip.h Hm I don't know if we're supposed to do things like this actually. It depends on whether the dt-bindings/*

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Heiko Stübner
Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij: On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner he...@sntech.de wrote: (...) +#include linux/irqchip/chained_irq.h +#include linux/clk-provider.h +#include dt-bindings/pinctrl/rockchip.h Hm I don't know if we're supposed to do

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Linus Walleij
On Mon, Jun 10, 2013 at 3:10 PM, Heiko Stübner he...@sntech.de wrote: Am Montag, 10. Juni 2013, 15:00:41 schrieb Linus Walleij: On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner he...@sntech.de wrote: (...) +#include linux/irqchip/chained_irq.h +#include linux/clk-provider.h +#include

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Stephen Warren
On 06/10/2013 07:00 AM, Linus Walleij wrote: On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner he...@sntech.de wrote: (...) +#include linux/irqchip/chained_irq.h +#include linux/clk-provider.h +#include dt-bindings/pinctrl/rockchip.h Hm I don't know if we're supposed to do things like this

Re: [EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-10 Thread Rob Herring
On 06/10/2013 01:23 PM, Stephen Warren wrote: On 06/10/2013 07:00 AM, Linus Walleij wrote: On Sun, Jun 9, 2013 at 2:01 AM, Heiko Stübner he...@sntech.de wrote: (...) +#include linux/irqchip/chained_irq.h +#include linux/clk-provider.h +#include dt-bindings/pinctrl/rockchip.h Hm I don't

[EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-08 Thread Heiko Stübner
This driver adds support the Cortex-A9 based SoCs from Rockchip, so at least the RK2928, RK3066 (a and b) and RK3188. Earlier Rockchip SoCs seem to use similar mechanics for gpio handling so should be supportable with relative small changes. Pull handling on the rk3188 is currently a stub, due to

[EXAMPLE PATCH] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-08 Thread Heiko Stübner
This driver adds support the Cortex-A9 based SoCs from Rockchip, so at least the RK2928, RK3066 (a and b) and RK3188. Earlier Rockchip SoCs seem to use similar mechanics for gpio handling so should be supportable with relative small changes. Pull handling on the rk3188 is currently a stub, due to