Re: [External] Re: [PATCH v2] mm: memcontrol: fix kernel stack account

2021-03-03 Thread Shakeel Butt
On Wed, Mar 3, 2021 at 6:02 AM Michal Hocko wrote: > [...] > > > > + BUG_ON(vm->nr_pages != THREAD_SIZE / PAGE_SIZE); > > > > > > I do not think we need this BUG_ON. What kind of purpose does it serve? > > > > vm->nr_pages should be always equal to THREAD_SIZE / PAGE_SIZE > > if the

Re: [External] Re: [PATCH v2] mm: memcontrol: fix kernel stack account

2021-03-03 Thread Michal Hocko
On Wed 03-03-21 21:27:24, Muchun Song wrote: > On Wed, Mar 3, 2021 at 6:25 PM Michal Hocko wrote: > > > > On Wed 03-03-21 17:39:56, Muchun Song wrote: > > > For simplification 991e7673859e ("mm: memcontrol: account kernel stack > > > per node") has changed the per zone vmalloc backed stack pages

Re: [External] Re: [PATCH v2] mm: memcontrol: fix kernel stack account

2021-03-03 Thread Muchun Song
On Wed, Mar 3, 2021 at 6:25 PM Michal Hocko wrote: > > On Wed 03-03-21 17:39:56, Muchun Song wrote: > > For simplification 991e7673859e ("mm: memcontrol: account kernel stack > > per node") has changed the per zone vmalloc backed stack pages > > accounting to per node. By doing that we have lost