Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Sat, 27 Mar 2021 19:07:10 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc4-smb3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/81b1d39fd39a0ecfd30606714bcc05da586044f9 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b: Linux 5.12-rc4 (2021-03-21 14:56:43 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc4-smb3 for you to fetch changes up to cfc63fc8126a93cbf95379bc4cad79a7b15b6ece: smb3: fix cached file size problems in duplicate extents (reflink) (2021-03-26 18:41:55 -0500) 5 cifs/smb3 fixes, 2 for stable, includes an important fix for encryption and an ACL fix, as well as two fixes for possible data corruptions (one for reflink and one for SMB1) Test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/543 Ronnie Sahlberg (1): cifs: revalidate mapping when we open files for SMB1 POSIX Shyam Prasad N (2): cifs: Adjust key sizes and key generation routines for AES256 encryption cifs: Fix chmod with modefromsid when an older ACE already exists. Steve French (1): smb3: fix cached file size problems in duplicate extents (reflink) Vincent Whitchurch (1): cifs: Silently ignore unknown oplock break handle fs/cifs/cifsacl.c | 3 +-- fs/cifs/cifsglob.h | 4 ++-- fs/cifs/cifspdu.h | 5 + fs/cifs/file.c | 1 + fs/cifs/smb2glob.h | 1 + fs/cifs/smb2misc.c | 4 ++-- fs/cifs/smb2ops.c | 27 --- fs/cifs/smb2transport.c | 37 - 8 files changed, 60 insertions(+), 22 deletions(-) -- Thanks, Steve
Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Sat, 20 Mar 2021 11:18:54 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc3-smb3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bfdc4aa9e99204d1bf925cdbfea9a1d903ebed29 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc3-smb3 for you to fetch changes up to 65af8f0166f4d15e61c63db498ec7981acdd897f: cifs: fix allocation size on newly created files (2021-03-19 11:51:31 -0500) 5 cifs/smb3 fixes, 3 for stable, including an important ACL fix and security signature fix Test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/530 Aurelien Aptel (1): cifs: warn and fail if trying to use rootfs without the config option Liu xuzhi (1): fs/cifs/: fix misspellings using codespell tool Shyam Prasad N (1): cifs: update new ACE pointer after populate_new_aces. Steve French (1): cifs: fix allocation size on newly created files Vincent Whitchurch (1): cifs: Fix preauth hash corruption fs/cifs/cifs_swn.c | 2 +- fs/cifs/cifsacl.c| 9 ++--- fs/cifs/fs_context.c | 6 -- fs/cifs/inode.c | 10 +- fs/cifs/transport.c | 7 ++- 5 files changed, 26 insertions(+), 8 deletions(-) -- Thanks, Steve
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0: Linux 5.12-rc3 (2021-03-14 14:41:02 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-rc3-smb3 for you to fetch changes up to 65af8f0166f4d15e61c63db498ec7981acdd897f: cifs: fix allocation size on newly created files (2021-03-19 11:51:31 -0500) 5 cifs/smb3 fixes, 3 for stable, including an important ACL fix and security signature fix Test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/530 Aurelien Aptel (1): cifs: warn and fail if trying to use rootfs without the config option Liu xuzhi (1): fs/cifs/: fix misspellings using codespell tool Shyam Prasad N (1): cifs: update new ACE pointer after populate_new_aces. Steve French (1): cifs: fix allocation size on newly created files Vincent Whitchurch (1): cifs: Fix preauth hash corruption fs/cifs/cifs_swn.c | 2 +- fs/cifs/cifsacl.c| 9 ++--- fs/cifs/fs_context.c | 6 -- fs/cifs/inode.c | 10 +- fs/cifs/transport.c | 7 ++- 5 files changed, 26 insertions(+), 8 deletions(-) -- Thanks, Steve
Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Fri, 26 Feb 2021 00:24:14 -0600: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-smb3-part1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c19798af2e66d9d3eb1060873bb435ea8bf4ad2e Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit f40ddce88593482919761f74910f42f4b84c004b: Linux 5.11 (2021-02-14 14:32:24 -0800) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.12-smb3-part1 for you to fetch changes up to 8369dfd7841e70711c53a065ffb8029f24520200: cifs: update internal version number (2021-02-25 19:08:11 -0600) cifs/smb3 fixes: - improvements to mode bit conversion, chmod and chown when using cifsacl mount option - two new mount options for controlling attribute caching - improvements to crediting and reconnect, improved debugging - reconnect fix - add SMB3.1.1 dialect to default dialects for vers=3 Still working on a security fix and some multichannel fixes which are not included in this pull request Test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/513 David Howells (1): cifs: use discard iterator to discard unneeded network data more efficiently Paulo Alcantara (4): cifs: fix nodfs mount option cifs: fix DFS failover cifs: check all path components in resolved dfs target cifs: introduce helper for finding referral server to improve DFS target resolution Rohith Surabattula (1): TCON Reconnect during STATUS_NETWORK_NAME_DELETED Ronnie Sahlberg (1): cifs: fix handling of escaped ',' in the password mount argument Shyam Prasad N (8): cifs: New optype for session operations. cifs: Fix in error types returned for out-of-credit situations. cifs: Identify a connection by a conn_id. cifs: Reformat DebugData and index connections by conn_id. cifs: Fix cifsacl ACE mask for group and others. cifs: Retain old ACEs when converting between mode bits and ACL. cifs: Change SIDs in ACEs while transferring file ownership. cifs: If a corrupted DACL is returned by the server, bail out. Steve French (11): smb3: negotiate current dialect (SMB3.1.1) when version 3 or greater requested cifs: fix trivial typo cifs: documentation cleanup cifs: change confusing field serverName (to ip_addr) cifs: clarify hostname vs ip address in /proc/fs/cifs/DebugData cifs: cleanup a few le16 vs. le32 uses in cifsacl.c cifs: minor simplification to smb2_is_network_name_deleted cifs: Add new mount parameter "acdirmax" to allow caching directory metadata cifs: convert revalidate of directories to using directory metadata cache timeout cifs: Add new parameter "acregmax" for distinct file and directory metadata timeout cifs: update internal version number YueHaibing (1): cifs: Fix inconsistent IS_ERR and PTR_ERR Documentation/admin-guide/cifs/authors.rst | 6 +- Documentation/admin-guide/cifs/changes.rst | 5 +- Documentation/admin-guide/cifs/introduction.rst | 30 +- Documentation/admin-guide/cifs/todo.rst | 34 ++- Documentation/admin-guide/cifs/usage.rst| 2 +- fs/cifs/cifs_debug.c| 121 fs/cifs/cifs_swn.c | 2 +- fs/cifs/cifsacl.c | 379 +++- fs/cifs/cifsacl.h | 4 +- fs/cifs/cifsencrypt.c | 6 +- fs/cifs/cifsfs.c| 15 +- fs/cifs/cifsfs.h| 2 +- fs/cifs/cifsglob.h | 11 +- fs/cifs/cifsproto.h | 2 + fs/cifs/cifssmb.c | 6 +- fs/cifs/connect.c | 301 ++- fs/cifs/dfs_cache.c | 33 ++- fs/cifs/file.c | 2 +- fs/cifs/fs_context.c| 75 +++-- fs/cifs/fs_context.h| 6 +- fs/cifs/inode.c | 23 +- fs/cifs/sess.c | 2 +- fs/cifs/smb2ops.c | 109 +-- fs/cifs/smb2pdu.c | 22 +- fs/cifs/trace.h | 36 ++- fs/cifs/transport.c | 63 ++-- 26 files changed, 883 insertions(+), 414 deletions(-) -- Thanks, Steve
Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Sun, 20 Dec 2020 13:47:32 -0600: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3-part2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/582888130702b86daa44ff6bfee585e4d4050ba0 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit
e13300bdaa68f5487000e66baed1ff69bcb510bf:
Merge tag '5.11-rc-smb3' of git://git.samba.org/sfrench/cifs-2.6
(2020-12-17 17:41:37 -0800)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3-part2
for you to fetch changes up to 9541b81322e60120b299222919957becd7a13683:
Add SMB 2 support for getting and setting SACLs (2020-12-18 23:32:04 -0600)
Four small CIFS/SMB3 fixes (witness protocol and reconnect related),
and two that add ability to get and set auditing information in the
security descriptor (SACL), which can be helpful not just for backup
scenarios ("smbinfo secdesc" etc.) but also for improving security.
Testing results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/466
Boris Protopopov (2):
SMB3: Add support for getting and setting SACLs
Add SMB 2 support for getting and setting SACLs
Dan Carpenter (3):
cifs: Delete a stray unlock in cifs_swn_reconnect()
cifs: Unlock on errors in cifs_swn_reconnect()
cifs: Re-indent cifs_swn_reconnect()
Samuel Cabrero (1):
cifs: Avoid error pointer dereference
fs/cifs/cifs_swn.c | 73 +++
fs/cifs/cifsacl.c | 15 ++
fs/cifs/cifsglob.h | 4 +--
fs/cifs/cifspdu.h | 2 ++
fs/cifs/cifsproto.h | 4 +--
fs/cifs/connect.c | 1 +
fs/cifs/smb2ops.c | 35 ++-
fs/cifs/smb2pdu.c | 7 +++--
fs/cifs/smb2proto.h | 4 +--
fs/cifs/xattr.c | 81 +++--
10 files changed, 140 insertions(+), 86 deletions(-)
--
Thanks,
Steve
Re: [GIT PULL] CIFS/SMB3 Fixes and Improvements for 5.11-rc
The pull request you sent on Thu, 17 Dec 2020 19:05:32 -0600: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e13300bdaa68f5487000e66baed1ff69bcb510bf Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] CIFS/SMB3 Fixes and Improvements for 5.11-rc
Please pull the following changes since commit 2c85ebc57b3e1817b6ce1a6b703928e113a90442: Linux 5.10 (2020-12-13 14:41:30 -0800) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc-smb3 for you to fetch changes up to afee4410bc6c50e1422c5a45d633ad0e478ea960: cifs: update internal module version number (2020-12-16 21:56:42 -0600) cifs/smb3 changes: the largest part are for support of the newer mount API which has been needed for cifs/smb3 mounts for a long time due to the new API's better handling of remount, and better error reporting. There are three additional small cleanup patches for this being tested, that are not included yet. This series also includes addition of support for the SMB3 witness protocol which can provide important notifications from the server to client on server address or export or network changes. This can be useful for example in order to be notified before the failure - when a server's IP address changes (in the future it will allow us to support server notifications of when a share is moved). It also includes three patches for stable e.g. some that better handle some confusing error messages during session establishment. Testing results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/462 There are three small patches from Dan Carpenter and also some unrelated (ie unrelated to this PR) multichannel and GCM256 (SMB3 encryption) fixes that are being investigated that are not included in this PR but I hope to finish off reasonably soon. Note that this series has a trivial merge conflict with a recent treewide change which Stephen Rothwell resolved in linux-next with a small patch: [PATCH] fixup for "treewide: rename nla_strlcpy to nla_strscpy." If you need me to send that or add it to my tree let me know. Dmitry Osipenko (1): cifs: Add missing sentinel to smb3_fs_parameters Gustavo A. R. Silva (1): cifs: Fix fall-through warnings for Clang Ronnie Sahlberg (23): cifs: rename smb_vol as smb3_fs_context and move it to fs_context.h cifs: rename dup_vol to smb3_fs_context_dup and move it into fs_context.c cifs: move the enum for cifs parameters into fs_context.h cifs: move cifs_parse_devname to fs_context.c cifs: switch to new mount api cifs: remove the devname argument to cifs_compose_mount_options cifs: add an smb3_fs_context to cifs_sb cifs: get rid of cifs_sb->mountdata cifs: remove [gu]id/backup[gu]id/file_mode/dir_mode from cifs_sb cifs: remove actimeo from cifs_sb cifs: move cifs_cleanup_volume_info[_content] to fs_context.c cifs: move [brw]size from cifs_sb to cifs_sb->ctx cifs: add initial reconfigure support cifs: we do not allow changing username/password/unc/... during remount cifs: simplify handling of cifs_sb/ctx->local_nls cifs: don't create a temp nls in cifs_setup_ipc cifs: uncomplicate printing the iocharset parameter cifs: do not allow changing posix_paths during remount cifs: remove ctx argument from cifs_setup_cifs_sb cifs: move update of flags into a separate function cifs: update mnt_cifs_flags during reconfigure cifs: fix uninitialized variable in smb3_fs_context_parse_param cifs: fix use after free in cifs_smb3_do_mount() Samuel Cabrero (11): cifs: Make extract_hostname function public cifs: Make extract_sharename function public cifs: Register generic netlink family cifs: add witness mount option and data structs cifs: Send witness register and unregister commands to userspace daemon cifs: Set witness notification handler for messages from userspace daemon cifs: Add witness information to debug data dump cifs: Send witness register messages to userspace daemon in echo task cifs: Simplify reconnect code when dfs upcall is enabled cifs: Handle witness client move notification cifs: Fix some error pointers handling detected by static checker Shyam Prasad N (3): cifs: Fix unix perm bits to cifsacl conversion for "other" bits. cifs: Enable sticky bit with cifsacl mount option. cifs: Tracepoints and logs for tracing credit changes. Steve French (16): SMB3: avoid confusing warning message on mount to Azure SMB3.1.1: remove confusing mount warning when no SPNEGO info on negprot rsp SMB3.1.1: update comments clarifying SPNEGO info in negprot response SMB3.1.1: do not log warning message if server doesn't populate salt cifs: minor kernel style fixes for comments cifs: cleanup misc.c cifs: minor updates to Kconfig cifs: remove various function description warnings cifs: remove some minor warnings pointed out by kernel test robot cifs: update super_operations
Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Mon, 3 Aug 2020 17:45:03 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.9-rc-smb3-fixes-part1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/327a8d76b1ac2037f87bf041f3bc076407284ffc Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit
bcf876870b95592b52519ed4aafcf9d95999bc9c:
Linux 5.8 (2020-08-02 14:21:45 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.9-rc-smb3-fixes-part1
for you to fetch changes up to 7efd081582619e7c270d1c0a422385dcaa99fa9f:
cifs: document and cleanup dfs mount (2020-08-02 18:00:26 -0500)
16 cifs/smb3 fixes, about half DFS related, 2 fixes for stable
Still working on and testing an additional set of fixes (including
updates to mount, and some fallocate scenario improvements) for later
in the merge window.
Build verification test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/379
Colin Ian King (1):
cifs: fix double free error on share and prefix
Liao Pingfang (1):
cifs: Remove the superfluous break
Paul Aurich (1):
cifs: Fix leak when handling lease break for cached root fid
Paulo Alcantara (6):
cifs: reduce number of referral requests in DFS link lookups
cifs: rename reconn_inval_dfs_target()
cifs: handle empty list of targets in cifs_reconnect()
cifs: handle RESP_GET_DFS_REFERRAL.PathConsumed in reconnect
cifs: only update prefix path of DFS links in cifs_tree_connect()
cifs: document and cleanup dfs mount
Qinglang Miao (1):
cifs: convert to use be32_add_cpu()
Randy Dunlap (1):
cifs: delete duplicated words in header files
Roberto Bergantinos Corpas (1):
cifs`: handle ERRBaduid for SMB1
Ronnie Sahlberg (1):
cifs: smb1: Try failing back to SetFileInfo if SetPathInfo fails
Stefan Metzmacher (1):
cifs: merge __{cifs,smb2}_reconnect[_tcon]() into cifs_tree_connect()
Steve French (1):
smb3: warn on confusing error scenario with sec=krb5
Wei Yongjun (1):
cifs: remove unused variable 'server'
fs/cifs/cifsacl.h | 4 +-
fs/cifs/cifsglob.h | 2 +-
fs/cifs/cifsproto.h | 9 +-
fs/cifs/cifssmb.c | 151 -
fs/cifs/connect.c | 508
++--
fs/cifs/dfs_cache.c | 136 +-
fs/cifs/dfs_cache.h | 7 +-
fs/cifs/inode.c | 2 -
fs/cifs/misc.c | 7 +-
fs/cifs/netmisc.c | 27 ++
fs/cifs/sess.c | 4 +-
fs/cifs/smb1ops.c | 4 +-
fs/cifs/smb2misc.c | 73 ++
fs/cifs/smb2pdu.c | 115 +-
fs/cifs/smb2pdu.h | 2 +-
fs/cifs/transport.c | 2 +-
16 files changed, 560 insertions(+), 493 deletions(-)
--
Thanks,
Steve
Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Fri, 3 Jul 2020 22:44:08 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.8-rc3-smb3-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b8e516b36748fd87943e54596a8a6f04ec05f1a5 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68: Linux 5.8-rc3 (2020-06-28 15:00:24 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.8-rc3-smb3-fixes for you to fetch changes up to 19e888678bac8c82206eb915eaf72741b2a2615c: cifs: prevent truncation from long to int in wait_for_free_credits (2020-07-01 20:01:26 -0500) 8 cifs/smb3 fixes, most for when specifying the multiuser mount flag, 5 of the fixes for stable. Regression test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/364 Paul Aurich (6): cifs: Display local UID details for SMB sessions in DebugData SMB3: Honor 'seal' flag for multiuser mounts SMB3: Honor persistent/resilient handle flags for multiuser mounts SMB3: Honor lease disabling for multiuser mounts SMB3: Honor 'handletimeout' flag for multiuser mounts SMB3: Honor 'posix' flag for multiuser mounts Ronnie Sahlberg (1): cifs: prevent truncation from long to int in wait_for_free_credits Zhang Xiaoxu (1): cifs: Fix the target file was deleted when rename failed. fs/cifs/cifs_debug.c | 6 +- fs/cifs/connect.c| 10 ++ fs/cifs/inode.c | 10 -- fs/cifs/transport.c | 2 +- 4 files changed, 20 insertions(+), 8 deletions(-) -- Thanks, Steve
Re: [GIT PULL] CIFS/SMB3 Fixes
The pull request you sent on Sat, 13 Jun 2020 15:37:46 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.8-rc-smb3-fixes-part2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f82e7b57b5fc48199e2f26ffafe2f96f7338ad3d Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
[GIT PULL] CIFS/SMB3 Fixes
Please pull the following changes since commit 3803d5e4d3ce2600ffddc16a1999798bc719042d: Merge tag '5.8-rc-smb3-fixes-part-1' of git://git.samba.org/sfrench/cifs-2.6 (2020-06-05 16:40:53 -0700) are available in the Git repository at: git://git.samba.org/sfrench/cifs-2.6.git tags/5.8-rc-smb3-fixes-part2 for you to fetch changes up to a7a519a4926214ba4161bc30109f4a8d69defb8d: smb3: Add debug message for new file creation with idsfromsid mount option (2020-06-12 16:31:06 -0500) 12 cifs/smb3 fixes, 2 for stable. Adds support for idsfromsid on create and also for chgrp/chown allowing ability to save owner information more naturally for some workloads. Improves getattr when SMB3.1.1 posix extensions are negotiated by using new query info level. Regression test results: http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/357 Kenneth D'souza (1): cifs: Add get_security_type_str function to return sec type. Namjae Jeon (1): smb3: add indatalen that can be a non-zero value to calculation of credit charge in smb2 ioctl Steve French (10): smb3: extend fscache mount volume coherency check smb3: fix typo in mount options displayed in /proc/mounts SMB311: Add support for query info using posix extensions (level 100) smb311: Add support for SMB311 query info (non-compounded) smb311: Add support for lookup with posix extensions query info smb311: add support for using info level for posix extensions query smb311: Add tracepoints for new compound posix query info smb3: allow uid and gid owners to be set on create with idsfromsid mount option cifs: fix chown and chgrp when idsfromsid mount option enabled smb3: Add debug message for new file creation with idsfromsid mount option fs/cifs/cache.c | 9 +--- fs/cifs/cifs_debug.c | 4 +- fs/cifs/cifsacl.c| 79 -- fs/cifs/cifsacl.h| 15 ++ fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 18 +++ fs/cifs/cifsproto.h | 3 ++ fs/cifs/dir.c| 5 +- fs/cifs/file.c | 5 +- fs/cifs/fscache.c| 17 ++- fs/cifs/fscache.h| 9 fs/cifs/inode.c | 185 -- fs/cifs/link.c | 4 +- fs/cifs/smb2glob.h | 1 + fs/cifs/smb2inode.c | 105 fs/cifs/smb2pdu.c| 131 - fs/cifs/smb2pdu.h| 27 ++- fs/cifs/smb2proto.h | 6 +++ fs/cifs/trace.h | 3 ++ 19 files changed, 571 insertions(+), 57 deletions(-) -- Thanks, Steve
Re: [GIT PULL] CIFS/SMB3 fixes
On Wed, May 8, 2019 at 3:37 PM Linus Torvalds wrote: > > On Wed, May 8, 2019 at 11:32 AM Steve French wrote: > > > >[..] Our > > build verification tests passed (and continue to be extended to > > include more tests). See e.g. our 'buildbot' results at: > > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/199 > > Still, is there any reason for that very late rebase? > > Why are all the commits so recent? Most of the commits were from April, three from March, only a few more recent. I rebased yesterday (bad idea it seems based on your note) simply to avoid any potential merge conflict with the two broad VFS changes (unrelated to my PR) that hit cifs code yesterday (albeit they turned out to be very small). > And perhaps even more importantly, why is the base for that rebase is > some completely random and inappropriate commit in the middle of the > merge window? Understood. I had originally based it on v5.1 tag, but changed that for testing after I saw two other PR's hit I wanted to run the regression tests on 'current' mainline with the changes in for-next code just in case (very unlikely) the other two changes that I hadn't seen that hit cifs since 5.1 broke anything or caused conflicts. > So don't do the whole "rebase the day before" in the first place, but > *DEFINITELY* don't do it when you then pick a random and bad point to > rebase things on top of! Understood - will do the rebase for our verification testing only (e.g. to spot any regressions in recent global or VFS changes) but not for sending to you. So for future, will try to send with base as that of mainline kernel as of he last cifs PR merge or new kernel version or rc (e.g. v5.2-rc1 or v5.1 etc) whichever is more recent. Is that ok? -- Thanks, Steve
Re: [GIT PULL] CIFS/SMB3 fixes
On Wed, May 8, 2019 at 1:37 PM Linus Torvalds wrote: > > So don't do the whole "rebase the day before" in the first place, but > *DEFINITELY* don't do it when you then pick a random and bad point to > rebase things on top of! I've pulled, but I really hope this never happens again. You could have rebased your work on top of 5.1 if you needed to. Or you could have just tried to avoid rebasing in the first place. But picking a random commit that was the top-of-the-tree on the second day of the merge window (pretty much when things are at their most chaotic) is just about the worst thing you can do. I'm considering adding some automation to my pull requests to warn about craziness like this. Because maybe you've consistently done something like this in the past, and I've just not noticed how crazy the pull request was. Linus
Re: [GIT PULL] CIFS/SMB3 fixes
The pull request you sent on Wed, 8 May 2019 13:32:35 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.2-smb3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/78d9affbb0e79d48fd82b34ef9cd673a7c86d6f2 Thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/prtracker
Re: [GIT PULL] CIFS/SMB3 fixes
On Wed, May 8, 2019 at 11:32 AM Steve French wrote: > >[..] Our > build verification tests passed (and continue to be extended to > include more tests). See e.g. our 'buildbot' results at: > http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/199 Still, is there any reason for that very late rebase? Why are all the commits so recent? And perhaps even more importantly, why is the base for that rebase is some completely random and inappropriate commit in the middle of the merge window? That's *INSANE*. And it's against everything I've always told people to do: DO NOT BASE YOUR DEVELOPMENT WORK ON SOME RANDOM "KERNEL OF THE DAY" DURING THE MERGE WINDOW !! who knows what horrendous bugs we've introduced at that random point in the merge window, and you now based all your work on that unstable random commit. There is *no* excuse for this kind of crazy development. Even if you use something else than git to develop (some patch-queue based inferior system or whatever) and even if you then import it into git later PICK A SANE AND STABLE IMPORT POINT and if you *do* use git for development, but you have to rebase because you've made some silly mistake and need to undo something PICK A SANE AND STABLE REBASE POINT I don't know how much clearer I can be about this, and I do not understand why this keeps on happening. We've been using git for just about 15 years now, and I've said this for pretty much all that time. Some random googling found this lwn article based on some random old email of mine from ten years ago: https://lwn.net/Articles/328436/ and while it is about general rebasing and merging issues, it does talk about how to "allow development to be based on a (hopefully) relatively stable point where the issues are known". That is as important for a rebase point as it is for a merge point. Rebasing on top of random kernel versions should not be done. EVER. And if you did it to avoid some merge conflict, DON'T. I'd much rather get a pull request for something that is *STABLE* and *WELL-TESTED*, than get a pull request that has been syntactically cleaned up, but is based on something that might not work at all under certain circumstances. Even if *your* code were to be perfect, that doesn't matter if the thing you based your code on is a quicksand of memory corruption and general flakiness. So don't do the whole "rebase the day before" in the first place, but *DEFINITELY* don't do it when you then pick a random and bad point to rebase things on top of! Linus
[GIT PULL] CIFS/SMB3 fixes
Please pull the following changes since commit
d3511f53bb2475f2a4e8460bee5a1ae6dea2a433:
Merge branch 'parisc-5.2-1' of
git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux
(2019-05-07 19:34:17 -0700)
are available in the Git repository at:
git://git.samba.org/sfrench/cifs-2.6.git tags/5.2-smb3
for you to fetch changes up to cb4f7bf6be10b35510e6b2e60f80d85ebc22a578:
cifs: update module internal version number (2019-05-07 23:24:56 -0500)
CIFS/SMB3 changes, three for stable, adds fiemap support, improves
zero-range support, and includes various RDMA (smb direct fixes). Our
build verification tests passed (and continue to be extended to
include more tests). See e.g. our 'buildbot' results at:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/199
Have an additional set of fixes (for improved handling of sparse
files, mode bits, POSIX extensions) that are still being tested that
are not included in this pull request but I expect to send in the next
week.
Aurelien Aptel (1):
CIFS: check CIFS_MOUNT_NO_DFS when trying to reuse existing sb
Christoph Probst (1):
cifs: fix strcat buffer overflow and reduce raciness in
smb21_set_oplock_level()
Jeff Layton (1):
cifs: remove superfluous inode_lock in cifs_{strict_}fsync
Kenneth D'souza (1):
CIFS: Show locallease in /proc/mounts for cifs shares mounted
with locallease feature.
Long Li (7):
smbd: Make upper layer decide when to destroy the transport
cifs: smbd: Don't destroy transport on RDMA disconnect
cifs: smbd: Return EINTR when interrupted
cifs: smbd: Indicate to retry on transport sending failure
cifs: smbd: Retry on memory registration failure
cifs: Call MID callback before destroying transport
cifs: smbd: take an array of reqeusts when sending upper layer data
Paulo Alcantara (SUSE) (1):
cifs: Fix DFS cache refresher for DFS links
Ronnie Sahlberg (8):
cifs: Add support for FSCTL passthrough that write data to the server
cifs: fix bi-directional fsctl passthrough calls
cifs: add fiemap support
cifs: zero-range does not require the file is sparse
cifs: fix smb3_zero_range for Azure
cifs: fix credits leak for SMB1 oplock breaks
cifs: rename and clarify CIFS_ASYNC_OP and CIFS_NO_RESP
SMB3: Clean up query symlink when reparse point
Sergey Senozhatsky (1):
cifs: don't use __constant_cpu_to_le32()
Steve French (8):
SMB3: Track total time spent on roundtrips for each SMB3 command
SMB3: update comment to clarify enumerating snapshots
SMB3: Add handling for different FSCTL access flags
SMB3: Add defines for new negotiate contexts
Add new flag on SMB3.1.1 read
smb3: Add protocol structs for change notify support
Negotiate and save preferred compression algorithms
cifs: update module internal version number
fs/cifs/cifs_debug.c | 33 +-
fs/cifs/cifsfs.c |3 +
fs/cifs/cifsfs.h |4 +-
fs/cifs/cifsglob.h | 27 +-
fs/cifs/cifsproto.h |9 +
fs/cifs/cifssmb.c| 98 +--
fs/cifs/connect.c| 63 +-
fs/cifs/dfs_cache.c | 140 -
fs/cifs/dfs_cache.h |5 +-
fs/cifs/file.c |5 -
fs/cifs/inode.c | 37 ++
fs/cifs/link.c | 13 +-
fs/cifs/smb1ops.c|9 +-
fs/cifs/smb2ops.c| 309 ++---
fs/cifs/smb2pdu.c| 72 ++-
fs/cifs/smb2pdu.h| 71 +++
fs/cifs/smb2status.h | 3480
++---
fs/cifs/smbdirect.c | 292 -
fs/cifs/smbdirect.h | 19 +-
fs/cifs/smbfsctl.h | 29 +-
fs/cifs/transport.c | 48 +-
21 files changed, 2582 insertions(+), 2184 deletions(-)
--
Thanks,
Steve
[GIT PULL] CIFS/SMB3 Fixes
Fix for CIFS/SMB3 oops on reconnect during readpages (3.17 regression) and for incorrectly closing file handle in symlink error cases Please pull the following changes since commit 50dddff3cb9af328dd42bafe3437c7f47e8b38a9: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2014-10-01 21:29:06 -0700) are available in the git repository at: git://git.samba.org/sfrench/cifs-2.6.git for-linus for you to fetch changes up to 1209bbdff2f6bbffa6eb5823033bbd7b8799a5e2: CIFS: Fix readpages retrying on reconnects (2014-10-02 14:17:41 -0500) Pavel Shilovsky (1): CIFS: Fix readpages retrying on reconnects Steve French (1): Fix problem recognizing symlinks fs/cifs/file.c | 8 +--- fs/cifs/smb1ops.c | 2 +- fs/cifs/smb2maperror.c | 2 ++ 3 files changed, 4 insertions(+), 8 deletions(-) -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[GIT PULL] CIFS/SMB3 Fixes
Fix for CIFS/SMB3 oops on reconnect during readpages (3.17 regression) and for incorrectly closing file handle in symlink error cases Please pull the following changes since commit 50dddff3cb9af328dd42bafe3437c7f47e8b38a9: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2014-10-01 21:29:06 -0700) are available in the git repository at: git://git.samba.org/sfrench/cifs-2.6.git for-linus for you to fetch changes up to 1209bbdff2f6bbffa6eb5823033bbd7b8799a5e2: CIFS: Fix readpages retrying on reconnects (2014-10-02 14:17:41 -0500) Pavel Shilovsky (1): CIFS: Fix readpages retrying on reconnects Steve French (1): Fix problem recognizing symlinks fs/cifs/file.c | 8 +--- fs/cifs/smb1ops.c | 2 +- fs/cifs/smb2maperror.c | 2 ++ 3 files changed, 4 insertions(+), 8 deletions(-) -- Thanks, Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
