Re: [GIT PULL] General notification queue and key notifications

2020-06-23 Thread David Howells
Dan Williams wrote: > Shall I wait for your further reworks to fix this for v5.8, or is that > v5.9 material? It could do with stewing in linux-next for a while, so 5.9 probably. David

Re: [GIT PULL] General notification queue and key notifications

2020-06-23 Thread Dan Williams
On Tue, Jun 23, 2020 at 5:55 PM David Howells wrote: > > Dan Williams wrote: > > > > This commit: > > > > > > > keys: Make the KEY_NEED_* perms an enum rather than a mask > > > > > > ...upstream as: > > > > > > 8c0637e950d6 keys: Make the KEY_NEED_* perms an enum rather than a > > >

Re: [GIT PULL] General notification queue and key notifications

2020-06-23 Thread David Howells
Dan Williams wrote: > > This commit: > > > > > keys: Make the KEY_NEED_* perms an enum rather than a mask > > > > ...upstream as: > > > > 8c0637e950d6 keys: Make the KEY_NEED_* perms an enum rather than a mask > > > > ...triggers a regression in the libnvdimm unit test that exercises

Re: [GIT PULL] General notification queue and key notifications

2020-06-23 Thread Dan Williams
On Tue, Jun 16, 2020 at 6:15 PM Williams, Dan J wrote: > > Hi David, > > On Tue, 2020-06-02 at 16:55 +0100, David Howells wrote: > > Date: Tue, 02 Jun 2020 16:51:44 +0100 > > > > Hi Linus, > > > > Can you pull this, please? It adds a general notification queue > > concept > > and adds an event

Re: [GIT PULL] General notification queue and key notifications

2020-06-16 Thread Williams, Dan J
Hi David, On Tue, 2020-06-02 at 16:55 +0100, David Howells wrote: > Date: Tue, 02 Jun 2020 16:51:44 +0100 > > Hi Linus, > > Can you pull this, please? It adds a general notification queue > concept > and adds an event source for keys/keyrings, such as linking and > unlinking > keys and

Re: [GIT PULL] General notification queue and key notifications

2020-06-13 Thread Miklos Szeredi
On Sat, Jun 13, 2020 at 3:05 PM David Howells wrote: > > I'm so far just reading this thread and the arguments for users, and I > > haven't yet looked at all the actual details in the pull request - but > > last time I had objections to things it wasn't the code, it was the > > lack of any use.

Re: [GIT PULL] General notification queue and key notifications

2020-06-13 Thread pr-tracker-bot
The pull request you sent on Tue, 02 Jun 2020 16:55:04 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/notifications-20200601 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6c3297841472b4e53e22e53826eea9e483d993e5 Thank you! --

Re: [GIT PULL] General notification queue and key notifications

2020-06-13 Thread Linus Torvalds
On Sat, Jun 13, 2020 at 9:47 AM Linus Torvalds wrote: > > If we have multiple uses, and one of them notices some problem that > requires any ABI changes, but the other one has already started using > it, we'll have more problems. Ok, it's merged in my tree, although I was somewhat unhappy about

Re: [GIT PULL] General notification queue and key notifications

2020-06-13 Thread Linus Torvalds
On Sat, Jun 13, 2020 at 6:05 AM David Howells wrote: > > Would you be willing at this point to consider pulling the mount notifications > and fsinfo() which helps support that? I could whip up pull reqs for those > two pieces - or do you want to see more concrete patches that use it? I'd want

Re: [GIT PULL] General notification queue and key notifications

2020-06-13 Thread David Howells
Linus Torvalds wrote: > > All the next operations are done with "fd". It's nowhere used as a > > pipe, and nothing uses pipefd[1]. > > As an aside, that isn't necessarily true. > > In some of the examples, pipefd[1] is used for configuration (sizing > and adding filters), although I think

Re: [GIT PULL] General notification queue and key notifications

2020-06-13 Thread David Howells
Linus Torvalds wrote: > I'm not even convinced O_NOTIFICATION_PIPE is necessary, but at worst > it will be a useful marker. I think the only real reason for it was to > avoid any clashes with splice(), which has more complex use of the > pipe buffers. The main reason is to prevent splice

Re: [GIT PULL] General notification queue and key notifications

2020-06-12 Thread Linus Torvalds
[ Actually going through the code now ] On Wed, Jun 10, 2020 at 4:13 AM Karel Zak wrote: > > All the next operations are done with "fd". It's nowhere used as a > pipe, and nothing uses pipefd[1]. As an aside, that isn't necessarily true. In some of the examples, pipefd[1] is used for

Re: [GIT PULL] General notification queue and key notifications

2020-06-12 Thread Linus Torvalds
[ Finally getting around to this since my normal pull queue is now empty ] On Wed, Jun 10, 2020 at 4:13 AM Karel Zak wrote: > > The notification stuff looks pretty promising, but I do not understand > why we need to use pipe for this purpose The original intent was never to use the "pipe()"

Re: [GIT PULL] General notification queue and key notifications

2020-06-10 Thread Karel Zak
Hi Linus, On Tue, Jun 02, 2020 at 04:55:04PM +0100, David Howells wrote: > Can you pull this, please? It adds a general notification queue concept I'm trying to use David's notification stuff in userspace, and I guess feedback is welcome :-) The notification stuff looks pretty promising,

Re: [GIT PULL] General notification queue and key notifications

2020-06-10 Thread Christian Brauner
On Tue, Jun 02, 2020 at 04:55:04PM +0100, David Howells wrote: > Date: Tue, 02 Jun 2020 16:51:44 +0100 > > Hi Linus, > > Can you pull this, please? It adds a general notification queue concept > and adds an event source for keys/keyrings, such as linking and unlinking > keys and changing their

Re: [GIT PULL] General notification queue and key notifications

2020-06-07 Thread Ian Kent
On Wed, 2020-06-03 at 10:15 +0800, Ian Kent wrote: > On Tue, 2020-06-02 at 16:55 +0100, David Howells wrote: > > [[ With regard to the mount/sb notifications and fsinfo(), Karel > > Zak > > and > >Ian Kent have been working on making libmount use them, > > preparatory to > >working on

Re: [GIT PULL] General notification queue and key notifications

2020-06-02 Thread Ian Kent
On Tue, 2020-06-02 at 16:55 +0100, David Howells wrote: > > [[ With regard to the mount/sb notifications and fsinfo(), Karel Zak > and >Ian Kent have been working on making libmount use them, > preparatory to >working on systemd: > >

[GIT PULL] General notification queue and key notifications

2020-06-02 Thread David Howells
Date: Tue, 02 Jun 2020 16:51:44 +0100 Hi Linus, Can you pull this, please? It adds a general notification queue concept and adds an event source for keys/keyrings, such as linking and unlinking keys and changing their attributes. Thanks to Debarshi Ray, we do have a pull request to use this to

Re: [GIT PULL] General notification queue and key notifications

2020-06-02 Thread David Howells
Oops - I forgot to include the pull request. Will resend. David

[GIT PULL] General notification queue and key notifications

2020-06-02 Thread David Howells
Hi Linus, Can you pull this, please? It adds a general notification queue concept and adds an event source for keys/keyrings, such as linking and unlinking keys and changing their attributes. Thanks to Debarshi Ray, we do have a pull request to use this to fix a problem with