Re: [GIT PULL] ext4 updates for 3.11

2018-09-07 Thread Greg KH
Digging up an email thread from 2013... On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: > On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: > > On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: > > > On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: > > > > On

Re: [GIT PULL] ext4 updates for 3.11

2018-09-07 Thread Greg KH
Digging up an email thread from 2013... On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: > On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: > > On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: > > > On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: > > > > On

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Greg KH
On Thu, Jul 04, 2013 at 09:54:44AM +1000, Dave Chinner wrote: > On Wed, Jul 03, 2013 at 06:40:40PM +, Dilger, Andreas wrote: > > On 2013/03/07 12:12 PM, "Greg KH" wrote: > > >On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: > > >> On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Dave Chinner
On Wed, Jul 03, 2013 at 06:40:40PM +, Dilger, Andreas wrote: > On 2013/03/07 12:12 PM, "Greg KH" wrote: > >On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: > >> On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: > >> > For this filesystem, it seems that they don't have any

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Dilger, Andreas
On 2013/03/07 12:12 PM, "Greg KH" wrote: >On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: >> On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: >> > On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: >> > > On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: >> > > >

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Greg KH
On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: > On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: > > On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: > > > On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: > > > > On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Linus Torvalds
On Wed, Jul 3, 2013 at 4:35 AM, Theodore Ts'o wrote: > > Linus, are you in a hurry to get this fixed up? I No, I just hate seeing warnings in my (simplified) standard build. I'm used to them in the "allmodconfig" builds I do, but prefer to not see them when I just build a localized kernel. But

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Theodore Ts'o
On Tue, Jul 02, 2013 at 08:04:47PM +0200, Jan Kara wrote: > That's caused by my patches (only for certain gcc versions). map->m_len > is guaranteed to be > 0 in the first iteration (the function is called from > under if (map->m_len > 0)). I though Ted silenced that warning but > apparently he

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Theodore Ts'o
On Tue, Jul 02, 2013 at 08:04:47PM +0200, Jan Kara wrote: That's caused by my patches (only for certain gcc versions). map-m_len is guaranteed to be 0 in the first iteration (the function is called from under if (map-m_len 0)). I though Ted silenced that warning but apparently he did not.

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Linus Torvalds
On Wed, Jul 3, 2013 at 4:35 AM, Theodore Ts'o ty...@mit.edu wrote: Linus, are you in a hurry to get this fixed up? I No, I just hate seeing warnings in my (simplified) standard build. I'm used to them in the allmodconfig builds I do, but prefer to not see them when I just build a localized

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Greg KH
On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: On Tue, Jul 2, 2013 at 5:54 PM, Greg KH g...@kroah.com wrote: On Tue, Jul 02, 2013 at 05:02:21PM -0700,

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Dilger, Andreas
On 2013/03/07 12:12 PM, Greg KH g...@kroah.com wrote: On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: On Tue, Jul 2, 2013 at 5:54 PM, Greg KH g...@kroah.com

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Dave Chinner
On Wed, Jul 03, 2013 at 06:40:40PM +, Dilger, Andreas wrote: On 2013/03/07 12:12 PM, Greg KH g...@kroah.com wrote: On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: For this filesystem, it seems that they don't have

Re: [GIT PULL] ext4 updates for 3.11

2013-07-03 Thread Greg KH
On Thu, Jul 04, 2013 at 09:54:44AM +1000, Dave Chinner wrote: On Wed, Jul 03, 2013 at 06:40:40PM +, Dilger, Andreas wrote: On 2013/03/07 12:12 PM, Greg KH g...@kroah.com wrote: On Wed, Jul 03, 2013 at 01:29:41PM +1000, Dave Chinner wrote: On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Dave Chinner
On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: > On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: > > On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: > > > On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: > > >> > > >> I'm really not convinced this whole

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Greg KH
On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: > On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: > > On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: > >> > >> I'm really not convinced this whole Lustre thing was correctly > >> handled. Merging it into stable and

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Linus Torvalds
On Tue, Jul 2, 2013 at 5:54 PM, Greg KH wrote: > On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: >> >> I'm really not convinced this whole Lustre thing was correctly >> handled. Merging it into stable and yet being in such bad shape that >> it isn't enabled even there? I just

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Greg KH
On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: > On Tue, Jul 2, 2013 at 4:45 PM, Stephen Rothwell > wrote: > > > > The merge of the ext4 tree and the staging tree needs the following fixup > > (at least). It is not a biggie, as that code in staging is actually > > disabled at

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Linus Torvalds
On Tue, Jul 2, 2013 at 4:45 PM, Stephen Rothwell wrote: > > The merge of the ext4 tree and the staging tree needs the following fixup > (at least). It is not a biggie, as that code in staging is actually > disabled at the moment. Argh. I merged both of these before this email came in, so now my

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Stephen Rothwell
Hi Linus, On Mon, 01 Jul 2013 09:55:55 -0400 Theodore Ts'o wrote: > > > The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: > > Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Stephen Rothwell
On Tue, 2 Jul 2013 20:04:47 +0200 Jan Kara wrote: > > On Tue 02-07-13 10:18:32, Linus Torvalds wrote: > > Hmm I'm getting this compiler warning: > > > > fs/ext4/inode.c: In function ‘ext4_writepages’: > > fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in > > this function

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Jan Kara
On Tue 02-07-13 10:18:32, Linus Torvalds wrote: > Hmm I'm getting this compiler warning: > > fs/ext4/inode.c: In function ‘ext4_writepages’: > fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in > this function [-Wmaybe-uninitialized] > > and I think the compiler is right to

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Linus Torvalds
Hmm I'm getting this compiler warning: fs/ext4/inode.c: In function ‘ext4_writepages’: fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] and I think the compiler is right to warn. The 'err' variable is set inside a whilte() and an if()

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Linus Torvalds
Hmm I'm getting this compiler warning: fs/ext4/inode.c: In function ‘ext4_writepages’: fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] and I think the compiler is right to warn. The 'err' variable is set inside a whilte() and an if()

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Jan Kara
On Tue 02-07-13 10:18:32, Linus Torvalds wrote: Hmm I'm getting this compiler warning: fs/ext4/inode.c: In function ‘ext4_writepages’: fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] and I think the compiler is right to warn.

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Stephen Rothwell
On Tue, 2 Jul 2013 20:04:47 +0200 Jan Kara j...@suse.cz wrote: On Tue 02-07-13 10:18:32, Linus Torvalds wrote: Hmm I'm getting this compiler warning: fs/ext4/inode.c: In function ‘ext4_writepages’: fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Stephen Rothwell
Hi Linus, On Mon, 01 Jul 2013 09:55:55 -0400 Theodore Ts'o ty...@mit.edu wrote: The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at:

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Linus Torvalds
On Tue, Jul 2, 2013 at 4:45 PM, Stephen Rothwell s...@canb.auug.org.au wrote: The merge of the ext4 tree and the staging tree needs the following fixup (at least). It is not a biggie, as that code in staging is actually disabled at the moment. Argh. I merged both of these before this email

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Greg KH
On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: On Tue, Jul 2, 2013 at 4:45 PM, Stephen Rothwell s...@canb.auug.org.au wrote: The merge of the ext4 tree and the staging tree needs the following fixup (at least). It is not a biggie, as that code in staging is actually

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Linus Torvalds
On Tue, Jul 2, 2013 at 5:54 PM, Greg KH g...@kroah.com wrote: On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: I'm really not convinced this whole Lustre thing was correctly handled. Merging it into stable and yet being in such bad shape that it isn't enabled even there? I just

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Greg KH
On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: On Tue, Jul 2, 2013 at 5:54 PM, Greg KH g...@kroah.com wrote: On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: I'm really not convinced this whole Lustre thing was correctly handled. Merging it into stable and

Re: [GIT PULL] ext4 updates for 3.11

2013-07-02 Thread Dave Chinner
On Tue, Jul 02, 2013 at 06:01:11PM -0700, Greg KH wrote: On Tue, Jul 02, 2013 at 05:58:15PM -0700, Linus Torvalds wrote: On Tue, Jul 2, 2013 at 5:54 PM, Greg KH g...@kroah.com wrote: On Tue, Jul 02, 2013 at 05:02:21PM -0700, Linus Torvalds wrote: I'm really not convinced this whole

[GIT PULL] ext4 updates for 3.11

2013-07-01 Thread Theodore Ts'o
The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus for you to fetch changes up to

[GIT PULL] ext4 updates for 3.11

2013-07-01 Thread Theodore Ts'o
The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus for you to fetch changes up to