Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 01:20:29PM -0700, Linus Torvalds wrote: > I didn't look at the details of your patch, but I did look at several > IS_ERR_VALUE() uses in the standard kernel, and they were basically > all wrong. Even the ones that used it for the rigth reason (vm_brk() > that returns a

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 01:20:29PM -0700, Linus Torvalds wrote: > I didn't look at the details of your patch, but I did look at several > IS_ERR_VALUE() uses in the standard kernel, and they were basically > all wrong. Even the ones that used it for the rigth reason (vm_brk() > that returns a

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Friday, May 27, 2016 1:20:29 PM CEST Linus Torvalds wrote: > On Fri, May 27, 2016 at 1:04 PM, Arnd Bergmann wrote: > > > > In fact, the patch that I have in my private tree that was hiding the > > warning for me on x86 is one that removes all instances of IS_ERR_VALUE() > > with

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Friday, May 27, 2016 1:20:29 PM CEST Linus Torvalds wrote: > On Fri, May 27, 2016 at 1:04 PM, Arnd Bergmann wrote: > > > > In fact, the patch that I have in my private tree that was hiding the > > warning for me on x86 is one that removes all instances of IS_ERR_VALUE() > > with arguments

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 1:04 PM, Arnd Bergmann wrote: > > In fact, the patch that I have in my private tree that was hiding the > warning for me on x86 is one that removes all instances of IS_ERR_VALUE() > with arguments other than 'unsigned long', see http://pastebin.com/uYa2mkgC

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 1:04 PM, Arnd Bergmann wrote: > > In fact, the patch that I have in my private tree that was hiding the > warning for me on x86 is one that removes all instances of IS_ERR_VALUE() > with arguments other than 'unsigned long', see http://pastebin.com/uYa2mkgC > for

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Friday, May 27, 2016 10:23:00 AM CEST Linus Torvalds wrote: > On Fri, May 27, 2016 at 5:33 AM, Arnd Bergmann wrote: > > > > > > gcc can not always figure out which code is only used in an error > > condition an assignment to indirect argument is only done after the > > use of

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Friday, May 27, 2016 10:23:00 AM CEST Linus Torvalds wrote: > On Fri, May 27, 2016 at 5:33 AM, Arnd Bergmann wrote: > > > > > > gcc can not always figure out which code is only used in an error > > condition an assignment to indirect argument is only done after the > > use of IS_ERR() catches

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 10:23 AM, Linus Torvalds wrote: > > This code: > > if (IS_ERR(hash)) > return PTR_ERR(hash); > > is obviously "return non-zero" to a kernel developer (because that's > how our error codes work), but to a compiler that

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 10:23 AM, Linus Torvalds wrote: > > This code: > > if (IS_ERR(hash)) > return PTR_ERR(hash); > > is obviously "return non-zero" to a kernel developer (because that's > how our error codes work), but to a compiler that "return PTR_ERR()" > ends up

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 5:33 AM, Arnd Bergmann wrote: > > > gcc can not always figure out which code is only used in an error > condition an assignment to indirect argument is only done after the > use of IS_ERR() catches errors. In gfs2, this results in a warning > about correct

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Fri, May 27, 2016 at 5:33 AM, Arnd Bergmann wrote: > > > gcc can not always figure out which code is only used in an error > condition an assignment to indirect argument is only done after the > use of IS_ERR() catches errors. In gfs2, this results in a warning > about correct code: I figured

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Thursday, May 26, 2016 10:26:50 PM CEST Linus Torvalds wrote: > On Thu, May 26, 2016 at 1:33 PM, Michal Marek wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git kbuild > > This pull results in new warnings. > > I get new "may be uninitialized"

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Thursday, May 26, 2016 10:26:50 PM CEST Linus Torvalds wrote: > On Thu, May 26, 2016 at 1:33 PM, Michal Marek wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git kbuild > > This pull results in new warnings. > > I get new "may be uninitialized" warnings now for

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Thu, May 26, 2016 at 1:33 PM, Michal Marek wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git kbuild This pull results in new warnings. I get new "may be uninitialized" warnings now for me allmodconfig build, and while I didn't look at them all, the

Re: [GIT PULL] kbuild updates for v4.7-rc1

On Thu, May 26, 2016 at 1:33 PM, Michal Marek wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git kbuild This pull results in new warnings. I get new "may be uninitialized" warnings now for me allmodconfig build, and while I didn't look at them all, the one I looked at

[GIT PULL] kbuild updates for v4.7-rc1

Hi Linus, please pull these kbuild changes for v4.7-rc1: - New option CONFIG_TRIM_UNUSED_KSYMS which does a two-pass build and unexports symbols which are not used in the current config [Nicolas Pitre] - Several kbuild rule cleanups [Masahiro Yamada] - Warning option adjustments for gcov etc

[GIT PULL] kbuild updates for v4.7-rc1

Hi Linus, please pull these kbuild changes for v4.7-rc1: - New option CONFIG_TRIM_UNUSED_KSYMS which does a two-pass build and unexports symbols which are not used in the current config [Nicolas Pitre] - Several kbuild rule cleanups [Masahiro Yamada] - Warning option adjustments for gcov etc