Re: [GIT PULL] locking fix

The pull request you sent on Sun, 28 Mar 2021 12:28:43 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-2021-03-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/47fbbc94dab61a1385f21a0a209c61b5d6b0a215 Thank you! --

[GIT PULL] locking fix

Linus, Please pull the latest locking/urgent git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-2021-03-28 # HEAD: 291da9d4a9eb3a1cb0610b7f4480f5b52b1825e7 locking/mutex: Fix non debug version of mutex_lock_io_nested() Fix the non-debug

Re: [GIT PULL] locking fix

The pull request you sent on Sun, 14 Jul 2019 13:36:21 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/0c85ce135456a3927f552e738f730c47ac905ac3 Thank you! --

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 68d41d8c94a31dfb8233ab90b9baf41a2ed2da68 locking/lockdep: Fix lock used or unused stats error A single fix for a locking

Re: [GIT PULL] locking fix

On Thu, May 16, 2019 at 07:55:53PM -0400, Sasha Levin wrote: > On Thu, May 16, 2019 at 11:42:58AM -0700, Linus Torvalds wrote: > > On Thu, May 16, 2019 at 11:39 AM Greg KH wrote: > > > > > > Thanks, I'll work on that later tonight... > > > > Note that it probably is almost entirely impossible

Re: [GIT PULL] locking fix

On Thu, May 16, 2019 at 11:42:58AM -0700, Linus Torvalds wrote: On Thu, May 16, 2019 at 11:39 AM Greg KH wrote: Thanks, I'll work on that later tonight... Note that it probably is almost entirely impossible to trigger the problem in practice, so it's not like this is a particularly

Re: [GIT PULL] locking fix

On Thu, May 16, 2019 at 11:39 AM Greg KH wrote: > > Thanks, I'll work on that later tonight... Note that it probably is almost entirely impossible to trigger the problem in practice, so it's not like this is a particularly important stable back-port. I just happened to look at it and go "hmm,

Re: [GIT PULL] locking fix

On Thu, May 16, 2019 at 10:57:53AM -0700, Linus Torvalds wrote: > On Thu, May 16, 2019 at 9:01 AM Ingo Molnar wrote: > > > > A single rwsem fix. > > Side note, this one isn't marked for stable, but I'm hoping stable > picks it up just from the "Fixes" tag. > > Stable people, we're talking about

Re: [GIT PULL] locking fix

The pull request you sent on Thu, 16 May 2019 18:01:35 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f57d7715d7645b7c3d1e7b7cb79ac7690fe2d260 Thank you! --

Re: [GIT PULL] locking fix

On Thu, May 16, 2019 at 9:01 AM Ingo Molnar wrote: > > A single rwsem fix. Side note, this one isn't marked for stable, but I'm hoping stable picks it up just from the "Fixes" tag. Stable people, we're talking about a9e9bcb45b15 ("locking/rwsem: Prevent decrement of reader count before

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: a9e9bcb45b1525ba7aea26ed9441e8632aeeda58 locking/rwsem: Prevent decrement of reader count before increment A single rwsem

Re: [GIT PULL] locking fix

The pull request you sent on Fri, 12 Apr 2019 13:53:43 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/26e2b81977bb1ad70ff9b2acb4d4cb13c23facfd Thank you! --

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 90c1cba2b3b3851c151229f61801919b2904d437 locking/lockdep: Zap lock classes even with lock debugging disabled Fixes a crash

[GIT pull] locking fix for 4.16

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus rt_mutex_futex_unlock() grew a new irq-off call site, but the function assumes that its always called from irq enabled context. Use the

[GIT pull] locking fix for 4.16

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus rt_mutex_futex_unlock() grew a new irq-off call site, but the function assumes that its always called from irq enabled context. Use the

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 69f0d429c413fe96db2c187475cebcc6e3a8c7f5 locking/rtmutex: Remove unnecessary priority adjustment Remove an unnecessary

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 69f0d429c413fe96db2c187475cebcc6e3a8c7f5 locking/rtmutex: Remove unnecessary priority adjustment Remove an unnecessary

[GIT pull] locking fix for 4.12

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A fix for a state leak which was introduced in the recent rework of futex/rtmutex interaction. Thanks, tglx -->

[GIT pull] locking fix for 4.12

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A fix for a state leak which was introduced in the recent rework of futex/rtmutex interaction. Thanks, tglx -->

[GIT pull] locking fix for 4.10

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus Move the futex init function to core initcall so user mode helper does not run into an uninitialized futex syscall. Thanks, tglx

[GIT pull] locking fix for 4.10

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus Move the futex init function to core initcall so user mode helper does not run into an uninitialized futex syscall. Thanks, tglx

Re: [GIT pull] locking fix for 4.9

On Wed, 12 Oct 2016 10:22:59 -0700 Linus Torvalds wrote: > On Wed, Oct 12, 2016 at 1:28 AM, Steven Rostedt wrote: > > > > But I agree. We have lived a long time without the need for this > > warning. I'm not strongly advocating keeping the

Re: [GIT pull] locking fix for 4.9

On Wed, 12 Oct 2016 10:22:59 -0700 Linus Torvalds wrote: > On Wed, Oct 12, 2016 at 1:28 AM, Steven Rostedt wrote: > > > > But I agree. We have lived a long time without the need for this > > warning. I'm not strongly advocating keeping the warning around and > > just disabling it totally. But

Re: [GIT pull] locking fix for 4.9

On Wed, Oct 12, 2016 at 1:28 AM, Steven Rostedt wrote: > > But I agree. We have lived a long time without the need for this > warning. I'm not strongly advocating keeping the warning around and > just disabling it totally. But it all comes down to how much we > trust those

Re: [GIT pull] locking fix for 4.9

On Wed, Oct 12, 2016 at 1:28 AM, Steven Rostedt wrote: > > But I agree. We have lived a long time without the need for this > warning. I'm not strongly advocating keeping the warning around and > just disabling it totally. But it all comes down to how much we > trust those that inherit this after

Re: [GIT pull] locking fix for 4.9

On Mon, 10 Oct 2016 10:29:27 -0700 Linus Torvalds wrote: > On Sat, Oct 8, 2016 at 5:47 AM, Thomas Gleixner wrote: > > > > A single fix which prevents newer GCCs from spamming the build output with > > overly eager warnings about

Re: [GIT pull] locking fix for 4.9

On Mon, 10 Oct 2016 10:29:27 -0700 Linus Torvalds wrote: > On Sat, Oct 8, 2016 at 5:47 AM, Thomas Gleixner wrote: > > > > A single fix which prevents newer GCCs from spamming the build output with > > overly eager warnings about __builtin_return_address() uses which are > > correct. > > Ugh.

Re: [GIT pull] locking fix for 4.9

On Sat, Oct 8, 2016 at 5:47 AM, Thomas Gleixner wrote: > > A single fix which prevents newer GCCs from spamming the build output with > overly eager warnings about __builtin_return_address() uses which are > correct. Ugh. This feels over-engineered to me. We already disable

Re: [GIT pull] locking fix for 4.9

On Sat, Oct 8, 2016 at 5:47 AM, Thomas Gleixner wrote: > > A single fix which prevents newer GCCs from spamming the build output with > overly eager warnings about __builtin_return_address() uses which are > correct. Ugh. This feels over-engineered to me. We already disable that warning

[GIT pull] locking fix for 4.9

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A single fix which prevents newer GCCs from spamming the build output with overly eager warnings about __builtin_return_address() uses

[GIT pull] locking fix for 4.9

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A single fix which prevents newer GCCs from spamming the build output with overly eager warnings about __builtin_return_address() uses

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: d7127b5e5fa0551be21b86640f1648b224e36d43 locking/barriers: Don't use sizeof(void) in lockless_dereference() Another

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: d7127b5e5fa0551be21b86640f1648b224e36d43 locking/barriers: Don't use sizeof(void) in lockless_dereference() Another

[GIT pull] locking fix for 4.7

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A single fix to address a race in the static key logic. Thanks, tglx --> Paolo Bonzini (1):

[GIT pull] locking fix for 4.7

Linus, please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus A single fix to address a race in the static key logic. Thanks, tglx --> Paolo Bonzini (1):

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 5c8a010c2411729a07cb1b90c09fa978ac0ac6c0 locking/lockdep: Fix print_collision() unused warning Fixes a build warning on

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 5c8a010c2411729a07cb1b90c09fa978ac0ac6c0 locking/lockdep: Fix print_collision() unused warning Fixes a build warning on

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: cba77f03f2c7b6cc0b0a44a3c679e0abade7da62 locking/pvqspinlock: Fix kernel panic in locking-selftest A single fix for a locking

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: cba77f03f2c7b6cc0b0a44a3c679e0abade7da62 locking/pvqspinlock: Fix kernel panic in locking-selftest A single fix for a locking

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 35a9393c95b31870a74f51a3e7455f33f5657b6f lockdep: Fix the module unload key range freeing logic A module unload lockdep race

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 35a9393c95b31870a74f51a3e7455f33f5657b6f lockdep: Fix the module unload key range freeing logic A module unload lockdep race

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 9d3e2d02f54160725d97f4ab1e1e8de493fbf33a locking/rtmutex: Set state back to running on error An rtmutex deadlock path fixlet.

[GIT PULL] locking fix

Linus, Please pull the latest locking-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking-urgent-for-linus # HEAD: 9d3e2d02f54160725d97f4ab1e1e8de493fbf33a locking/rtmutex: Set state back to running on error An rtmutex deadlock path fixlet.

Re: [GIT PULL] locking fix

* Linus Torvalds wrote: > On Sun, Oct 27, 2013 at 12:56 PM, Maarten Lankhorst > wrote: > > > > And this is why ww_ctx == NULL is now passed as an inline > > argument. :) > > Well, more than that - the "optimization" has been done at the > source code level, so that the behavior is no longer

Re: [GIT PULL] locking fix

* Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Oct 27, 2013 at 12:56 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: And this is why ww_ctx == NULL is now passed as an inline argument. :) Well, more than that - the optimization has been done at the

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:56 PM, Maarten Lankhorst wrote: > > And this is why ww_ctx == NULL is now passed as an inline argument. :) Well, more than that - the "optimization" has been done at the source code level, so that the behavior is no longer a matter about how well the compiler optimizes

Re: [GIT PULL] locking fix

op 27-10-13 20:51, Linus Torvalds schreef: > On Sun, Oct 27, 2013 at 12:37 PM, Maarten Lankhorst > wrote: >> I would love for a compiler to become that smart though, but I do not think >> it's likely. > Dammit, even if that is true, then write the conditional *correctly*. > > As mentioned, the

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:37 PM, Maarten Lankhorst wrote: > > I would love for a compiler to become that smart though, but I do not think > it's likely. Dammit, even if that is true, then write the conditional *correctly*. As mentioned, the conditional __builtin_constant_p(ww_ctx) &&

Re: [GIT PULL] locking fix

op 27-10-13 20:23, Linus Torvalds schreef: > On Sun, Oct 27, 2013 at 12:00 PM, Maarten Lankhorst > wrote: >> op 27-10-13 18:28, Linus Torvalds schreef: >>> That expression is largely equivalent to >>> "__builtin_constant_p(ww_ctx)" (because iff ww_ctx is constant, then >>> the comparison to NULL

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:23 PM, Linus Torvalds wrote: > > The *ONLY* thing it is testing for is "how much can the compiler > optimize this", and as such the *ONLY* thing it tests for is compiler > differences. Side note: testing "can the compiler optimize this expression at compile time" is

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:00 PM, Maarten Lankhorst wrote: > op 27-10-13 18:28, Linus Torvalds schreef: >> >> That expression is largely equivalent to >> "__builtin_constant_p(ww_ctx)" (because iff ww_ctx is constant, then >> the comparison to NULL is constant), which is actually much easier to

Re: [GIT PULL] locking fix

op 27-10-13 18:28, Linus Torvalds schreef: > On Sat, Oct 26, 2013 at 5:19 AM, Ingo Molnar wrote: >> This tree fixes a boot crash in CONFIG_DEBUG_MUTEXES=y kernels, on >> kernels built with GCC 3.x. (There are still such distros.) > Btw, it's really not just gcc 3.x. That code was (a)

Re: [GIT PULL] locking fix

On Sat, Oct 26, 2013 at 5:19 AM, Ingo Molnar wrote: > > This tree fixes a boot crash in CONFIG_DEBUG_MUTEXES=y kernels, on > kernels built with GCC 3.x. (There are still such distros.) Btw, it's really not just gcc 3.x. That code was (a) incomprehensible, (b) wrong and (c) caused problems for

Re: [GIT PULL] locking fix

On Sat, Oct 26, 2013 at 5:19 AM, Ingo Molnar mi...@kernel.org wrote: This tree fixes a boot crash in CONFIG_DEBUG_MUTEXES=y kernels, on kernels built with GCC 3.x. (There are still such distros.) Btw, it's really not just gcc 3.x. That code was (a) incomprehensible, (b) wrong and (c) caused

Re: [GIT PULL] locking fix

op 27-10-13 18:28, Linus Torvalds schreef: On Sat, Oct 26, 2013 at 5:19 AM, Ingo Molnar mi...@kernel.org wrote: This tree fixes a boot crash in CONFIG_DEBUG_MUTEXES=y kernels, on kernels built with GCC 3.x. (There are still such distros.) Btw, it's really not just gcc 3.x. That code was (a)

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:00 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 27-10-13 18:28, Linus Torvalds schreef: That expression is largely equivalent to __builtin_constant_p(ww_ctx) (because iff ww_ctx is constant, then the comparison to NULL is constant), which is

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:23 PM, Linus Torvalds torva...@linux-foundation.org wrote: The *ONLY* thing it is testing for is how much can the compiler optimize this, and as such the *ONLY* thing it tests for is compiler differences. Side note: testing can the compiler optimize this expression

Re: [GIT PULL] locking fix

op 27-10-13 20:23, Linus Torvalds schreef: On Sun, Oct 27, 2013 at 12:00 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: op 27-10-13 18:28, Linus Torvalds schreef: That expression is largely equivalent to __builtin_constant_p(ww_ctx) (because iff ww_ctx is constant, then the

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:37 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I would love for a compiler to become that smart though, but I do not think it's likely. Dammit, even if that is true, then write the conditional *correctly*. As mentioned, the conditional

Re: [GIT PULL] locking fix

op 27-10-13 20:51, Linus Torvalds schreef: On Sun, Oct 27, 2013 at 12:37 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I would love for a compiler to become that smart though, but I do not think it's likely. Dammit, even if that is true, then write the conditional *correctly*.

Re: [GIT PULL] locking fix

On Sun, Oct 27, 2013 at 12:56 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: And this is why ww_ctx == NULL is now passed as an inline argument. :) Well, more than that - the optimization has been done at the source code level, so that the behavior is no longer a matter about how

[GIT PULL] locking fix

Linus, Please pull the latest core-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus # HEAD: b0267507dfd0187fb7840a0ec461a510a7f041c5 mutex: Avoid gcc version dependent __builtin_constant_p() usage This tree fixes a boot

[GIT PULL] locking fix

Linus, Please pull the latest core-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-for-linus # HEAD: b0267507dfd0187fb7840a0ec461a510a7f041c5 mutex: Avoid gcc version dependent __builtin_constant_p() usage This tree fixes a boot