Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-06-08 Thread Sebastian Ott
Hello, On Wed, 30 May 2018, Sebastian Ott wrote: > On Wed, 30 May 2018, Christoph Hellwig wrote: > > > - req->completion_data = cqr; > > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > > > + > > > > Please don't play such tricks. In general your driver structure > > should have st

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-06-04 Thread Martin Schwidefsky
On Thu, 31 May 2018 09:14:00 -0700 Christoph Hellwig wrote: > On Wed, May 30, 2018 at 11:11:40AM +0200, Martin Schwidefsky wrote: > > On Wed, 30 May 2018 00:41:30 -0700 > > Christoph Hellwig wrote: > > > > > > - req->completion_data = cqr; > > > > + *((struct dasd_ccw_req **) blk_

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-05-31 Thread Christoph Hellwig
On Wed, May 30, 2018 at 11:11:40AM +0200, Martin Schwidefsky wrote: > On Wed, 30 May 2018 00:41:30 -0700 > Christoph Hellwig wrote: > > > > - req->completion_data = cqr; > > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > > > + > > > > Please don't play such tricks. In general

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-05-30 Thread Sebastian Ott
On Wed, 30 May 2018, Christoph Hellwig wrote: > > - req->completion_data = cqr; > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > > + > > Please don't play such tricks. In general your driver structure > should have struct request embedded. If for some reason > struct dasd_cc

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-05-30 Thread Martin Schwidefsky
On Wed, 30 May 2018 00:41:30 -0700 Christoph Hellwig wrote: > > - req->completion_data = cqr; > > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > > + > > Please don't play such tricks. In general your driver structure > should have struct request embedded. If for some reason

Re: [GIT PULL] two more s390 bug fixes for 4.17

2018-05-30 Thread Christoph Hellwig
> - req->completion_data = cqr; > + *((struct dasd_ccw_req **) blk_mq_rq_to_pdu(req)) = cqr; > + Please don't play such tricks. In general your driver structure should have struct request embedded. If for some reason struct dasd_ccw_req has a different life time please create a new struc

[GIT PULL] two more s390 bug fixes for 4.17

2018-05-29 Thread Martin Schwidefsky
Hi Linus, please pull from the 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus to receive the following updates: Two bug fixes for 4.17 * A missing -msoft-float for the compile of the kexec purgatory * A fix for the dasd driver to avoid t