Re: [GIT PULL] x86/mm changes for v5.9

Hi Ingo, On Thu, Aug 13, 2020 at 09:30:08PM +0200, Ingo Molnar wrote: > Mind re-sending it, with an updated changelog that explains why it's > now truly safe? I have updated the commit and will send it out later today, maybe together with a comment update in the preallocate_vmalloc_pages()

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 13, 2020 at 12:30 PM Ingo Molnar wrote: > > Would be tentatively scheduled for v5.10 though, we've had enough > excitement in this area for v5.9 I think. :-/ I think I can take it for 5.9 again if you send a pull request my way. If it causes any other problems, we'll obviously

Re: [GIT PULL] x86/mm changes for v5.9

* Joerg Roedel wrote: > On Thu, Aug 06, 2020 at 11:20:19PM +0200, Ingo Molnar wrote: > > I've reverted it in x86/urgent as well earlier today, can send you > > that tree right now if you prefer that route. > > I sent a fix for preallocate_vmalloc_pages() to correctly pre-allocate > the

Re: [GIT PULL] x86/mm changes for v5.9

Hey Joerg, On Thu, Aug 6, 2020 at 9:23 PM Joerg Roedel wrote: > Jason, can you share more details about the test setup which triggers > this? Like the .config and the machine setup, ideally a qemu > command-line, and how to reproduce it on that setup. make -C

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 06, 2020 at 11:20:19PM +0200, Ingo Molnar wrote: > I've reverted it in x86/urgent as well earlier today, can send you > that tree right now if you prefer that route. I sent a fix for preallocate_vmalloc_pages() to correctly pre-allocate the vmalloc PGD entries. I verified that it

Re: [GIT PULL] x86/mm changes for v5.9

On Fri, Aug 07, 2020 at 12:56:51AM +0200, Joerg Roedel wrote: > I still don't fully understand why, but its late here and my head spins. > So I take another look tomorrow in the hope to understand it better. I think I know what the bug is, I am calling p4d_offset(pgd, addr) without checking for

Re: [GIT PULL] x86/mm changes for v5.9

On Wed, Aug 05, 2020 at 01:03:48PM +0200, Jason A. Donenfeld wrote: > BUG: unable to handle page fault for address: e8d00608 Okay, looks like my usage of the page-table macros is bogus, seems I don't understand their usage as good as I thought. The p?d_none checks in the allocation path

Re: [GIT PULL] x86/mm changes for v5.9

* Linus Torvalds wrote: > On Thu, Aug 6, 2020 at 11:57 AM Joerg Roedel wrote: > > > > On Thu, Aug 06, 2020 at 03:10:34PM +0200, Ingo Molnar wrote: > > > > > > * Linus Torvalds wrote: > > > > So apparently the "the page-table pages are all pre-allocated now" is > > > > simply not true. Joerg?

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 06, 2020 at 12:42:23PM -0700, Linus Torvalds wrote: > that admittedly odd sequence is get_work_pwq(work) > > And then the faulting instruction is: > > > 2a:* 49 8b 46 08 mov0x8(%r14),%rax <-- trapping instruction > > and this is the "->wq" dereference. > > So it's

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 6, 2020 at 12:23 PM Joerg Roedel wrote: > > Yes, that's the best for now. My gut feeling is that the fault Jason is > seeing didn't happen on a vmalloc address, but I can't prove that yet. No, it's definitely fairly high in the vmalloc space. Look at the faulting address: BUG:

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 06, 2020 at 12:02:40PM -0700, Linus Torvalds wrote: > But you may obviously have different settings for CONFIG_X86_5LEVEL, > and maybe that ends up changing something? > > But since apparently it's not immediately obvious what the problem is, > I'll revert it for now. Yes, that's the

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 6, 2020 at 11:57 AM Joerg Roedel wrote: > > On Thu, Aug 06, 2020 at 03:10:34PM +0200, Ingo Molnar wrote: > > > > * Linus Torvalds wrote: > > > So apparently the "the page-table pages are all pre-allocated now" is > > > simply not true. Joerg? > > It pre-allocates the whole

Re: [GIT PULL] x86/mm changes for v5.9

On Thu, Aug 06, 2020 at 03:10:34PM +0200, Ingo Molnar wrote: > > * Linus Torvalds wrote: > > So apparently the "the page-table pages are all pre-allocated now" is > > simply not true. Joerg? It pre-allocates the whole vmalloc/ioremap PUD/P4D pages, but I actually only tested it with 4-level

Re: [GIT PULL] x86/mm changes for v5.9

* Linus Torvalds wrote: > On Wed, Aug 5, 2020 at 4:03 AM Jason A. Donenfeld wrote: > > > > The commit 8bb9bf242d1f ("x86/mm/64: Do not sync vmalloc/ioremap > > mappings") causes the OOPS below, in Linus' tree and in linux-next, > > unearthed by my CI on

Re: [GIT PULL] x86/mm changes for v5.9

Hi Ingo, Joerg, On Mon, Aug 03, 2020 at 09:03:54PM +0200, Ingo Molnar wrote: > Linus, > > Please pull the latest x86/mm git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-mm-2020-08-03 > ># HEAD: 2b32ab031e82a109e2c5b0d30ce563db0fe286b4 x86/mm/64: Make >

Re: [GIT PULL] x86/mm changes for v5.9

On Wed, Aug 5, 2020 at 4:03 AM Jason A. Donenfeld wrote: > > The commit 8bb9bf242d1f ("x86/mm/64: Do not sync vmalloc/ioremap > mappings") causes the OOPS below, in Linus' tree and in linux-next, > unearthed by my CI on . > Bisecting reveals 8bb9bf242d1f,

Re: [GIT PULL] x86/mm changes for v5.9

The pull request you sent on Mon, 3 Aug 2020 21:03:54 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-mm-2020-08-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e96ec8cf9ca12a8d6b3b896a2eccd4b92a1893ab Thank you! -- Deet-doot-dot, I am a

[GIT PULL] x86/mm changes for v5.9

Linus, Please pull the latest x86/mm git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-mm-2020-08-03 # HEAD: 2b32ab031e82a109e2c5b0d30ce563db0fe286b4 x86/mm/64: Make sync_global_pgds() static The biggest change is to not sync the vmalloc and ioremap ranges for