Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!
On 11/22, Linus Torvalds wrote:
>On Tue, Nov 22, 2016 at 10:44 PM, Fengguang Wu wrote:
>>
>> On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote:
>>
>>> I also noticed that the kernel test robot had screwed up the
>>> participants list for some reason, and had
>>>
>>> "Acked-by: Alexander Duyck , David S.
>>> Miller"
>>>
>>> as one of the participants. So there's some odd commit parsing issue
>>> there somewhere. But Alexander seems to have seen this report despite
>>> that, it just never went anywhere that I can tell.
>>
>>
>> Yeah the robot will CC all "Acked-by" people in the bug reports.
>>
>> Shall we limit it to the below TO/CC list?
>
>No. We do want to keep the Acked-by's on the cc.
>
>But you missed the real problem.
>
>It *didn't* cc the acked-by. Look closer. What happened was that it cc'd this:
>
> "Acked-by: Alexander Duyck , David S. Miller"
>
>
>
Seems that the robot failed to parse the commit log correctly due to
the "Reported-by: xxx" line missed '>' in the end, the robot got fooled
by it and generated wrong result, we'll try to improve it to handle this
kind of case.
net: __skb_flow_dissect() must cap its return value
After Tom patch, thoff field could point past the end of the buffer,
this could fool some callers.
If an skb was provided, skb->len should be the upper limit.
If not, hlen is supposed to be the upper limit.
Fixes: a6e544b0a88b ("flow_dissector: Jump to exit code in
__skb_flow_dissect")
Signed-off-by: Eric Dumazet
Reported-by: Yibin Yang
Acked-by: Willem de Bruijn
Acked-by: Alexei Starovoitov
Signed-off-by: David S. Miller
Thanks,
Xiaolong
>ie there is only _one_ email address (that of da...@davemloft.net),
>and the whole "Acked-by: Alexander Duyck <...>" part is quoted as the
>_name_ of that email address.
>
>At least that's what the headers look like for me in the original report:
>
> From: kernel test robot
> To: Eric Dumazet
> Cc: l...@01.org, Linus Torvalds ,
>LKML , Alexei Starovoitov
>, Willem de Bruijn , "Acked-by:
>Alexander Duyck , David S. Miller"
>
>
>Notice the quoting of that last "name".
>
> Linus
Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!
On Tue, Nov 22, 2016 at 11:07:16PM -0800, Linus Torvalds wrote: On Tue, Nov 22, 2016 at 10:44 PM, Fengguang Wu wrote: On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote: I also noticed that the kernel test robot had screwed up the participants list for some reason, and had "Acked-by: Alexander Duyck , David S. Miller" as one of the participants. So there's some odd commit parsing issue there somewhere. But Alexander seems to have seen this report despite that, it just never went anywhere that I can tell. Yeah the robot will CC all "Acked-by" people in the bug reports. Shall we limit it to the below TO/CC list? No. We do want to keep the Acked-by's on the cc. But you missed the real problem. It *didn't* cc the acked-by. Look closer. What happened was that it cc'd this: "Acked-by: Alexander Duyck , David S. Miller" ie there is only _one_ email address (that of da...@davemloft.net), and the whole "Acked-by: Alexander Duyck <...>" part is quoted as the _name_ of that email address. At least that's what the headers look like for me in the original report: From: kernel test robot To: Eric Dumazet Cc: l...@01.org, Linus Torvalds , LKML , Alexei Starovoitov , Willem de Bruijn , "Acked-by: Alexander Duyck , David S. Miller" Notice the quoting of that last "name". Ah thanks! Xiaolong just root caused the parse error and will fix it. Interestingly we didn't see that problem -- the CC list looks correct in our emails -- perhaps Intel's email system auto fixed up the header. Thanks, Fengguang
Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!
On Tue, Nov 22, 2016 at 10:44 PM, Fengguang Wu wrote: > > On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote: > >> I also noticed that the kernel test robot had screwed up the >> participants list for some reason, and had >> >> "Acked-by: Alexander Duyck , David S. >> Miller" >> >> as one of the participants. So there's some odd commit parsing issue >> there somewhere. But Alexander seems to have seen this report despite >> that, it just never went anywhere that I can tell. > > > Yeah the robot will CC all "Acked-by" people in the bug reports. > > Shall we limit it to the below TO/CC list? No. We do want to keep the Acked-by's on the cc. But you missed the real problem. It *didn't* cc the acked-by. Look closer. What happened was that it cc'd this: "Acked-by: Alexander Duyck , David S. Miller" ie there is only _one_ email address (that of da...@davemloft.net), and the whole "Acked-by: Alexander Duyck <...>" part is quoted as the _name_ of that email address. At least that's what the headers look like for me in the original report: From: kernel test robot To: Eric Dumazet Cc: l...@01.org, Linus Torvalds , LKML , Alexei Starovoitov , Willem de Bruijn , "Acked-by: Alexander Duyck , David S. Miller" Notice the quoting of that last "name". Linus
Re: [LKP] [net] 34fad54c25: kernel BUG at include/linux/skbuff.h:1935!
Hi Linus,
On Tue, Nov 22, 2016 at 02:04:42PM -0800, Linus Torvalds wrote:
[snip]
I also noticed that the kernel test robot had screwed up the
participants list for some reason, and had
"Acked-by: Alexander Duyck , David S.
Miller"
as one of the participants. So there's some odd commit parsing issue
there somewhere. But Alexander seems to have seen this report despite
that, it just never went anywhere that I can tell.
Yeah the robot will CC all "Acked-by" people in the bug reports.
Shall we limit it to the below TO/CC list?
TO: author
CC: committer (maintainer)
CC: all Signed-off-by
CC: all Reviewed-by
CC: mailing lists, if the bug is found in a maintainer/well known tree
Regards,
Fengguang
On Tue, Nov 15, 2016 at 1:20 PM, kernel test robot
wrote:
FYI, we noticed the following commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
commit 34fad54c2537f7c99d07375e50cb30aa3c23bd83 ("net: __skb_flow_dissect() must cap
its return value")
in testcase: pbzip2
with following parameters:
nr_threads: 25%
blocksize: 900K
cpufreq_governor: performance
on test machine: 48 threads 2 sockets Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz
with 64G memory
caused below changes:
+--+++
| | 79774d6bfa
| 34fad54c25 |
+--+++
| boot_successes | 0
| 2 |
| boot_failures| 2
| 20 |
| invoked_oom-killer:gfp_mask=0x | 2
| 2 |
| Mem-Info | 2
| 2 |
| Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 2
| 2 |
| kernel_BUG_at_include/linux/skbuff.h | 0
| 16 |
| invalid_opcode:#[##]SMP | 0
| 16 |
| RIP:eth_type_trans | 0
| 16 |
| Kernel_panic-not_syncing:Fatal_exception_in_interrupt| 0
| 15 |
| calltrace:hub_event | 0
| 1 |
| WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup| 0
| 2 |
| calltrace:parport_pc_init| 0
| 2 |
| calltrace:SyS_finit_module | 0
| 2 |
| WARNING:at_lib/kobject.c:#kobject_add_internal | 0
| 2 |
+--+++
[ 19.375251] IPv6: ADDRCONF(NETDEV_UP): eth1: link is not ready
[ 19.388892] Sending DHCP requests .
[ 19.388892] [ cut here ]
[ 19.388894] kernel BUG at include/linux/skbuff.h:1935!
[ 19.388895] invalid opcode: [#1] SMP
[ 19.388896] Modules linked in:
[ 19.388897] CPU: 0 PID: 0 Comm: swapper/0 Not tainted
4.9.0-rc3-00320-g34fad54 #1
[ 19.388898] Hardware name: Intel Corporation S2600WP/S2600WP, BIOS
SE5C600.86B.02.02.0002.122320131210 12/23/2013
[ 19.388899] task: 81e0e4c0 task.stack: 81e0
[ 19.388904] RIP: 0010:[] []
eth_type_trans+0xe8/0x140
[ 19.388904] RSP: :88081e803db8 EFLAGS: 00010297
[ 19.388905] RAX: 0152 RBX: 88080221f200 RCX: 1073
[ 19.388905] RDX: 8808013afdc0 RSI: 880801114000 RDI: 880819407c00
[ 19.388906] RBP: 88081e803e20 R08: 880801114000 R09: 0800
[ 19.388907] R10: 8808013afec0 R11: ea003fd5a880 R12: 880819407c00
[ 19.388907] R13: 881033408000 R14: c9000843e000 R15: 0158
[ 19.388908] FS: () GS:88081e80()
knlGS:
[ 19.388909] CS: 0010 DS: ES: CR0: 80050033
[ 19.388910] CR2: 88103000 CR3: 01e07000 CR4: 001406f0
[ 19.388910] Stack:
[ 19.388912] 816905a7 ea003fd5a880 ea08
88080221f050
[ 19.388913] 88080221f000 00400160 ea003fd5a880
[ 19.388915] 0040 88080221f050
88100d216000
[ 19.388915] Call Trace:
[ 19.388919]
[ 19.388919] [] ? igb_clean_rx_irq+0x6a7/0x7d0
[ 19.388921] [] igb_poll+0x382/0x700
[ 19.388922] [] ? igb_poll+0x397/0x700
[ 19.388925] [] net_rx_action+0x217/0x360
[ 19.388928] [] __do_softirq+0x104/0x2ab
[ 19.388931] [] irq_exit+0xf1/0x100
[ 19.388932] [] do_IRQ+0x54/0xd0
[ 19.388935] [] common_interrupt+0x
