Re: [LTP] [PATCH v2] syscall/ptrace08: Simplify the test.

2020-09-10 Thread Cyril Hrubis
Hi! > looks good and the test passes on older fixed kernels. Just one > compatibility issue below. I've fixed that and also the kernel version when the behavior had changed and pushed, thanks for the review and testing. ... > > + if (TST_RET != -1) { > > + tst_res(TFAIL, "ptrace()

Re: [LTP] [PATCH v2] syscall/ptrace08: Simplify the test.

2020-09-04 Thread Cyril Hrubis
Hi! > + /* > + * The original fix for the kernel haven't rejected the kernel address > + * right away when breakpoint was modified from userspace it was > + * disabled and the EINVAL was returned when dr7 was written to enable > + * it again. > + */ > + if

Re: [LTP] [PATCH v2] syscall/ptrace08: Simplify the test.

2020-09-04 Thread Martin Doucha
Hi, looks good and the test passes on older fixed kernels. Just one compatibility issue below. Otherwise: Reviewed-by: Martin Doucha On 04. 09. 20 16:09, Cyril Hrubis wrote: > The original test was attempting to crash the kernel by setting a > breakpoint on do_debug kernel function which, when