Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Toshi Kani
On Mon, 2015-04-06 at 11:26 -0700, Yinghai Lu wrote: > On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani wrote: > > On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: > > > OK, I will send a patch for the fix, with suggested update from > > Christoph of not to re-add 'type' argument to

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Yinghai Lu
On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani wrote: > On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: > OK, I will send a patch for the fix, with suggested update from > Christoph of not to re-add 'type' argument to e820_end_pfn(). > > Yinghai, I will add your sign-off to the patch. Let me

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Toshi Kani
On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: > * Toshi Kani wrote: > > > On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: > > > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > > > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: > > > > : > > > >> @@ -748,7

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Christoph Hellwig
On Fri, Apr 03, 2015 at 10:12:39AM -0700, Yinghai Lu wrote: > > Should we also delete this code, accounting E820_PRAM as ram, along with > > the deletion of reserve_pmem() in this version? > > should revert those end_of_ram change as attached. This works fine for me: Tested-by: Christoph

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Ingo Molnar
* Yinghai Lu wrote: > On Sat, Apr 4, 2015 at 2:40 AM, Ingo Molnar wrote: > > > > * Toshi Kani wrote: > > > >> On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: > >> > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > >> > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: >

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Boaz Harrosh
On 04/05/2015 11:06 PM, Yinghai Lu wrote: > On Sun, Apr 5, 2015 at 2:18 AM, Boaz Harrosh wrote: <> >> Hi Yinghai, Toshi >> >> In my old patches I did not have these updates as well, and everything >> was very much usable, for a long time. >> >> However. I actually liked these changes in

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Toshi Kani
On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: * Toshi Kani toshi.k...@hp.com wrote: On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: :

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Yinghai Lu
On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani toshi.k...@hp.com wrote: On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: OK, I will send a patch for the fix, with suggested update from Christoph of not to re-add 'type' argument to e820_end_pfn(). Yinghai, I will add your sign-off to the

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Toshi Kani
On Mon, 2015-04-06 at 11:26 -0700, Yinghai Lu wrote: On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani toshi.k...@hp.com wrote: On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: OK, I will send a patch for the fix, with suggested update from Christoph of not to re-add 'type' argument to

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Ingo Molnar
* Yinghai Lu ying...@kernel.org wrote: On Sat, Apr 4, 2015 at 2:40 AM, Ingo Molnar mi...@kernel.org wrote: * Toshi Kani toshi.k...@hp.com wrote: On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed,

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Boaz Harrosh
On 04/05/2015 11:06 PM, Yinghai Lu wrote: On Sun, Apr 5, 2015 at 2:18 AM, Boaz Harrosh b...@plexistor.com wrote: Hi Yinghai, Toshi In my old patches I did not have these updates as well, and everything was very much usable, for a long time. However. I actually liked these changes in

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-06 Thread Christoph Hellwig
On Fri, Apr 03, 2015 at 10:12:39AM -0700, Yinghai Lu wrote: Should we also delete this code, accounting E820_PRAM as ram, along with the deletion of reserve_pmem() in this version? should revert those end_of_ram change as attached. This works fine for me: Tested-by: Christoph Hellwig

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-05 Thread Yinghai Lu
On Sun, Apr 5, 2015 at 2:18 AM, Boaz Harrosh wrote: > On 04/03/2015 08:12 PM, Yinghai Lu wrote: >> On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: >>> On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: >>> : @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align)

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-05 Thread Boaz Harrosh
On 04/03/2015 08:12 PM, Yinghai Lu wrote: > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: >> On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: >> : >>> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) >>> /* >>> * Find the highest page frame number we have

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-05 Thread Yinghai Lu
On Sat, Apr 4, 2015 at 2:40 AM, Ingo Molnar wrote: > > * Toshi Kani wrote: > >> On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: >> > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: >> > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: >> > >> > should revert those end_of_ram

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-05 Thread Boaz Harrosh
On 04/03/2015 08:12 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) /* * Find the highest page frame number we

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-05 Thread Yinghai Lu
On Sat, Apr 4, 2015 at 2:40 AM, Ingo Molnar mi...@kernel.org wrote: * Toshi Kani toshi.k...@hp.com wrote: On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote:

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-05 Thread Yinghai Lu
On Sun, Apr 5, 2015 at 2:18 AM, Boaz Harrosh b...@plexistor.com wrote: On 04/03/2015 08:12 PM, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : @@ -748,7 +758,7 @@ u64 __init

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-04 Thread Ingo Molnar
* Toshi Kani wrote: > On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: > > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: > > > : > > >> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) > > >> /*

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-04 Thread Ingo Molnar
* Toshi Kani toshi.k...@hp.com wrote: On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size,

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-03 Thread Toshi Kani
On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: > > : > >> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) > >> /* > >> * Find the highest page

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: > : >> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) >> /* >> * Find the highest page frame number we have available >> */ >> -static unsigned long

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-03 Thread Toshi Kani
On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : > @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) > /* > * Find the highest page frame number we have available > */ > -static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned > type) >

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-03 Thread Toshi Kani
On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) /* * Find the highest page frame number we have available */ -static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type) +static

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-03 Thread Yinghai Lu
On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) /* * Find the highest page frame number we have available */ -static unsigned long

Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type

2015-04-03 Thread Toshi Kani
On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani toshi.k...@hp.com wrote: On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: : @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) /* * Find the highest page